RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-13 Thread Huang Changming-R66093
Thanks Jerry Huang > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Tuesday, February 14, 2012 4:44 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Jain Priyanka-B32167 > Subject: Re: [PATCH v7] ESDHC: Workaround for data crc

Re: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-13 Thread Chris Ball
Hi, On Mon, Feb 13 2012, Huang Changming-R66093 wrote: >> Actually, I think I'm still missing something. Why doesn't this work? >> >> +static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int >> +clock) { >> + /* Workaround to reduce the clock frequency for p1010 esdhc */ >> +

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-12 Thread Huang Changming-R66093
> > On Sun, Feb 12 2012, Chris Ball wrote: > > Hi, > > > > On Sun, Feb 12 2012, Huang Changming-R66093 wrote: > >> You are right. > >> I want to use the below code in header file "drivers/mmc/host/sdhci- > esdhc.h": > >> if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) then I > >> can a

Re: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-12 Thread Chris Ball
Hi, On Sun, Feb 12 2012, Chris Ball wrote: > Hi, > > On Sun, Feb 12 2012, Huang Changming-R66093 wrote: >> You are right. >> I want to use the below code in header file "drivers/mmc/host/sdhci-esdhc.h": >> if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) >> then I can avoid the twice te

Re: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-12 Thread Chris Ball
Hi, On Sun, Feb 12 2012, Huang Changming-R66093 wrote: > You are right. > I want to use the below code in header file "drivers/mmc/host/sdhci-esdhc.h": > if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) > then I can avoid the twice test of the clock. > do you think if it is reasonable?

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-12 Thread Huang Changming-R66093
Hi, Chris > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Sunday, February 12, 2012 5:20 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Jain Priyanka-B32167 > Subject: Re: [PATCH v7] ESDHC: Workaround for data crc error o

Re: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-11 Thread Chris Ball
Hi, On Wed, Feb 08 2012, Huang Changming-R66093 wrote: >> > +static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int >> clock) >> > +{ >> > + /* Workaround to reduce the clock frequency for p1010 esdhc */ >> > + if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) { >> > +

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-08 Thread Huang Changming-R66093
> -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Wednesday, February 08, 2012 11:07 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Jain Priyanka- > B32167 > Subject: Re: [PATCH v7] ESDHC: Workaround

Re: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-08 Thread Chris Ball
Hi, On Wed, Feb 08 2012, r66...@freescale.com wrote: > From: Jerry Huang > > SD card read was failing (data crc error)on some cards at > maximum possible frequency on P1010(CCB frequency set to 400MHz). > Some clock deviations are also observed at this frequency. > Hence reduced the mmc clock fre

[PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-08 Thread r66093
From: Jerry Huang SD card read was failing (data crc error)on some cards at maximum possible frequency on P1010(CCB frequency set to 400MHz). Some clock deviations are also observed at this frequency. Hence reduced the mmc clock freq. Signed-off-by: Priyanka Jain Singed-off-by: Jerry Huang CC: