Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-03-11 Thread Konstantin Dorfman
Hello Jaehoon, On Fri, January 20, 2012 8:48 am, Jaehoon Chung wrote: ... diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c index 4d41fa9..109d0f0 100644 --- a/drivers/mmc/core/mmc_ops.c +++ b/drivers/mmc/core/mmc_ops.c @@ -392,13 +392,22 @@ int mmc_switch(struct mmc_card

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-03-11 Thread Jaehoon Chung
On 03/12/2012 01:06 AM, Konstantin Dorfman wrote: Hello Jaehoon, On Fri, January 20, 2012 8:48 am, Jaehoon Chung wrote: ... diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c index 4d41fa9..109d0f0 100644 --- a/drivers/mmc/core/mmc_ops.c +++ b/drivers/mmc/core/mmc_ops.c

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-24 Thread Saugata Das
Hi Jaehoon Since you are planning to rework this patch, can you consider to implement the periodic BKOPS level check and triggering BKOPS at level 1 when the queue is idle ? On 24 February 2012 14:08, Jaehoon Chung jh80.ch...@samsung.com wrote: On 02/23/2012 06:05 PM, Adrian Hunter wrote: On

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-24 Thread Jae hoon Chung
2012/2/24 Saugata Das saugata@linaro.org: Hi Jaehoon Since you are planning to rework this patch, can you consider to implement the periodic BKOPS level check and triggering BKOPS at level 1 when the queue is idle ? Hi Saugata, Sure..i'm considering them.. I have implemented and tested

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-21 Thread Konstantin Dorfman
Hello Jaehoon, I'm testing your patch and will post review soon. Have you ever seen urgent BKOPS triggered? I have BUGON() on such event and till now never seen it. -- Konstantin Dorfman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-21 Thread Jae hoon Chung
2012/2/21 Konstantin Dorfman kdorf...@codeaurora.org: Hello Jaehoon, I'm testing your patch and will post review soon. Have you ever seen urgent BKOPS triggered? I have BUGON() on such event and till now never seen it. Hi Konstantin.. Actually, i didn't urgent BKOPS(level-3), but i have seen

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-21 Thread Jaehoon Chung
Hi Konstantin I didn't see the level-3, but have seen the level-2. URGENT_BKOPS should be triggered when the levels is either 2 or 3. So maybe you can see the URGENT_BKOPS with level-2. Best Regards, Jaehoon Chung On 02/21/2012 11:21 PM, Jae hoon Chung wrote: 2012/2/21 Konstantin Dorfman

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-14 Thread Jaehoon Chung
On 02/14/2012 08:41 PM, Saugata Das wrote: On 20 January 2012 12:18, Jaehoon Chung jh80.ch...@samsung.com wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-03 Thread Jae hoon Chung
Hi all.. Any review for this patch..or test.. If i need to change more...let me know... it's helpful to me whatever... To Adrian If you want to change this patch that didn't use the hpi when level-3, i will consider your opinion and try to change for your comment Best regards, Jaehoon Chung

[PATCH v7] mmc: support BKOPS feature for eMMC

2012-01-19 Thread Jaehoon Chung
Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then