RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-11-15 Thread Seungwon Jeon
Hi Maya, Thanks to remind it. I'm struggling with something. I didn't check more since v8. Hi Chris, As we know, nand flash write is slower than read, because write is costly operation. Write operation need block erase operation. Of course, if there is free block to write, erase will not happe

Re: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-11-14 Thread merez
Hi Chris, The amount of improvement from the packed commands, as from any other eMMC4.5 feature, depends on several parameters: 1. The card support of this feature. If the card supports only the feature interface, then you'll see no improvement when using the feature. 2. The benchmark tool used. S

Re: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-11-13 Thread Chris Ball
Hi Maya, On Sun, Nov 04 2012, me...@codeaurora.org wrote: > Packed commands is a mandatory eMMC4.5 feature and is supported by all > the card vendors. We're still only talking about using packed writes, though, right? > It wa proven to be beneficial for eMMC4.5 cards and harmless for non > eMMC4

RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-11-03 Thread merez
Hi Chris, Packed commands is a mandatory eMMC4.5 feature and is supported by all the card vendors. It wa proven to be beneficial for eMMC4.5 cards and harmless for non eMMC4.5 cards. I don't see a point to hold it back while it can be enabled or disabled by a flag and most of the code it adds is g

RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-07-09 Thread merez
Hi Chris, Can we push this change to mmc-next? Thanks, Maya On Mon, July 9, 2012 10:40 pm, me...@codeaurora.org wrote: > > On Mon, July 9, 2012 3:13 am, Seungwon Jeon wrote: >> Monday, July 09, 2012, Maya wrote: >>> On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote: >>> > Sunday, July 08, 2012,

RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-07-09 Thread merez
On Mon, July 9, 2012 3:13 am, Seungwon Jeon wrote: > Monday, July 09, 2012, Maya wrote: >> On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote: >> > Sunday, July 08, 2012, Maya wrote: >> >> One minor comment below: >> >> >> >> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct >> mmc_q

RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-07-09 Thread Seungwon Jeon
Monday, July 09, 2012, Maya wrote: > On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote: > > Sunday, July 08, 2012, Maya wrote: > >> One minor comment below: > >> > >> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue > >> *mq, struct request *rqc) > >> >

RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-07-09 Thread merez
On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote: > Sunday, July 08, 2012, Maya wrote: >> One minor comment below: >> >> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue >> *mq, struct request *rqc) >> >(card->ext_csd.data_sector_size == 4096)) { >

RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-07-08 Thread Seungwon Jeon
Sunday, July 08, 2012, Maya wrote: > One minor comment below: > > > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue > *mq, struct request *rqc) > > (card->ext_csd.data_sector_size == 4096)) { > You can use mmc_large_sec here (instead of card->ext_csd

Re: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-07-08 Thread merez
One minor comment below: > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc) > (card->ext_csd.data_sector_size == 4096)) { You can use mmc_large_sec here (instead of card->ext_csd.data_sector_size == 4096) Thanks, Maya --

[PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

2012-06-28 Thread Seungwon Jeon
This patch supports packed write command of eMMC4.5 device. Several writes can be grouped in packed command and all data of the individual commands can be sent in a single transfer on the bus. Signed-off-by: Seungwon Jeon Reviewed-by: Maya Erez Reviewed-by: Namjae Jeon --- drivers/mmc/card/blo