Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-12 Thread Adrian Hunter
On 12/07/12 08:02, Jaehoon Chung wrote: Hi, Adrian, On 06/14/2012 10:46 PM, Adrian Hunter wrote: On 08/06/12 07:39, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-12 Thread Jaehoon Chung
Thanks for comment. I will test and send the patch within this week. Best Regards, Jaehoon Chung On 07/12/2012 03:00 PM, Adrian Hunter wrote: On 12/07/12 08:02, Jaehoon Chung wrote: Hi, Adrian, On 06/14/2012 10:46 PM, Adrian Hunter wrote: On 08/06/12 07:39, Jaehoon Chung wrote: Enable

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-11 Thread Jaehoon Chung
Hi, Adrian, On 06/14/2012 10:46 PM, Adrian Hunter wrote: On 08/06/12 07:39, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-08 Thread merez
On Fri, July 6, 2012 9:47 am, Chris Ball wrote: Hi, On Fri, Jun 08 2012, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-08 Thread Jaehoon Chung
Hi, On 07/08/2012 07:13 PM, me...@codeaurora.org wrote: On Fri, July 6, 2012 9:47 am, Chris Ball wrote: Hi, On Fri, Jun 08 2012, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-08 Thread Chris Ball
Hi, On Sun, Jul 08 2012, Jaehoon Chung wrote: I think MMC_CAP2_BKOPS should be removed. If the card BKOPs were already enabled, the host must support BKOPs. Therefore, in mmc_start_bkops we should check only if card-ext_csd.bkops_en is set. If bkops bit is set, it means that use the bkops by

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-08 Thread Jaehoon Chung
On 07/09/2012 11:48 AM, Chris Ball wrote: Hi, On Sun, Jul 08 2012, Jaehoon Chung wrote: I think MMC_CAP2_BKOPS should be removed. If the card BKOPs were already enabled, the host must support BKOPs. Therefore, in mmc_start_bkops we should check only if card-ext_csd.bkops_en is set. If

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-08 Thread Chris Ball
Hi, On Mon, Jul 09 2012, Jaehoon Chung wrote: On 07/09/2012 11:48 AM, Chris Ball wrote: Hi, On Sun, Jul 08 2012, Jaehoon Chung wrote: I think MMC_CAP2_BKOPS should be removed. If the card BKOPs were already enabled, the host must support BKOPs. Therefore, in mmc_start_bkops we should

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-07-06 Thread Chris Ball
Hi, On Fri, Jun 08 2012, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first

RE: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-15 Thread Subhash Jadavani
; Konstantin Dorfman; Adrian Hunter; Maya Erez; Ulf Hansson Subject: Re: [PATCH v9] mmc: support BKOPS feature for eMMC Hi Subhash, On 06/13/2012 09:45 PM, Subhash Jadavani wrote: Hi Jaehoon, Find few comments inline below. Also, periodic BKOPs support was present in v8 but now you have

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-14 Thread Adrian Hunter
On 08/06/12 07:39, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue

RE: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-14 Thread Konstantin Dorfman
Hello Dong, On Wed, June 13, 2012 3:40 pm, Dong, Chuanxiao wrote: Hi Jaehoon, diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 0b6141d..9adb004 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -41,6 +41,12 @@ #include sd_ops.h #include

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-14 Thread Konstantin Dorfman
Hello Adrian, On Thu, June 14, 2012 4:46 pm, Adrian Hunter wrote: On 08/06/12 07:39, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required.

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-14 Thread Jaehoon Chung
Hi, Dong, On 06/13/2012 09:40 PM, Dong, Chuanxiao wrote: Hi Jaehoon, diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 0b6141d..9adb004 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -41,6 +41,12 @@ #include sd_ops.h #include sdio_ops.h +/*

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-14 Thread Jaehoon Chung
Hi Subhash, On 06/13/2012 09:45 PM, Subhash Jadavani wrote: Hi Jaehoon, Find few comments inline below. Also, periodic BKOPs support was present in v8 but now you have removed it in v9. Is there any reason for it? Yes, there is the periodic bkops in v-8. But, i have discussed this with

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-14 Thread Jaehoon Chung
On 06/13/2012 10:53 PM, S, Venkatraman wrote: On Fri, Jun 8, 2012 at 10:09 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-13 Thread merez
On Tue, June 12, 2012 8:07 pm, Jaehoon Chung wrote: On 06/12/2012 07:58 PM, me...@codeaurora.org wrote: @@ -359,12 +443,15 @@ struct mmc_async_req *mmc_start_req(struct mmc_host *host, if (!err areq) start_err = __mmc_start_req(host, areq-mrq); - if (host-areq) + if

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-12 Thread merez
@@ -359,12 +443,15 @@ struct mmc_async_req *mmc_start_req(struct mmc_host *host, if (!err areq) start_err = __mmc_start_req(host, areq-mrq); - if (host-areq) + if (host-areq) { + if (!areq host-areq mmc_card_mmc(host-card)) +

Re: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-12 Thread Jaehoon Chung
On 06/12/2012 07:58 PM, me...@codeaurora.org wrote: @@ -359,12 +443,15 @@ struct mmc_async_req *mmc_start_req(struct mmc_host *host, if (!err areq) start_err = __mmc_start_req(host, areq-mrq); -if (host-areq) +if (host-areq) { +if (!areq host-areq

[PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-07 Thread Jaehoon Chung
Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then