Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-26 Thread Pavel Machek
On Fri 2013-05-24 20:58:34, Arnd Bergmann wrote: > On Friday 24 May 2013, Dinh Nguyen wrote: > > I apologize for that. Will make sure to include a [PATCH 0/6] message in > > the future. > > No worries, I actually saw now that my only other comment was also > wrong, as you have the binding I was lo

Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-24 Thread Arnd Bergmann
On Friday 24 May 2013, Dinh Nguyen wrote: > I apologize for that. Will make sure to include a [PATCH 0/6] message in > the future. No worries, I actually saw now that my only other comment was also wrong, as you have the binding I was looking for in patch 5/6. Arnd -- To unsubscribe from

Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-24 Thread Dinh Nguyen
Hi Arnd, On Fri, 2013-05-24 at 19:12 +0200, Arnd Bergmann wrote: > On Friday 24 May 2013, Arnd Bergmann wrote: > > > It also seems odd to have this in the series for the ethernet driver. > > After I sent it I realized that your patches are actually for different > parts of the system, they were

Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-24 Thread Arnd Bergmann
On Friday 24 May 2013, Arnd Bergmann wrote: > It also seems odd to have this in the series for the ethernet driver. After I sent it I realized that your patches are actually for different parts of the system, they were just all replies to the same first patch. It's usually helpful to add a [PATC

Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-24 Thread Arnd Bergmann
On Friday 24 May 2013, dingu...@altera.com wrote: > > From: Dinh Nguyen > > Add platform specific functionality for the DW SD/MMC driver for > SoCFPGA. Move SDMMC_CMD_USE_HOLD_REG to dw_mmc.h so other platforms > can use this define. No objections to the patch, but you seem to be missing a bin

[PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-24 Thread dinguyen
From: Dinh Nguyen Add platform specific functionality for the DW SD/MMC driver for SoCFPGA. Move SDMMC_CMD_USE_HOLD_REG to dw_mmc.h so other platforms can use this define. Signed-off-by: Dinh Nguyen CC: Seungwon Jeon CC: Jaehoon Chung CC: Arnd Bergmann CC: Olof Johansson CC: Pavel Machek C