Re: [Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-23 Thread Ulf Hansson
Chris Ball wrote: Hi Ulf, On Tue, Nov 22 2011, Ulf Hansson wrote: Thanks for the quick reply! I understand the idea better now. Just a minor follow-up question.. The power_restore function for sdio also uses this flag, which is a little bit strange I think. Yeah, it's being used to detect wh

Re: [Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-22 Thread Chris Ball
Hi Ulf, On Tue, Nov 22 2011, Ulf Hansson wrote: > Thanks for the quick reply! I understand the idea better now. Just a > minor follow-up question.. > > The power_restore function for sdio also uses this flag, which is a > little bit strange I think. Yeah, it's being used to detect whether we're i

Re: [Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-22 Thread Ulf Hansson
Hi Chris, Thanks for the quick reply! I understand the idea better now. Just a minor follow-up question.. The power_restore function for sdio also uses this flag, which is a little bit strange I think. Especially since the mmc_power_off|up is always called no matter of the value of this flag

Re: [Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-22 Thread Chris Ball
Hi, On Tue, Nov 22 2011, Ulf Hansson wrote: > Hi, > > In mmc_resume_host we clear the MMC_PM_KEEP_POWER flag from the > pm_flags bitfield. This is done by a patch from Eliad Peller a while > ago, "mmc: clear MMC_PM_KEEP_POWER flag on resume" > > I would like to understand if there are any reason t

Re: [Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-22 Thread Nicolas Pitre
On Tue, 22 Nov 2011, Eliad Peller wrote: > hi Ulf, > > On Tue, Nov 22, 2011 at 3:29 PM, Ulf Hansson > wrote: > > In mmc_resume_host we clear the MMC_PM_KEEP_POWER flag from the pm_flags > > bitfield. This is done by a patch from Eliad Peller a while ago, "mmc: clear > > MMC_PM_KEEP_POWER flag o

Re: [Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-22 Thread Eliad Peller
hi Ulf, On Tue, Nov 22, 2011 at 3:29 PM, Ulf Hansson wrote: > In mmc_resume_host we clear the MMC_PM_KEEP_POWER flag from the pm_flags > bitfield. This is done by a patch from Eliad Peller a while ago, "mmc: clear > MMC_PM_KEEP_POWER flag on resume" > > I would like to understand if there are any

[Query] mmc: core "MMC_PM_KEEP_POWER"

2011-11-22 Thread Ulf Hansson
Hi, In mmc_resume_host we clear the MMC_PM_KEEP_POWER flag from the pm_flags bitfield. This is done by a patch from Eliad Peller a while ago, "mmc: clear MMC_PM_KEEP_POWER flag on resume" I would like to understand if there are any reason to why we want to clear this flag after we done a res