Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-10-10 Thread Zoran Markovic
I like the simplified approach taken in this patch. Shortening the awake time by trying to call __pm_relax() in all corner cases turned out to be too complex. Reviewed-by: Zoran Markovic zoran.marko...@linaro.org Regards, Zoran On 1 October 2013 02:22, Ulf Hansson ulf.hans...@linaro.org wrote:

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-10-01 Thread Ulf Hansson
Hi John, So how does the notification done to userspace? I wonder if you could use the select/lock/read style method for releasing the kernel space wakeup_source, as is done in the input layer? If I understand what you mean correctly, it is very similar what Zoran tried to do before in his

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-24 Thread Ulf Hansson
Hi Zoran, On 23 September 2013 23:14, Zoran Markovic zoran.marko...@linaro.org wrote: Hi Ulf, I like the fact that wakeups are now quite simplified. A couple of comments below: By signaling the wakeup event for a time of 5 s for devices configured as wakeup capable, we likely will be

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-24 Thread Ulf Hansson
On 20 September 2013 11:48, Ulf Hansson ulf.hans...@linaro.org wrote: We want to give user space provision to fully consume a card insert/remove event, when the event was caused by a wakeup irq. By signaling the wakeup event for a time of 5 s for devices configured as wakeup capable, we

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-24 Thread John Stultz
On 09/24/2013 12:55 AM, Ulf Hansson wrote: Hi Zoran, On 23 September 2013 23:14, Zoran Markovic zoran.marko...@linaro.org wrote: Hi Ulf, I like the fact that wakeups are now quite simplified. A couple of comments below: By signaling the wakeup event for a time of 5 s for devices configured

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-23 Thread Jaehoon Chung
On 09/23/2013 09:11 PM, Ulf Hansson wrote: On 23 September 2013 12:55, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Ulf, On 09/20/2013 06:48 PM, Ulf Hansson wrote: We want to give user space provision to fully consume a card insert/remove event, when the event was caused by a wakeup irq.

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-23 Thread Zoran Markovic
Hi Ulf, I like the fact that wakeups are now quite simplified. A couple of comments below: By signaling the wakeup event for a time of 5 s for devices configured as wakeup capable, we likely will be prevent a sleep long enough to let user space consume the event. Given that there is no

[RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-20 Thread Ulf Hansson
We want to give user space provision to fully consume a card insert/remove event, when the event was caused by a wakeup irq. By signaling the wakeup event for a time of 5 s for devices configured as wakeup capable, we likely will be prevent a sleep long enough to let user space consume the event.