Re: [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()

2010-06-03 Thread Michał Mirosław
On Thu, Jun 03, 2010 at 01:21:23PM -0400, Chris Ball wrote: >> That is a bit vague. An SD card is a memory. An SDIO "card" is >> an I/O connection made using the same physical interface as an SD >> card and a very similar protocal to SD cards (at least with >> respect to reading a

Re: [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()

2010-06-03 Thread Chris Ball
Hi, > That is a bit vague. An SD card is a memory. An SDIO "card" is > an I/O connection made using the same physical interface as an SD > card and a very similar protocal to SD cards (at least with > respect to reading and writing). I do not understand how a card > can be SD and

Re: [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()

2010-06-03 Thread Adrian Hunter
Michał Mirosław wrote: Thanks for your review! On Fri, May 28, 2010 at 02:40:27PM -0700, Andrew Morton wrote: On Tue, 25 May 2010 18:10:28 +0200 (CEST) Micha__ Miros__aw wrote: This is needed to avoid code duplication in SD-combo support. hm. Perhaps you could have told us a bit more about

Re: [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()

2010-05-31 Thread Michał Mirosław
Thanks for your review! On Fri, May 28, 2010 at 02:40:27PM -0700, Andrew Morton wrote: > On Tue, 25 May 2010 18:10:28 +0200 (CEST) > Micha__ Miros__aw wrote: > > This is needed to avoid code duplication in SD-combo support. > hm. Perhaps you could have told us a bit more about it than this. > >

Re: [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()

2010-05-28 Thread Andrew Morton
On Tue, 25 May 2010 18:10:28 +0200 (CEST) Micha__ Miros__aw wrote: > This is needed to avoid code duplication in SD-combo support. hm. Perhaps you could have told us a bit more about it than this. > +int mmc_sd_get_cid(struct mmc_host *host, u32 ocr, u32 *cid) > +int mmc_sd_get_csd(struct mmc_

[RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()

2010-05-25 Thread Michał Mirosław
This is needed to avoid code duplication in SD-combo support. --- drivers/mmc/core/sd.c | 256 drivers/mmc/core/sd.h | 17 2 files changed, 166 insertions(+), 107 deletions(-) create mode 100644 drivers/mmc/core/sd.h diff --git a/drivers/m