Re: [RFC] sdhci: 8 bit bus width changes

2010-11-24 Thread Chris Ball
Hi Philip, On Sun, Nov 21, 2010 at 11:17:09AM -0800, Philip Rakity wrote: > a) QUIRK removed for 8 bit support since platform issue - not quirk > b) platform Flag defined for sdhci-pxa.c and plat-pxa > c) comments added to sdhci.c on usage Thanks very much, I'll plan on sending this to Linus tomo

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-22 Thread zhangfei gao
On Mon, Nov 22, 2010 at 11:13 AM, Philip Rakity wrote: > > On Nov 22, 2010, at 2:36 AM, zhangfei gao wrote: > >> On Mon, Nov 22, 2010 at 3:17 AM, Philip Rakity wrote: >>> From d52213a33a71142134555793583b726501827827 Mon Sep 17 00:00:00 2001 >>> From: Philip Rakity >>> Date: Sun, 21 Nov 2010 11:

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-22 Thread Philip Rakity
On Nov 22, 2010, at 2:36 AM, zhangfei gao wrote: > On Mon, Nov 22, 2010 at 3:17 AM, Philip Rakity wrote: >> From d52213a33a71142134555793583b726501827827 Mon Sep 17 00:00:00 2001 >> From: Philip Rakity >> Date: Sun, 21 Nov 2010 11:08:21 -0800 >> Subject: [PATCH] [PATCH] sdhci: resubmit 8 bit su

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-22 Thread zhangfei gao
On Mon, Nov 22, 2010 at 3:17 AM, Philip Rakity wrote: > From d52213a33a71142134555793583b726501827827 Mon Sep 17 00:00:00 2001 > From: Philip Rakity > Date: Sun, 21 Nov 2010 11:08:21 -0800 > Subject: [PATCH] [PATCH] sdhci: resubmit 8 bit support based on feedback from > list > > a) QUIRK removed

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-22 Thread zhangfei gao
On Mon, Nov 22, 2010 at 3:17 AM, Philip Rakity wrote: > From d52213a33a71142134555793583b726501827827 Mon Sep 17 00:00:00 2001 > From: Philip Rakity > Date: Sun, 21 Nov 2010 11:08:21 -0800 > Subject: [PATCH] [PATCH] sdhci: resubmit 8 bit support based on feedback from > list > > a) QUIRK removed

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-21 Thread Philip Rakity
>From d52213a33a71142134555793583b726501827827 Mon Sep 17 00:00:00 2001 From: Philip Rakity Date: Sun, 21 Nov 2010 11:08:21 -0800 Subject: [PATCH] [PATCH] sdhci: resubmit 8 bit support based on feedback from list a) QUIRK removed for 8 bit support since platform issue - not quirk b) platform Fla

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-20 Thread Chris Ball
Hi, On Sat, Nov 20, 2010 at 01:35:53PM +0100, Wolfram Sang wrote: > I know it's too late, but... It's late, but it's not too late. I'd like to send a fix for MMC cards to Linus within the next week. If we decide to make some small changes here and can do it quickly, that should be fine. > What

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-20 Thread Philip Rakity
code is fine. On Nov 19, 2010, at 1:53 PM, Chris Ball wrote: > On Fri, Nov 19, 2010 at 09:40:02PM +, Chris Ball wrote: >> I don't see why we should re-read ctrl here, since we've already written >> it back to the device at this point, and we don't use it anywhere below >> this line. > > Ah,

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-20 Thread Philip Rakity
On Nov 20, 2010, at 4:35 AM, Wolfram Sang wrote: > I know it's too late, but... > > On Fri, Nov 19, 2010 at 09:53:33PM +, Chris Ball wrote: >> On Fri, Nov 19, 2010 at 09:40:02PM +, Chris Ball wrote: >>> I don't see why we should re-read ctrl here, since we've already written >>> it back

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-20 Thread Wolfram Sang
I know it's too late, but... On Fri, Nov 19, 2010 at 09:53:33PM +, Chris Ball wrote: > On Fri, Nov 19, 2010 at 09:40:02PM +, Chris Ball wrote: > > I don't see why we should re-read ctrl here, since we've already written > > it back to the device at this point, and we don't use it anywhere

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-19 Thread Chris Ball
On Fri, Nov 19, 2010 at 09:40:02PM +, Chris Ball wrote: > I don't see why we should re-read ctrl here, since we've already written > it back to the device at this point, and we don't use it anywhere below > this line. Ah, I see why now; please ignore this. Here's a rebased version of the pat

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-19 Thread Chris Ball
Hi Philip, I'd like to take this patch. One comment, though: On Fri, Oct 01, 2010 at 03:45:50PM -0700, Philip Rakity wrote: > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 73a94fe..ec103c3 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-05 Thread Peppe CAVALLARO
Hello Philip, On 10/2/2010 12:45 AM, Philip Rakity wrote: > > From 80c581d354df180a4c2d6aa50c21788e6c7593b9 Mon Sep 17 00:00:00 2001 > From: Philip Rakity > Date: Fri, 1 Oct 2010 13:42:58 -0700 > Subject: [RFC] sdhci: 8 bit bus width changes > > Check for v3 controller co

[RFC] sdhci: 8 bit bus width changes

2010-10-01 Thread Philip Rakity
>From 80c581d354df180a4c2d6aa50c21788e6c7593b9 Mon Sep 17 00:00:00 2001 From: Philip Rakity Date: Fri, 1 Oct 2010 13:42:58 -0700 Subject: [RFC] sdhci: 8 bit bus width changes Check for v3 controller controller when doing 8 bit bus width add support for adaption layer to set 8 bit wi