Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-07-01 Thread Arend van Spriel
On 01-07-14 18:42, Ulf Hansson wrote: > On 20 June 2014 10:14, Hans de Goede wrote: >> Hi, >> >> On 06/20/2014 10:02 AM, Olof Johansson wrote: >>> On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede wrote: Hi, On 06/19/2014 07:18 PM, Olof Johansson wrote: > Hi, > > > >>

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-07-01 Thread Ulf Hansson
On 20 June 2014 17:42, Arnd Bergmann wrote: > On Thursday 19 June 2014 15:04:50 Ulf Hansson wrote: >> +Power sequence DT bindings >> + >> +Each power sequence method has a corresponding "power-method" property >> string. >> +This property shall be set in a subnode for a device. That subnode shoul

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-07-01 Thread Arnd Bergmann
On Tuesday 01 July 2014 18:42:51 Ulf Hansson wrote: > On 20 June 2014 10:14, Hans de Goede wrote: > > On 06/20/2014 10:02 AM, Olof Johansson wrote: > >> On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede > >> wrote: > >> I disagree. > >> > >> The clock is the input to the module, and it is what nee

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-07-01 Thread Ulf Hansson
On 20 June 2014 10:14, Hans de Goede wrote: > Hi, > > On 06/20/2014 10:02 AM, Olof Johansson wrote: >> On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede wrote: >>> Hi, >>> >>> On 06/19/2014 07:18 PM, Olof Johansson wrote: Hi, On Thu, Jun 19, 2014 at 6:04 AM, Ulf Hansson >

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-07-01 Thread Ulf Hansson
On 19 June 2014 16:23, Hans de Goede wrote: > Hi, > > On 06/19/2014 04:03 PM, Hans de Goede wrote: >> Hi, >> > > > >> Also I'm not sold on how you're making this a devm only thing, and >> are using devres_alloc to not only allocate memory for resource tracking, >> but also the actual backing stru

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-20 Thread Arnd Bergmann
On Thursday 19 June 2014 15:04:50 Ulf Hansson wrote: > +Power sequence DT bindings > + > +Each power sequence method has a corresponding "power-method" property > string. > +This property shall be set in a subnode for a device. That subnode should > also > +describe resourses which are specific t

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-20 Thread Hans de Goede
Hi, On 06/20/2014 10:02 AM, Olof Johansson wrote: > On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede wrote: >> Hi, >> >> On 06/19/2014 07:18 PM, Olof Johansson wrote: >>> Hi, >>> >>> >>> >>> On Thu, Jun 19, 2014 at 6:04 AM, Ulf Hansson wrote: The pwrseq subsystem handles complex power sequen

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-20 Thread Olof Johansson
On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede wrote: > Hi, > > On 06/19/2014 07:18 PM, Olof Johansson wrote: >> Hi, >> >> >> >> On Thu, Jun 19, 2014 at 6:04 AM, Ulf Hansson wrote: >>> The pwrseq subsystem handles complex power sequences, typically useful >>> for subsystems that makes use of dis

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-20 Thread Hans de Goede
Hi, On 06/19/2014 07:18 PM, Olof Johansson wrote: > Hi, > > > > On Thu, Jun 19, 2014 at 6:04 AM, Ulf Hansson wrote: >> The pwrseq subsystem handles complex power sequences, typically useful >> for subsystems that makes use of discoverable buses, like for example >> MMC and I2C. >> >> The pwrse

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-19 Thread Olof Johansson
Hi, On Thu, Jun 19, 2014 at 6:04 AM, Ulf Hansson wrote: > The pwrseq subsystem handles complex power sequences, typically useful > for subsystems that makes use of discoverable buses, like for example > MMC and I2C. > > The pwrseq subsystem is dependant on CONFIG_OF to be able to parse a DT > c

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-19 Thread Hans de Goede
Hi, On 06/19/2014 04:03 PM, Hans de Goede wrote: > Hi, > > Also I'm not sold on how you're making this a devm only thing, and > are using devres_alloc to not only allocate memory for resource tracking, > but also the actual backing struct, that is not how devres_alloc is > intended to be used

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-19 Thread Hans de Goede
Hi, Overall I like the idea, I've some comments on the implementation inline. On 06/19/2014 03:04 PM, Ulf Hansson wrote: > The pwrseq subsystem handles complex power sequences, typically useful > for subsystems that makes use of discoverable buses, like for example > MMC and I2C. I2C is not disc

[RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-19 Thread Ulf Hansson
The pwrseq subsystem handles complex power sequences, typically useful for subsystems that makes use of discoverable buses, like for example MMC and I2C. The pwrseq subsystem is dependant on CONFIG_OF to be able to parse a DT childnode to find out what power sequence method to bind for a device.