Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-10 Thread Jon Hunter
Hi Ulf, On 09/09/15 13:42, Ulf Hansson wrote: [snip] >> +static int mmc_blk_ioctl_cmd(struct block_device *bdev, >> + struct mmc_ioc_cmd __user *ic_ptr) >> +{ >> + struct mmc_blk_ioc_data *idata; >> + struct mmc_blk_data *md; >> + struct mmc_card *card;

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-10 Thread Ulf Hansson
On 10 September 2015 at 10:43, Jon Hunter wrote: > Hi Ulf, > > On 09/09/15 13:42, Ulf Hansson wrote: > > [snip] > >>> +static int mmc_blk_ioctl_cmd(struct block_device *bdev, >>> + struct mmc_ioc_cmd __user *ic_ptr) >>> +{ >>> + struct

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-09 Thread Ulf Hansson
On 3 September 2015 at 17:08, Jon Hunter wrote: > Hi Olof, > > On 02/09/15 19:28, Olof Johansson wrote: >> Hi, >> >> On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: >>> From: Seshagiri Holi >>> >>> Certain eMMC devices allow vendor

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-09 Thread Jon Hunter
Hi Ulf, On 09/09/15 13:42, Ulf Hansson wrote: > On 3 September 2015 at 17:08, Jon Hunter wrote: >> Hi Olof, >> >> On 02/09/15 19:28, Olof Johansson wrote: >>> Hi, >>> >>> On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: From: Seshagiri Holi

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-08 Thread Jon Hunter
On 04/09/15 02:14, Grant Grundler wrote: > On Thu, Sep 3, 2015 at 8:10 AM, Jon Hunter wrote: > >> >> On 02/09/15 23:08, Grant Grundler wrote: >>> [resending text-only] >>> >>> On Wed, Sep 2, 2015 at 3:07 PM, Grant Grundler >> wrote: On

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-03 Thread Jon Hunter
On 02/09/15 23:08, Grant Grundler wrote: > [resending text-only] > > On Wed, Sep 2, 2015 at 3:07 PM, Grant Grundler wrote: >> >> >> On Wed, Sep 2, 2015 at 11:28 AM, Olof Johansson wrote: >> ... +/** + * struct mmc_ioc_combo_cmd - combo command

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-03 Thread Jon Hunter
Hi Olof, On 02/09/15 19:28, Olof Johansson wrote: > Hi, > > On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: >> From: Seshagiri Holi >> >> Certain eMMC devices allow vendor specific device information to be read >> via a sequence of vendor commands.

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-03 Thread Grant Grundler
[resending...keep forgetting to switch back to text-only in gmail] On Thu, Sep 3, 2015 at 8:10 AM, Jon Hunter wrote: ... >>> If alignment matters, then maybe swap the fields? >>> Or declare num_of_cmds as u64 as well? > > Thanks. I did swap them in the updated version as

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-02 Thread Olof Johansson
Hi, On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: > From: Seshagiri Holi > > Certain eMMC devices allow vendor specific device information to be read > via a sequence of vendor commands. These vendor commands must be issued > in sequence and an atomic

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-02 Thread Grant Grundler
[resending text-only] On Wed, Sep 2, 2015 at 3:07 PM, Grant Grundler wrote: > > > On Wed, Sep 2, 2015 at 11:28 AM, Olof Johansson wrote: > ... >> > +/** >> > + * struct mmc_ioc_combo_cmd - combo command information >> > + * @num_of_cmds: number of commands

[RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-02 Thread Jon Hunter
From: Seshagiri Holi Certain eMMC devices allow vendor specific device information to be read via a sequence of vendor commands. These vendor commands must be issued in sequence and an atomic fashion. One way to support this would be to add an ioctl function for sending a