Re: [RFC PATCH v3 0/3] Add MMC host driver for Spreadtrum SoC

2015-09-10 Thread Ulf Hansson
Hi Hongtao, On 14 August 2015 at 18:55, Hongtao Wu wrote: > This patch adds MMC host driver for Spreadtrum SoC. > The following coding style may be not meet kernel coding style. I don't think you have any reason to why you shouldn't follow the kernel coding style. Please change! > I am not sure

[RFC PATCH v3 0/3] Add MMC host driver for Spreadtrum SoC

2015-08-14 Thread Hongtao Wu
This patch adds MMC host driver for Spreadtrum SoC. The following coding style may be not meet kernel coding style. I am not sure this kind of coding style is better or worse. 1) A macro that represent some bits of a register is added a prefix "__", for example: #define SDHOST_16_HOST_CTRL_