Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()

2015-12-01 Thread Vinod Koul
On Tue, Dec 01, 2015 at 02:58:35PM +0200, Andy Shevchenko wrote: > On Tue, Dec 1, 2015 at 11:47 AM, Peter Ujfalusi wrote: > > On 11/30/2015 04:35 PM, Andy Shevchenko wrote: > >> On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi > >> wrote: > >>> Treat

Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()

2015-12-01 Thread Peter Ujfalusi
On 11/30/2015 04:35 PM, Andy Shevchenko wrote: > On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi wrote: >> Treat as true condition the case when the mask is NULL. > > What do you think about setting some default (all "on") mask when mask > is not supplied? Probably

Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()

2015-12-01 Thread Andy Shevchenko
On Tue, Dec 1, 2015 at 11:47 AM, Peter Ujfalusi wrote: > On 11/30/2015 04:35 PM, Andy Shevchenko wrote: >> On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi >> wrote: >>> Treat as true condition the case when the mask is NULL. >> >> What do you think

[RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()

2015-11-30 Thread Peter Ujfalusi
Treat as true condition the case when the mask is NULL. Signed-off-by: Peter Ujfalusi --- drivers/dma/dmaengine.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index daf54a39bcc7..52c3eee48e2e 100644 ---

Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()

2015-11-30 Thread Andy Shevchenko
On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi wrote: > Treat as true condition the case when the mask is NULL. What do you think about setting some default (all "on") mask when mask is not supplied? I don't know for sure but there might be cases when you don't want