RE: [patch 077/232] sdio: fix read buffer overflow

2009-10-06 Thread Bing Zhao
@linux-foundation.org; > roel.kl...@gmail.com; libertas- > d...@lists.infradead.org > Subject: Re: [patch 077/232] sdio: fix read buffer overflow > > David Vrabel wrote: > > David Vrabel wrote: > >> It's harmless if the tuple contains fewer so I think we should just tr

Re: [patch 077/232] sdio: fix read buffer overflow

2009-10-01 Thread Jonathan Cameron
David Vrabel wrote: > David Vrabel wrote: >> It's harmless if the tuple contains fewer so I think we should just try >> and parse as many strings as possible. Does this patch fix your regression? > > I spelt the field name wrong in the comment. Use this patch instead, > please. Works for me, so

Re: [patch 077/232] sdio: fix read buffer overflow

2009-10-01 Thread David Vrabel
David Vrabel wrote: > > It's harmless if the tuple contains fewer so I think we should just try > and parse as many strings as possible. Does this patch fix your regression? I spelt the field name wrong in the comment. Use this patch instead, please. David -- David Vrabel, Senior Software Eng

Re: [patch 077/232] sdio: fix read buffer overflow

2009-10-01 Thread David Vrabel
Jonathan Cameron wrote: > Hi All, > > This patch is causing a regression with libertas 8686. > It's only finding 3 strings which I'm guessing means > it is an invalid CISTPL_VERS_1. Unfortunately the libertas_sdio > code relies on a string in one of them to tell it what model of > card we have. >

Re: [patch 077/232] sdio: fix read buffer overflow

2009-10-01 Thread Jonathan Cameron
Hi All, This patch is causing a regression with libertas 8686. It's only finding 3 strings which I'm guessing means it is an invalid CISTPL_VERS_1. Unfortunately the libertas_sdio code relies on a string in one of them to tell it what model of card we have. Can someone confirm what the CIS_VERS_1

[patch 077/232] sdio: fix read buffer overflow

2009-09-22 Thread akpm
From: Roel Kluin Avoid buffer underrun when parsing an invalid CISTPL_VERS_1. Signed-off-by: Roel Kluin Cc: David Vrabel Cc: Signed-off-by: Andrew Morton --- drivers/mmc/core/sdio_cis.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/mmc/core/sdio_cis.c~sdio-fix