Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-15 Thread zhangfei gao
2010/8/13 Michał Mirosław : > 2010/8/12 zhangfei gao : > [...] >> updated patch: >> From b17eb3ca9dd23af63ada240e8f77bdd873e853a7 Mon Sep 17 00:00:00 2001 >> From: Zhangfei Gao >> Date: Fri, 6 Aug 2010 07:10:01 +0800 >> Subject: [PATCH] sdhc: support 10-bit divided clock Mode >> >> Signed-off-by:

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-13 Thread Michał Mirosław
2010/8/12 zhangfei gao : [...] > updated patch: > From b17eb3ca9dd23af63ada240e8f77bdd873e853a7 Mon Sep 17 00:00:00 2001 > From: Zhangfei Gao > Date: Fri, 6 Aug 2010 07:10:01 +0800 > Subject: [PATCH] sdhc: support 10-bit divided clock Mode > > Signed-off-by: Zhangfei Gao > Reviewed-by: Matt Flemi

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-11 Thread zhangfei gao
On Wed, Aug 11, 2010 at 3:44 AM, zhangfei gao wrote: > On Wed, Aug 11, 2010 at 12:32 AM, Matt Fleming wrote: >> On Mon, Aug 09, 2010 at 08:33:16PM +0800, zhangfei gao wrote: >>> >>> Thanks for your careful review, in our platform, we use max/min for >>> the max_div, so miss this modification :( >

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-11 Thread zhangfei gao
On Wed, Aug 11, 2010 at 12:32 AM, Matt Fleming wrote: > On Mon, Aug 09, 2010 at 08:33:16PM +0800, zhangfei gao wrote: >> >> Thanks for your careful review, in our platform, we use max/min for >> the max_div, so miss this modification :( >> Update the patch, help review again. > > What do you mean?

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-10 Thread Matt Fleming
On Mon, Aug 09, 2010 at 08:33:16PM +0800, zhangfei gao wrote: > > Thanks for your careful review, in our platform, we use max/min for > the max_div, so miss this modification :( > Update the patch, help review again. What do you mean? Where does max/min come from? It would definitely be best if e

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-09 Thread zhangfei gao
On Mon, Aug 9, 2010 at 6:10 PM, Matt Fleming wrote: > On Thu, Aug 05, 2010 at 03:09:14PM +0800, zhangfei gao wrote: >> >> >> >>        1. support 8 bit data transfer width >> > 8 bit buswidth patch is already merged to mm tree. >> > >> > http://marc.info/?l=linux-mmc&m=127783663526810&w=3 >> > >>

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-09 Thread Matt Fleming
On Thu, Aug 05, 2010 at 03:09:14PM +0800, zhangfei gao wrote: > >> > >>        1. support 8 bit data transfer width > > 8 bit buswidth patch is already merged to mm tree. > > > > http://marc.info/?l=linux-mmc&m=127783663526810&w=3 > > > > Thank you, > > Kyungmin Park > > > > Thanks Kyungmin, updat

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-05 Thread zhangfei gao
>> >>        1. support 8 bit data transfer width > 8 bit buswidth patch is already merged to mm tree. > > http://marc.info/?l=linux-mmc&m=127783663526810&w=3 > > Thank you, > Kyungmin Park > Thanks Kyungmin, updated without 8 bit support. >From 2b71743acdac90c5f31522a1515a2000749a Mon Sep 17

Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-04 Thread Kyungmin Park
On Thu, Aug 5, 2010 at 3:08 PM, zhangfei gao wrote: > sdhci spec 3.0 has some difference, and here is patch to add support. > > From 25eeab5e3b58128600968e5600aeaf9390c067d8 Mon Sep 17 00:00:00 2001 > From: Zhangfei Gao > Date: Fri, 6 Aug 2010 05:47:59 +0800 > Subject: [PATCH] sdhci: aligh with s

[patch 1/1]sdhci: sdhc spec 3.0 add some modification

2010-08-04 Thread zhangfei gao
sdhci spec 3.0 has some difference, and here is patch to add support. >From 25eeab5e3b58128600968e5600aeaf9390c067d8 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao Date: Fri, 6 Aug 2010 05:47:59 +0800 Subject: [PATCH] sdhci: aligh with sdhc spec 3.00 1. support 8 bit data transfer width