Re: [v5, 2/4] mmc: sdhci-of-esdhc: support both BE and LE host controller

2015-09-29 Thread Arnd Bergmann
On Monday 28 September 2015 14:35:13 Yangbo Lu wrote: > +struct esdhc_host { > + u8 vendor_ver; > + u8 spec_ver; > + u16 xfer_mode_shadow; > + struct sdhci_host *host; > +}; > + > +static struct esdhc_host *esdhc; Please avoid global variables like this one and keep the state withi

Re: [v5, 2/4] mmc: sdhci-of-esdhc: support both BE and LE host controller

2015-09-29 Thread Ulf Hansson
On 28 September 2015 at 08:35, Yangbo Lu wrote: > To support little endian eSDHC controller, we redefine both BE and > LE IO accessors. In the new accessors, use ioread*/iowrite* instead > of in_be32/out_be32 and will select accessors according to endian > mode in probe function. > > Signed-off-by

[v5, 2/4] mmc: sdhci-of-esdhc: support both BE and LE host controller

2015-09-27 Thread Yangbo Lu
To support little endian eSDHC controller, we redefine both BE and LE IO accessors. In the new accessors, use ioread*/iowrite* instead of in_be32/out_be32 and will select accessors according to endian mode in probe function. Signed-off-by: Yangbo Lu --- drivers/mmc/host/sdhci-esdhc.h| 2 +