Re: One bug of SDHCI driver

Hi, everyone I have posted this new patch in a separate mail. Many thanks for your comments. Thanks, Zhonghui On 2014/8/7 14:58, Fu, Zhonghui wrote: kindly reminder. Thanks, Zhonghui On 2014/8/5 12:56, Fu, Zhonghui wrote: Hi, Jaehoon According to your comments, I created a new patch

Re: One bug of SDHCI driver

kindly reminder. Thanks, Zhonghui On 2014/8/5 12:56, Fu, Zhonghui wrote: Hi, Jaehoon According to your comments, I created a new patch for this issue as follows: Thanks, Zhonghui From 6cee984e1d76ba0a3320430f8cf4318ab65fcf06 Mon Sep 17 00:00:00 2001 From: Fu Zhonghui

Re: One bug of SDHCI driver

Hi, Jaehoon According to your comments, I created a new patch for this issue as follows: Thanks, Zhonghui From 6cee984e1d76ba0a3320430f8cf4318ab65fcf06 Mon Sep 17 00:00:00 2001 From: Fu Zhonghui zhonghui...@linux.intel.com Date: Tue, 5 Aug 2014 12:44:38 +0800 Subject: [PATCH] mmc: core: sdio:

Re: One bug of SDHCI driver

Hi, Zhonghui. On 07/30/2014 11:47 AM, Fu, Zhonghui wrote: Hi, In the resume function, SDIO irq must be enabled, or the interrupts from devices on SDIO bus can't be acknowledged. I also uploaded this new patch to https://bugzilla.kernel.org/show_bug.cgi?id=80151. Could you please help

Re: One bug of SDHCI driver

Hi, Any comments for this new patch? Thanks, Zhonghui On 2014/7/20 22:51, Fu, Zhonghui wrote: Hi, Chris' patch is not enough to fix this bug. I made a patch as follows and verified it can work. Could you please give out some comments about this patch? Thanks, Zhonghui From

Re: One bug of SDHCI driver

Hi, Chris' patch is not enough to fix this bug. I made a patch as follows and verified it can work. Could you please give out some comments about this patch? Thanks, Zhonghui From 72d6f5b56fa04290fd3a055ade1d89e7c8d4 Mon Sep 17 00:00:00 2001 From: Fu Zhonghui zhonghui...@linux.intel.com

Re: One bug of SDHCI driver

Hi, The data type of host is struct mmc_host, and there is not quirks member in this structure. Thanks, Zhonghui On 2014/7/14 21:26, Chris Ball wrote: Hi Zhonghui, On Tue, Jul 08 2014, Fu, Zhonghui wrote: Why add mmc-caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; ? How to fix this bug? Could

Re: One bug of SDHCI driver

On 07/15/2014 11:54 AM, Fu, Zhonghui wrote: Hi, The data type of host is struct mmc_host, and there is not quirks member in this structure. Sorry for wrong typo. You use the host-caps2 instead of host-quirks. Best Regards, Jaehoon Chung Thanks, Zhonghui On 2014/7/14 21:26, Chris

Re: One bug of SDHCI driver

From: Chris Ball ch...@printf.net Subject: [PATCH] mmc: core: sdio: Fix unconditional wake_up_process() on sdio thread 781e989cf59 (mmc: sdhci: convert to new SDIO IRQ handling) and bf3b5ec66bd (mmc: sdio_irq: rework sdio irq handling) disabled the use of our own custom threaded IRQ handler, but

Re: One bug of SDHCI driver

Hi, Why add mmc-caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; ? How to fix this bug? Could you please give out some idea about this bug? Thanks, Zhonghui On 2014/7/6 23:19, Fu, Zhonghui wrote: Yes, mmc-caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; of sdhci_add_host function in host/sdhci.c file make

Re: One bug of SDHCI driver

Yes, mmc-caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; of sdhci_add_host function in host/sdhci.c file make oops. sdio_card_irq_get function in core/sdio_irq.c file: if (!(host-caps2 MMC_CAP2_SDIO_IRQ_NOTHREAD)) { /* the condition is false */ atomic_set(host-sdio_irq_thread_abort, 0);

One bug of SDHCI driver

Hi, all The statement mmc-caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; is added in sdhci_add_host function in host/sdhci.c file. In some cases, this will make host-sdio_irq_thread a NULL pointer in mmc_sdio_resume functon of core/sdio.c file and lead to resume failure. Could you please give me some

Re: One bug of SDHCI driver

Hi, just use the MMC_CAP2_SDIO_IRQ_NOTHREAD? if (!err host-sdio_irq !(host-quirks MMC_CAP2_SDIO_IRQ_NOTHREAD)) wake_up_process(host-sdio_irq_thread); I didn't test this..but i believe that it will be fixed. Best Regards, Jaehoon Chung On 07/04/2014 12:47 AM, Fu, Zhonghui wrote: