Re: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-13 Thread Chris Ball
Hi, On Sun, Nov 13 2011, Subhash Jadavani wrote: Using SD_MODE_UHS_SDR25 macro name is not appropriate here. It's really not the SDR25 mode (although clock rate is 50mhz), it's High speed mode only. Qiang Liu patch had defined new marco SD_MODE_HIGH_SPEED which looks most appropriate to use

RE: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-13 Thread Subhash Jadavani
...@freescale.com Subject: Re: [PATCH] SD/MMC: fix the issue of SDHC performance regression Hi, On Sun, Nov 13 2011, Subhash Jadavani wrote: Using SD_MODE_UHS_SDR25 macro name is not appropriate here. It's really not the SDR25 mode (although clock rate is 50mhz), it's High speed mode only. Qiang

Re: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-08 Thread Aaron Lu
On Mon, Nov 07, 2011 at 08:20:10AM -0500, Chris Ball wrote: Have you seen: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=f2815f68dabbb373fd1c9f0fd4a609d486697c2b (mmc: sd: Handle SD3.0 cards not supporting UHS-I bus speed mode) which is already in mainline?

Re: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-08 Thread Chris Ball
Hi, On Tue, Nov 08 2011, Aaron Lu wrote: SDR25 is also 50MHZ, the same frequency as high speed. Or we can add a new macro for high speed like qiang has done, which one you prefer? The new macro makes most sense to me -- if no-one disagrees, I'll convert Liu's patch into a rename patch and

RE: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-07 Thread Li Yang-R58472
-Original Message- From: Liu Qiang-B32616 Sent: Monday, November 07, 2011 5:36 PM To: linux-mmc@vger.kernel.org Cc: c...@laptop.org; Li Yang-R58472; Gala Kumar-B11780; Liu Qiang-B32616 Subject: [PATCH] SD/MMC: fix the issue of SDHC performance regression Low performance of SDHC (half of

Re: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-07 Thread Chris Ball
Hi, On Mon, Nov 07 2011, Qiang Liu wrote: Low performance of SDHC (half of before) due to its frequency was set to 25MHz, but not 50MHz (involved by commit id 013909c4ffd16ded4895528b856fd8782df04dc6, add support for query function modes for uhs cards according to Physical Layer SPEC

RE: [PATCH] SD/MMC: fix the issue of SDHC performance regression

2011-11-07 Thread Liu Qiang-B32616
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Chris Ball Sent: Monday, November 07, 2011 9:20 PM To: Liu Qiang-B32616 Cc: linux-mmc@vger.kernel.org; Li Yang-R58472; Gala Kumar-B11780 Subject: Re: [PATCH] SD/MMC: fix