Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

2013-01-28 Thread Chris Ball
Hi, On Tue, Jan 08 2013, Konstantin Dorfman wrote: > May be it is worth to change all this struct comments to be: > > u8raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */ > > This will reference actual offset value from "include/linux/mmc/mmc.h" I think I prefer having the literal number

RE: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

2013-01-08 Thread Zhang, YiX X
-mmc@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment May be it is worth to change all this struct comments to be: u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */ This will reference actual offset value from

Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

2013-01-08 Thread Konstantin Dorfman
May be it is worth to change all this struct comments to be: u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */ This will reference actual offset value from "include/linux/mmc/mmc.h" Thanks, On 01/08/2013 08:07 AM, Zhang, YiX X wrote: From aaea3405944d844f53679b295d4082584f33d9