Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-13 Thread Chris Ball
Hi Jaehoon, On Thu, May 12 2011, Jaehoon Chung wrote: > when running mmc_rescan_try_freq(), try to init two times with last frequency. > For example, assume that host->f_min is 400KHz, we can find the below message. > > mmc1: mmc_rescan_try_freq: trying to init card at 40 Hz > mmc1: mmc_rescan

Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-13 Thread Andy Ross
On 05/12/2011 07:16 PM, Jaehoon Chung wrote: > In other words, first init card with 400KHZ, > but second/third to init with 300KHz. > i think not necessary that try to initialize the two times with 300KHz. This sounds like a correct patch to me. Presumably the board I was using had a f_min that

Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-12 Thread Jaehoon Chung
Hi Chris.. My question is others..I agreed the using frequency table.. But my questions is this... For example, if f_min is 300KHz, you can the below message. mmc1: mmc_rescan_try_freq: trying to init card at 40 Hz mmc1: mmc_rescan_try_freq: trying to init card at 30 Hz mmc1: mmc_rescan_

Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-12 Thread Chris Ball
Hi, On Thu, May 12 2011, Huang Changming-R66093 wrote: > The required min frequency (f_min) is 400KHz during identify stage, is > it necessary to use the frequency table (freqs[], including 300KHz, > 200KHz and 100KHz)? Yes. Some hardware is buggy/out of compliance with the spec. - Chris. -- C

Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-12 Thread Jaehoon Chung
This patch didn't point that.. Huang Changming-R66093 wrote: > The required min frequency (f_min) is 400KHz during identify stage, is it > necessary to use the frequency table (freqs[], including 300KHz, 200KHz and > 100KHz)? i known that some card needs lower than 400KHz..so this approach is

RE: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-12 Thread Huang Changming-R66093
The required min frequency (f_min) is 400KHz during identify stage, is it necessary to use the frequency table (freqs[], including 300KHz, 200KHz and 100KHz)? Thanks and Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vg