Hi Aaron,
On Mon, Jul 11 2011, Aaron Lu wrote:
> Currently, the retuning timer for retuning mode 1 will be deleted in
> function sdhci_tasklet_finish after a mmc request done, which will make
> retuning timing never trigger again. This patch fixed this problem.
>
> Signed-off-by: Aaron Lu
> ---
>
Reviewed-by: Philip Rakity
From: Aaron Lu [aaron...@amd.com]
Sent: Wednesday, July 27, 2011 2:15 AM
To: zhangfei gao; Philip Rakity
Cc: Nath, Arindam; Chris Ball; linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: fix retuning timer wrongly
On Fri, Jul 22, 2011 at 06:21:11PM +0800, zhangfei gao wrote:
>
> Thanks for explanation, looks good to me.
>
Hi Philip & Zhangfei,
Can I have your reviewed-by tag in the patch?
Thanks,
Aaron
> >> >> >
> >> >> > Signed-off-by: Aaron Lu
> >> >> > ---
> >> >> > drivers/mmc/host/sdhci.c | 3
On Thu, Jul 21, 2011 at 6:03 PM, Aaron Lu wrote:
> On Thu, Jul 21, 2011 at 05:35:02PM +0800, zhangfei gao wrote:
>>
>> Does the execute_tuning is called again?
>> del_timer is not delete timer really, but deactivate the timer, which
>> could be re-activated by mod_timer.
>> So if execute_tuning is
Hi Philip,
On Thu, Jul 21, 2011 at 01:27:11PM -0700, Philip Rakity wrote:
>
> Aaron,
>
> Code is fine.
Thanks.
> Do you want to also fix the problem with suspend or should I do the patch ?
> When we are suspending we should kill the tuning timer.
Yes, that is a problem.
I've another patch to a
Aaron,
Code is fine. Do you want to also fix the problem with suspend or should I do
the patch ?
When we are suspending we should kill the tuning timer.
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 4da6a4d..88c25e8 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/
On Thu, Jul 21, 2011 at 05:35:02PM +0800, zhangfei gao wrote:
>
> Does the execute_tuning is called again?
> del_timer is not delete timer really, but deactivate the timer, which
> could be re-activated by mod_timer.
> So if execute_tuning is called, the mod_timer will tigger the tuning
> timer ag
> This is a bug fix for exsting code, if the re-tuning timer is deleted,
> the re-tuning will not happen again, that will cause problems for SDHC
> 3.0 hosts which utilize re-tuning mode 1.
>
> Thanks.
>
>>
>> > -Original Message-
>> > From: Aaron Lu [mailto:aaron...@amd.com]
>> > Sent: Mon
On Fri, Jul 15, 2011 at 02:51:34PM +0800, Nath, Arindam wrote:
> Hi Philip, Zhangfei
>
> Do you have any comments on this patch?
>
Hi all,
This patch is sent for a while now and didn't seem to receive any
notice yet...So, can you please take a look and give your comments?
This is a bug fix for
Hi Philip, Zhangfei
Do you have any comments on this patch?
Thanks,
Arindam
> -Original Message-
> From: Aaron Lu [mailto:aaron...@amd.com]
> Sent: Monday, July 11, 2011 10:57 AM
> To: Chris Ball
> Cc: Nath, Arindam; linux-mmc@vger.kernel.org; Lu, Aaron
> Subject: [PATCH] mmc: sdhci: fix
10 matches
Mail list logo
