On Mon, January 13, 2014, Zhangfei Gao wrote:
Dear Seungwon
On 01/13/2014 01:32 PM, Seungwon Jeon wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios
*ios)
+{
+ struct dw_mci_k3_priv_data *priv = host-priv;
+ u32 rate = priv-clk_table[ios-timing];
Dear Seungwon
On 01/14/2014 05:38 PM, Seungwon Jeon wrote:
Looks like you dislike the clk_table very much :)
Oh, I just want to remove dependency as I mentioned.
Double checked with the silicon guy, currently it is said the limitation
in HS200 and SDR104 can be replaced by the max_rate,
Dear Seungwon
On 01/13/2014 01:32 PM, Seungwon Jeon wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+struct dw_mci_k3_priv_data *priv = host-priv;
+u32 rate = priv-clk_table[ios-timing];
The function mmc_clk_determine_rate() will need the
On Fri, January 10, 2014, Zhangfei Gao wrote:
On 01/10/2014 09:39 PM, Seungwon Jeon wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+ struct dw_mci_k3_priv_data *priv = host-priv;
+ u32 rate = priv-clk_table[ios-timing];
First, sorry for quick
On 01/13/2014 10:09 AM, Seungwon Jeon wrote:
On Fri, January 10, 2014, Zhangfei Gao wrote:
On 01/10/2014 09:39 PM, Seungwon Jeon wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+ struct dw_mci_k3_priv_data *priv = host-priv;
+ u32 rate =
On Mon, January 13, 2014, zhangfei wrote:
On 01/13/2014 10:09 AM, Seungwon Jeon wrote:
On Fri, January 10, 2014, Zhangfei Gao wrote:
On 01/10/2014 09:39 PM, Seungwon Jeon wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+struct
Hi Zhangfei,
On Thursday, January 09, 2014, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 +
On Thursday 09 January 2014, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
This looks basically, sorry for taking so long for the review.
I thought there were a
On 12/31/2013 09:20 PM, Gerhard Sittig wrote:
On Sun, Dec 29, 2013 at 22:05 +0100, Arnd Bergmann wrote:
On Saturday 28 December 2013, Zhangfei Gao wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+ struct dw_mci_k3_priv_data *priv = host-priv;
+
On Sun, Dec 29, 2013 at 22:05 +0100, Arnd Bergmann wrote:
On Saturday 28 December 2013, Zhangfei Gao wrote:
+static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+ struct dw_mci_k3_priv_data *priv = host-priv;
+ u32 rate = priv-clk_table[ios-timing];
+
On 12/30/2013 10:32 AM, Zhangfei Gao wrote:
On Mon, Dec 30, 2013 at 7:55 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
On 12/30/2013 06:05 AM, Arnd Bergmann wrote:
On Saturday 28 December 2013, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao
On Monday 30 December 2013, zhangfei wrote:
+static int dw_mci_k3_suspend(struct device *dev)
+{
+struct dw_mci *host = dev_get_drvdata(dev);
+int ret = 0;
+
+ret = dw_mci_suspend(host);
You should never initialize local variables when they are set later in the
Dear Arnd,
On 12/31/2013 04:27 AM, Arnd Bergmann wrote:
On Monday 30 December 2013, zhangfei wrote:
+static int dw_mci_k3_suspend(struct device *dev)
+{
+struct dw_mci *host = dev_get_drvdata(dev);
+int ret = 0;
+
+ret = dw_mci_suspend(host);
You should never initialize local
On Saturday 28 December 2013, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 ++
On 12/30/2013 06:05 AM, Arnd Bergmann wrote:
On Saturday 28 December 2013, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
On Mon, Dec 30, 2013 at 7:55 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
On 12/30/2013 06:05 AM, Arnd Bergmann wrote:
On Saturday 28 December 2013, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang
Dear Jaehoon
Thanks for the reviewing.
On 12/26/2013 12:33 PM, Jaehoon Chung wrote:
+config MMC_DW_K3
+ tristate K3 specific extensions for Synopsys DW Memory Card Interface
+ depends on MMC_DW
+ select MMC_DW_PLTFM
+ select MMC_DW_IDMAC
Only use the IDMAC?
IDMAC
Hi, Zhangfei,
On 12/16/2013 10:12 PM, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 +
On 12/16/2013 09:12 PM, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 +
On 12/16/2013 03:29 PM, Seungwon Jeon wrote:
On Mon, December 16, 2013, Zhangfei Gao wrote:
Dear Seungwon
On 12/16/2013 11:50 AM, Seungwon Jeon wrote:
On Sat, December 14, 2013, Zhangfei Gao wrote:
+ /* SoC portion */
+ dwmmc_0: dwmmc0@fcd03000 {
+ compatible =
On Mon, December 16, 2013, Zhangfei Gao wrote:
On 12/16/2013 03:29 PM, Seungwon Jeon wrote:
On Mon, December 16, 2013, Zhangfei Gao wrote:
Dear Seungwon
On 12/16/2013 11:50 AM, Seungwon Jeon wrote:
On Sat, December 14, 2013, Zhangfei Gao wrote:
+/* SoC portion */
+
On 12/16/2013 05:18 PM, Seungwon Jeon wrote:
On Mon, December 16, 2013, Zhangfei Gao wrote:
On 12/16/2013 03:29 PM, Seungwon Jeon wrote:
On Mon, December 16, 2013, Zhangfei Gao wrote:
Dear Seungwon
On 12/16/2013 11:50 AM, Seungwon Jeon wrote:
On Sat, December 14, 2013, Zhangfei Gao wrote:
On Sat, December 14, 2013, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 +
Dear Seungwon
On 12/16/2013 11:50 AM, Seungwon Jeon wrote:
On Sat, December 14, 2013, Zhangfei Gao wrote:
+/* SoC portion */
+dwmmc_0: dwmmc0@fcd03000 {
+compatible = hisilicon,hi4511-dw-mshc;
+reg = 0xfcd03000 0x1000;
+interrupts = 0 16 4;
+
On Mon, December 16, 2013, Zhangfei Gao wrote:
Dear Seungwon
On 12/16/2013 11:50 AM, Seungwon Jeon wrote:
On Sat, December 14, 2013, Zhangfei Gao wrote:
+ /* SoC portion */
+ dwmmc_0: dwmmc0@fcd03000 {
+ compatible = hisilicon,hi4511-dw-mshc;
+ reg = 0xfcd03000
Dear Arnd
On 12/12/2013 04:12 AM, Arnd Bergmann wrote:
On Wednesday 11 December 2013, zhangfei wrote:
I have not seen clk-table and clk-table-num before. Are these standard
properties? What are the units that are used here, what does the index mean?
clk-table and clk-table-num are private
On Thursday 12 December 2013, zhangfei wrote:
On 12/12/2013 04:12 AM, Arnd Bergmann wrote:
On Wednesday 11 December 2013, zhangfei wrote:
But aren't the times fixed for each mode? Why do you need to specify them in
the DT? I would expect that the clock rates for each mode are set in the
On 12/13/2013 04:40 AM, Arnd Bergmann wrote:
On Thursday 12 December 2013, zhangfei wrote:
On 12/12/2013 04:12 AM, Arnd Bergmann wrote:
On Wednesday 11 December 2013, zhangfei wrote:
But aren't the times fixed for each mode? Why do you need to specify them in
the DT? I would expect that the
On Wednesday 11 December 2013, Zhangfei Gao wrote:
Add dw_mmc-k3.c for k3v2, support sd/emmc
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
Tested-by: Zhigang Wang brooke.wangzhig...@huawei.com
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 51
On 12/11/2013 10:49 PM, Arnd Bergmann wrote:
On Wednesday 11 December 2013, Zhangfei Gao wrote:
+Required Properties:
+
+* compatible: should be one of the following.
+ - hisilicon,hi4511-dw-mshc: for controllers with hi4511 specific
extentions.
+* clk-table-num: should be number of clks
On Wednesday 11 December 2013, zhangfei wrote:
I have not seen clk-table and clk-table-num before. Are these standard
properties? What are the units that are used here, what does the index mean?
clk-table and clk-table-num are private properties.
Instead simply on/off, the ip need
31 matches
Mail list logo
