ad.org; kyungmin.p...@samsung.com;
> kgene@samsung.com; ben-li...@fluff.org; a...@linux-foundation.org;
> broo...@opensource.wolfsonmicro.com
> Subject: Re: [PATCH 4/4] sdhci-s3c: add regulator support
>
> Op 28-07-10 16:19, Marek Szyprowski schreef:
> > This patch adds suppor
On Wed, Jul 28, 2010 at 04:19:57PM +0200, Marek Szyprowski wrote:
> static int sdhci_s3c_suspend(struct platform_device *dev, pm_message_t pm)
> {
> + int ret = 0;
> struct sdhci_host *host = platform_get_drvdata(dev);
> + struct sdhci_s3c *sc = sdhci_priv(host);
>
> sdhci_
On Wed, Jul 28, 2010 at 07:06:22PM +0200, Maurus Cuelenaere wrote:
> Op 28-07-10 17:41, Mark Brown schreef:
> >>> + if (sc->vmmc) {
> >>> + int ret = regulator_disable(sc->vmmc);
> >>> + if (ret)
> >>> + return ret;
> >>> + mdelay(2);
> >> Shouldn't these
Op 28-07-10 17:41, Mark Brown schreef:
> On 28 Jul 2010, at 07:48, Maurus Cuelenaere wrote:
>>> + struct sdhci_s3c *sc = sdhci_priv(host);
>>> +
>>> + if (sc->vmmc) {
>>> + int ret = regulator_disable(sc->vmmc);
>>> + if (ret)
>>> + return ret;
>>> +
Op 28-07-10 16:19, Marek Szyprowski schreef:
> This patch adds support for regulator API to sdhci-s3c driver. Regulators
> can be used to disable power in suspended state to reduce dissipated
> energy.
I'm not sure about this, when I would try to do this I'd look at implementing
this in the sdhci
