Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Doug Anderson
Seungwon, On Fri, Aug 9, 2013 at 6:33 AM, Seungwon Jeon wrote: > On Wed, August 07, 2013, Doug Anderson wrote: >> If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up >> looping around forever. This has been seen to happen on exynos5420 >> silicon despite the fact that we haven'

RE: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Seungwon Jeon
On Wed, August 07, 2013, Doug Anderson wrote: > If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up > looping around forever. This has been seen to happen on exynos5420 > silicon despite the fact that we haven't enabled any wakeup events due > to a silicon errata. It is safe to

Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-06 Thread Tomasz Figa
On Tuesday 06 of August 2013 15:09:46 Doug Anderson wrote: > Tomasz, > > On Tue, Aug 6, 2013 at 2:58 PM, Tomasz Figa wrote: > >> +static int dw_mci_exynos_resume_noirq(struct device *dev) > >> +{ > >> + struct dw_mci *host = dev_get_drvdata(dev); > >> + u32 clksel; > >> + > >> + clks

Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-06 Thread Doug Anderson
Tomasz, On Tue, Aug 6, 2013 at 2:58 PM, Tomasz Figa wrote: >> +static int dw_mci_exynos_resume_noirq(struct device *dev) >> +{ >> + struct dw_mci *host = dev_get_drvdata(dev); >> + u32 clksel; >> + >> + clksel = mci_readl(host, CLKSEL); >> + if (clksel & SDMMC_CLKSEL_WAKEUP_INT) >

Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-06 Thread Tomasz Figa
Hi Doug, See my comment inline. On Tuesday 06 of August 2013 14:37:49 Doug Anderson wrote: > If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up > looping around forever. This has been seen to happen on exynos5420 > silicon despite the fact that we haven't enabled any wakeup ev