RE: [PATCH v4 2/8] wireless: wl1271: support return value for the set power func

2010-08-11 Thread DebBarma, Tarun Kanti
Ohad, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Ohad Ben-Cohen Sent: Wednesday, August 11, 2010 11:52 PM To: linux-wirel...@vger.kernel.org; linux-mmc@vger.kernel.org; linux- o...@vger.kernel.org Cc: Ido Yariv;

Re: [PATCH v4 2/8] wireless: wl1271: support return value for the set power func

2010-08-11 Thread Ohad Ben-Cohen
On Wed, Aug 11, 2010 at 9:35 PM, DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: -     wl-if_ops-power(wl, true); -     set_bit(WL1271_FLAG_GPIO_POWER, wl-flags); +     int ret = wl-if_ops-power(wl, true); Just a minor comment, need a blank line here? Can't hurt, thanks. +     if (ret ==