Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-22 Thread Sonny Rao
On Mon, May 19, 2014 at 6:49 PM, Seungwon Jeon tgih@samsung.com wrote: On Sat, May 17, 2014, Sonny Rao wrote: On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, May 13, Sonny Rao wrote: On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon

RE: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-19 Thread Seungwon Jeon
On Sat, May 17, 2014, Sonny Rao wrote: On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, May 13, Sonny Rao wrote: On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com wrote: As I mentioned in previous version, you put all reset stuff

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-13 Thread Sonny Rao
On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com wrote: As I mentioned in previous version, you put all reset stuff in existing fifo_reset function. Although databook mentions ciu_reset case for SBE error, it's not obvious when ciu_reset is needed in other error cases.

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-13 Thread Arnd Bergmann
On Monday 12 May 2014 18:38:41 Sonny Rao wrote: +#ifndef CONFIG_MMC_DW_IDMAC + if (host-use_dma) + flags |= SDMMC_CTRL_DMA_RESET; +#endif Can you change the above like this? if (IS_ENABLED(CONFIG_MMC_DW_IDMAC) host-use_dma) flags |=

RE: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-13 Thread Seungwon Jeon
On Tuesday, May 13, Sonny Rao wrote: On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com wrote: As I mentioned in previous version, you put all reset stuff in existing fifo_reset function. Although databook mentions ciu_reset case for SBE error, it's not obvious when

RE: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Seungwon Jeon
As I mentioned in previous version, you put all reset stuff in existing fifo_reset function. Although databook mentions ciu_reset case for SBE error, it's not obvious when ciu_reset is needed in other error cases. If you intend to add some robust error handing, it would be better to make

RE: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Kukjin Kim
Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook 7.2.13. v2: Add Generic DMA support per the documentation, move interrupt clear before wait make the test for DMA