Re: RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-09-05 Thread Linus Walleij
On Mon, Sep 5, 2011 at 2:30 AM, NamJae Jeon wrote: >>> host >>> controller can just know whether card is finish to program to use busy >>> line. If unstable card is holding busy line while writing using DMA, >>> hang problem will happen by wait_for_completion. >>> so I think that mmc driver need

Re: RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-09-04 Thread NamJae Jeon
2011/9/4 Linus Walleij : > 2011/9/2 NamJae Jeon : > >> We should consider DMA situation. As I know, host controller can not >> rise timeout interrupt in write not read in DMA status. > > Which host controller are you talking about? As I know, this controller is using on many ARM core. I can not dis

Re: RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-09-03 Thread Linus Walleij
2011/9/2 NamJae Jeon : > We should consider DMA situation. As I know, host controller can not > rise timeout interrupt in write not read in DMA status. Which host controller are you talking about? > host > controller can just know whether card is finish to program to use busy > line. If unstable

Re: RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-09-01 Thread NamJae Jeon
2011/8/30 Linus Walleij : > On Thu, Aug 25, 2011 at 6:44 AM, NamJae Jeon wrote: > >> If card is infinitely holding pull down busy line(data 0) while >> writing multiple blocks, write will be blocked in >> mmc_wait_for_req_done(). >> I suggest to use wait_for_completion_timeout instread of >> wait_

Re: RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-08-30 Thread Linus Walleij
On Thu, Aug 25, 2011 at 6:44 AM, NamJae Jeon wrote: > If card is infinitely holding pull down busy line(data 0) while > writing multiple blocks, write will be blocked in > mmc_wait_for_req_done(). > I suggest to use wait_for_completion_timeout instread of > wait_for_completion like the below code

RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-08-24 Thread NamJae Jeon
Hi. If card is infinitely holding pull down busy line(data 0) while writing multiple blocks, write will be blocked in mmc_wait_for_req_done(). I suggest to use wait_for_completion_timeout instread of wait_for_completion like the below code. How do you think about my suggestion ? Thanks. ---