Re: commit 'mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host capabilities' breaks ricoh mmc device

2010-11-04 Thread Kyungmin Park
Hi, I got the same problem. diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 782c0ee..a0991ad 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1849,7 +1849,7 @@ int sdhci_add_host(struct sdhci_host *host) mmc->caps |= MMC_CAP_SDIO_IRQ;

Re: commit 'mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host capabilities' breaks ricoh mmc device

2010-11-02 Thread Wolfram Sang
On Wed, Nov 03, 2010 at 06:57:35AM +0100, Wolfram Sang wrote: > On Sat, Oct 30, 2010 at 05:53:46AM +0200, Maxim Levitsky wrote: > > Hi, > > > > I just bisected and reverted this commit. > > Commit-ID would have been useful, too: > b08caed8659ab27199db51c63a35c5ee067fc7ef > Also, adding the auth

Re: commit 'mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host capabilities' breaks ricoh mmc device

2010-11-02 Thread Wolfram Sang
On Sat, Oct 30, 2010 at 05:53:46AM +0200, Maxim Levitsky wrote: > Hi, > > I just bisected and reverted this commit. Commit-ID would have been useful, too: b08caed8659ab27199db51c63a35c5ee067fc7ef Also, adding the author to cc, done now. > With it I am unable to read MMC cards via Ricoh MMC func

Re: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-11-02 Thread Peppe CAVALLARO
On 11/2/2010 12:32 PM, Philip Rakity wrote: > > I believe the patch > > http://permalink.gmane.org/gmane.linux.kernel.mmc/3966 > > does what you want -- if not can you let me know what is missing Hi Philip, I've missed this patch, sorry. Peppe -- To unsubscribe from this list: send the line

Fwd: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-11-02 Thread Philip Rakity
> > > I believe the patch > > http://permalink.gmane.org/gmane.linux.kernel.mmc/3966 > > does what you want -- if not can you let me know what is missing > > > > On Nov 2, 2010, at 4:25 AM, Peppe CAVALLARO wrote: > >> On 11/1/2010 2:52 AM, Philip Rakity wrote: >>> >>> On Oct 31, 2010

Re: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-11-02 Thread Peppe CAVALLARO
On 11/1/2010 2:52 AM, Philip Rakity wrote: > > On Oct 31, 2010, at 6:44 PM, Maxim Levitsky wrote: > > > On Sat, 2010-10-30 at 16:01 +0200, Maxim Levitsky wrote: > >> On Sat, 2010-10-30 at 05:47 -0700, Philip Rakity wrote: > >>> eMMC unlike SD does not have a field to inside the card data to > say t

Re: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-10-31 Thread Philip Rakity
On Oct 31, 2010, at 6:44 PM, Maxim Levitsky wrote: > On Sat, 2010-10-30 at 16:01 +0200, Maxim Levitsky wrote: >> On Sat, 2010-10-30 at 05:47 -0700, Philip Rakity wrote: >>> eMMC unlike SD does not have a field to inside the card data to say the bit >>> width of the card. >>> In addition some m

RE: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-10-31 Thread Maxim Levitsky
On Sat, 2010-10-30 at 16:01 +0200, Maxim Levitsky wrote: > On Sat, 2010-10-30 at 05:47 -0700, Philip Rakity wrote: > > eMMC unlike SD does not have a field to inside the card data to say the bit > > width of the card. > > In addition some mmc cards (from Transcend) only support 1 bit mode. The

RE: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-10-30 Thread Maxim Levitsky
On Sat, 2010-10-30 at 05:47 -0700, Philip Rakity wrote: > eMMC unlike SD does not have a field to inside the card data to say the bit > width of the card. > In addition some mmc cards (from Transcend) only support 1 bit mode. The > physical pins to support 4 bit data are not there as well as n

RE: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-10-30 Thread Philip Rakity
eMMC unlike SD does not have a field to inside the card data to say the bit width of the card. In addition some mmc cards (from Transcend) only support 1 bit mode. The physical pins to support 4 bit data are not there as well as no card specific data saying the bus width of the card. The on

commit 'mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host capabilities' breaks ricoh mmc device

2010-10-29 Thread Maxim Levitsky
Hi, I just bisected and reverted this commit. With it I am unable to read MMC cards via Ricoh MMC function, support for which I added recently. 07:00.2 System peripheral: Ricoh Co Ltd R5C843 MMC Host Controller (rev 12) The logs show lot of errors like this: [ 219.590748] mmc1: new MMC card a