Hello Tony Prisk,

This is a semi-automatic email about new static checker warnings.

The patch 3a96dff0f828: "mmc: SD/MMC Host Controller for Wondermedia 
WM8505/WM8650" from Nov 18, 2012, leads to the following Smatch 
complaint:

drivers/mmc/host/wmt-sdmmc.c:764 wmt_mci_probe()
         warn: variable dereferenced before check 'of_id' (see line 760)

drivers/mmc/host/wmt-sdmmc.c
   759                  of_match_device(wmt_mci_dt_ids, &pdev->dev);
   760          const struct wmt_mci_caps *wmt_caps = of_id->data;
                                                      ^^^^^^^^^^^
Dereference.

   761          int ret;
   762          int regular_irq, dma_irq;
   763  
   764          if (!of_id || !of_id->data) {
                     ^^^^^
Check.

   765                  dev_err(&pdev->dev, "Controller capabilities data 
missing\n");
   766                  return -EFAULT;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to