Re: mmc: rtsx: add support for pre_req and post_req

2014-03-02 Thread micky
On 03/01/2014 04:35 AM, Dan Carpenter wrote: Hello Micky Ching, The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and post_req" from Feb 17, 2014, leads to the following static checker warning: drivers/mmc/host/rtsx_pci_sdmmc.c:525 sd_pre_dma_transfer() warn: we tested

re: mmc: rtsx: add support for pre_req and post_req

2014-02-28 Thread Dan Carpenter
Hello Micky Ching, The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and post_req" from Feb 17, 2014, leads to the following static checker warning: drivers/mmc/host/rtsx_pci_sdmmc.c:525 sd_pre_dma_transfer() warn: we tested 'next' before and it was 'false' drivers/mmc/

Re: mmc: rtsx: add support for pre_req and post_req

2014-02-25 Thread Dan Carpenter
On Tue, Feb 25, 2014 at 09:52:12AM +0800, micky wrote: > Hi Dan, > > I'm wondering how to get this warning info, so I can check before > sending patch. > Can you give me some idea? > This is a smatch thing, but you it's a cross function bug so you have to build the database first and that takes

Re: mmc: rtsx: add support for pre_req and post_req

2014-02-24 Thread micky
Hi Dan, I'm wondering how to get this warning info, so I can check before sending patch. Can you give me some idea? Best Regards. micky. On 02/25/2014 06:03 AM, Dan Carpenter wrote: Hello Micky Ching, This is a semi-automatic email about new static checker warnings. The patch c42deffd5b53

re: mmc: rtsx: add support for pre_req and post_req

2014-02-24 Thread Dan Carpenter
Hello Micky Ching, This is a semi-automatic email about new static checker warnings. The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and post_req" from Feb 17, 2014, leads to the following Smatch complaint: drivers/mmc/host/rtsx_pci_sdmmc.c:194 sd_finish_request() error: we

re: mmc: rtsx: add support for pre_req and post_req

2014-02-24 Thread Dan Carpenter
Hello Micky Ching, This is a semi-automatic email about new static checker warnings. The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and post_req" from Feb 17, 2014, leads to the following Smatch complaint: drivers/mmc/host/rtsx_pci_sdmmc.c:504 sd_get_rsp() error: we previo