Re: [PATCH v7 13/26] x86/insn-eval: Add function to get default params of code segment

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 12:24:35PM -0700, Ricardo Neri wrote: > OK. This makes sense. Perhaps I can use a couple of #define's to set and > get the the address and operand sizes in a single u8. This would make > the code more readable. Sure but don't get too tangled in defines if it is going to be

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 12:04:21PM -0700, Ricardo Neri wrote: > On Thu, 2017-06-15 at 11:37 -0700, Ricardo Neri wrote: > > > Yuck, didn't we talk about this already? > > > > I am sorry Borislav. I thought you agreed that I could use the values > > of > > the segment override prefixes to identify t

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 11:37:51AM -0700, Ricardo Neri wrote: > Wouldn't this be ending up mixing the actual segment register and > segment register overrides? I plan to have a function that parses the > segment override prefixes and returns SEG_REG_CS/DS/ES/FS/GS or > SEG_REG_IGNORE for long mode