Re: [PATCH] nilfs2: add tracepoints for analyzing reading and writing metadata files

2015-10-05 Thread Hitoshi Mitake
...1 30598.199520: nilfs2_mdt_insert_new_block: >> inode = 88022a8d0178 ino = 3 block = 5 >> cp-14635 [000] ...1 30598.200828: nilfs2_mdt_insert_new_block: >> inode = 88022a8d0178 ino = 3 block = 253 >> >> Cc: TK Kato <tk.k...@wdc.com> >>

[PATCH] nilfs2: add tracepoints for analyzing reading and writing metadata files

2015-10-03 Thread Hitoshi Mitake
k.k...@wdc.com> Signed-off-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp> --- fs/nilfs2/mdt.c | 6 + include/trace/events/nilfs2.h | 54 +++ 2 files changed, 60 insertions(+) diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c i

[PATCH tracepoints 0/2] refine coding style of the tracepoints branch

2015-01-01 Thread Hitoshi Mitake
This patchset refines the tracepoints branch of nilfs tree (https://github.com/konis/nilfs2/tree/tracepoints). The change unifies TP_printk() style. The new style doesn't put ',' between fields. Ryusuke-san, could you replace the tracepoints branch with this patchset? Hitoshi Mitake (2

[PATCH tracepoints 2/2] nilfs2: add a tracepoint for transaction events

2015-01-01 Thread Hitoshi Mitake
usage in collection stage transition event for consistent coding style. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 33 ++- include/trace/events/nilfs2.h | 53 +++ 2 files changed, 85

[PATCH tracepoints 1/2] nilfs2: add a tracepoint for tracking stage transition of segment construction

2015-01-01 Thread Hitoshi Mitake
. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 71 +++ fs/nilfs2/segment.h | 3 +- include/trace/events/nilfs2.h | 50 ++ 3 files changed, 103 insertions(+), 21 deletions

Re: [PATCH tracepoints v2] nilfs2: add a tracepoint for transaction events

2014-09-28 Thread Hitoshi Mitake
= UNLOCK segctord-4371 [001] ...1 132.376847: nilfs2_transaction_transition: sb = 8802112b8800, ti = 8800b889bdf8, count = 0, flags = 10 state = TRYLOCK Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 33

[PATCH tracepoints v3] nilfs2: add a tracepoint for transaction events

2014-09-28 Thread Hitoshi Mitake
usage in collection stage transition event for consistent coding style. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- v3: fix a style problem in TP_printk() v2: fix a style problem fs/nilfs2/segment.c | 33 +- include/trace/events/nilfs2.h | 55

[PATCH tracepoints v2] nilfs2: add a tracepoint for transaction events

2014-09-25 Thread Hitoshi Mitake
-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 33 ++- include/trace/events/nilfs2.h | 53 +++ 2 files changed, 85 insertions(+), 1 deletion(-) v2: fix a style problem diff --git a/fs/nilfs2

[PATCH tracepoints] nilfs2: add a tracepoint for transaction events

2014-09-24 Thread Hitoshi Mitake
-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 33 ++- include/trace/events/nilfs2.h | 53 +++ 2 files changed, 85 insertions(+), 1 deletion(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c

Re: [PATCH v3] nilfs2: add a tracepoint for tracking stage transition of segment construction

2014-09-14 Thread Hitoshi Mitake
analysis. This patch is something like demonstration. If this concept is acceptable for the nilfs community, I'd like to add more tracepoints and prepare analysis tools. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 71

Re: [PATCH v2] nilfs2: add a tracepoint for tracking stage transition of segment construction

2014-09-13 Thread Hitoshi Mitake
On Fri, Sep 5, 2014 at 3:40 PM, Vyacheslav Dubeyko sl...@dubeyko.com wrote: On Fri, 2014-09-05 at 11:41 +0900, Hitoshi Mitake wrote: [snip] diff --git a/fs/nilfs2/segment.h b/fs/nilfs2/segment.h index 38a1d00..1e9b931 100644 --- a/fs/nilfs2/segment.h +++ b/fs/nilfs2/segment.h @@ -66,13

[PATCH v3] nilfs2: add a tracepoint for tracking stage transition of segment construction

2014-09-13 Thread Hitoshi Mitake
-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 71 +++ fs/nilfs2/segment.h | 3 +- include/trace/events/nilfs2.h | 50 ++ 3 files changed, 103 insertions(+), 21 deletions(-) create mode

Re: [PATCH RFC] nilfs2: add a tracepoint for tracking stage transition of segment construction

2014-09-04 Thread Hitoshi Mitake
On Thu, Sep 4, 2014 at 3:23 AM, Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp wrote: Hi Mitake-san, On Tue, 2 Sep 2014 21:19:39 +0900, Mitake Hitoshi wrote: From: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp This patch adds a tracepoint for tracking stage transition of block collection

[PATCH RFC] nilfs2: add a tracepoint for tracking stage transition of segment construction

2014-09-02 Thread Hitoshi Mitake
From: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp This patch adds a tracepoint for tracking stage transition of block collection in segment construction. With the tracepoint, we can analysis the behavior of segment construction in depth. It would be useful for bottleneck detection and debugging

Re: [PATCH] lib/cleaner_exec.c: get process ID of cleanerd through pipe

2014-01-25 Thread Hitoshi Mitake
, and umount.nilfs2 fails to kill cleanerd. This fixes the issue by letting cleanerd print out the pid of spawned daemon and letting nilfs_launch_cleanerd() function read it through pipe. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp Cc: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp

Re: [PATCH] mkfs: check sizes of important structs at build time

2014-01-05 Thread Hitoshi Mitake
At Sat, 4 Jan 2014 18:39:58 +0300, Vyacheslav Dubeyko wrote: On Jan 4, 2014, at 4:54 PM, Hitoshi Mitake wrote: On Sat, Jan 4, 2014 at 11:52 PM, Vyacheslav Dubeyko sl...@dubeyko.com wrote: On Jan 4, 2014, at 4:29 PM, Hitoshi Mitake wrote: Current nilfs_check_ondisk_sizes

Re: [PATCH] mkfs: check sizes of important structs at build time

2014-01-05 Thread Hitoshi Mitake
At Sun, 05 Jan 2014 01:08:43 +0900 (JST), Ryusuke Konishi wrote: On Sat, 4 Jan 2014 22:29:31 +0900, Hitoshi Mitake wrote: Current nilfs_check_ondisk_sizes() checks sizes of important structs at run time. The checking should be done at build time. This patch adds a new macro, BUILD_BUG_ON

Re: [PATCH nilfs-utils 1/2] cleanerd: call _exit(2) twice for ensuring not being a session leader

2014-01-05 Thread Hitoshi Mitake
At Sat, 04 Jan 2014 23:28:06 +0900 (JST), Ryusuke Konishi wrote: Hi, On Sat, 4 Jan 2014 22:18:00 +0900, Hitoshi Mitake wrote: On Wed, Jan 1, 2014 at 6:30 PM, Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp wrote: On Wed, 1 Jan 2014 16:30:48 +0900, Hitoshi Mitake wrote: Current daemonize

[PATCH nilfs-utils v2 1/4] cleanerd: ignore nofork option

2014-01-05 Thread Hitoshi Mitake
The nofork option aims to reduce call of fork(), but it is not effective. This patch lets cleanerd ignore the option simply even if it is passed. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- sbin/cleanerd/cleanerd.c | 28 1 file changed, 12

[PATCH nilfs-utils v2 3/4] mount: don't pass -n option to cleanerd

2014-01-05 Thread Hitoshi Mitake
This patch lets mount.nilfs2 not pass the -n option to cleanerd, because it is obsoleted. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- lib/cleaner_exec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/cleaner_exec.c b/lib/cleaner_exec.c index 299451c

[PATCH nilfs-utils v2 2/4] cleanerd: call _exit(2) twice for ensuring not being a session leader

2014-01-05 Thread Hitoshi Mitake
(though it happens rarely). The signal would be confusing event for cleanerd of nilfs. This patch removes this potential problem. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- sbin/cleanerd/cleanerd.c | 8 1 file changed, 8 insertions(+) diff --git a/sbin/cleanerd/cleanerd.c

Re: [PATCH nilfs-utils v2 2/4] cleanerd: call _exit(2) twice for ensuring not being a session leader

2014-01-05 Thread Hitoshi Mitake
At Sun, 5 Jan 2014 22:44:41 +0400, Сергей Александров wrote: [1 text/plain; KOI8-R (quoted-printable)] Hello, May be it makes sense to use pid files in /var/run folder with special names like nilfs_cleanerd_dev.pid (nilfs_cleanerd_sda1.pid for instance) for this purpose? But it looks a

Re: [PATCH nilfs-utils 1/2] cleanerd: call _exit(2) twice for ensuring not being a session leader

2014-01-04 Thread Hitoshi Mitake
On Wed, Jan 1, 2014 at 6:30 PM, Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp wrote: On Wed, 1 Jan 2014 16:30:48 +0900, Hitoshi Mitake wrote: Current daemonize() function of cleanerd call _exit(2) only once during its process of becoming a daemon process. But in the linux environment, a daemon

[PATCH] mkfs: check sizes of important structs at build time

2014-01-04 Thread Hitoshi Mitake
: negative width in bit-field 'anonymous' Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- sbin/mkfs/mkfs.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sbin/mkfs/mkfs.c b/sbin/mkfs/mkfs.c index 4e153ce..8eb00bf 100644 --- a/sbin/mkfs/mkfs.c

Re: [PATCH] mkfs: check sizes of important structs at build time

2014-01-04 Thread Hitoshi Mitake
On Sat, Jan 4, 2014 at 11:52 PM, Vyacheslav Dubeyko sl...@dubeyko.com wrote: On Jan 4, 2014, at 4:29 PM, Hitoshi Mitake wrote: Current nilfs_check_ondisk_sizes() checks sizes of important structs at run time. The checking should be done at build time. This patch adds a new macro

[PATCH nilfs-utils 2/2] cleanerd: adjust the OOM killer

2013-12-31 Thread Hitoshi Mitake
cleanerd is a very important process in a system which uses nilfs. So it should adjust the OOM killer for reducing possibility of the killing as much as possible. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- sbin/cleanerd/cleanerd.c | 39

[PATCH nilfs-utils 1/2] cleanerd: call _exit(2) twice for ensuring not being a session leader

2013-12-31 Thread Hitoshi Mitake
to the process (though it happens rarely). The signal would be confusing event for cleanerd of nilfs. This patch removes this potential problem. Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- sbin/cleanerd/cleanerd.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sbin