[PATCH] libnvdimm: initialize struct blk_integrity with 0

2016-06-23 Thread Johannes Thumshirn
Initialize struct blk_integrity with 0 as blk_integrity_register() takes the then unitialized struct blk_integrity::flags and ORs it to the resulting block integrity structure. Signed-off-by: Johannes Thumshirn --- drivers/nvdimm/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

Re: [PATCH 3/3] dax: Clear dirty entry tags on cache flush

2016-06-23 Thread Jan Kara
Hi, the previous version had a bug which manifested itself on i586. Attached is a new version for the patch if someone is interested. Honza -- Jan Kara SUSE Labs, CR ___ Linux-nvdimm mail

Re: [PATCH] x86/mm: only allow memmap=XX!YY over existing RAM

2016-06-23 Thread Boaz Harrosh
On 06/20/2016 10:33 AM, Yigal Korman wrote: > Before this patch, passing a range that is beyond the physical memory > range will succeed, the user will see a /dev/pmem0 and will be able to > access it. Reads will always return 0 and writes will be silently > ignored. > > I've gotten more than one

Re: [PATCH 8/8] xfs: fix locking for DAX writes

2016-06-23 Thread Boaz Harrosh
On 06/22/2016 06:27 PM, Christoph Hellwig wrote: > So far DAX writes inherited the locking from direct I/O writes, but the direct > I/O model of using shared locks for writes is actually wrong for DAX. For > direct I/O we're out of any standards and don't have to provide the Posix > required exclu

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Yigal Korman
On Thu, Jun 23, 2016 at 2:54 AM, Toshi Kani wrote: > > Currently, presence of direct_access() in block_device_operations > indicates support of DAX on its block device. Because > block_device_operations is instantiated with 'const', this DAX > capablity may not be enabled conditinally. > > In pre

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Kani, Toshimitsu
On Thu, 2016-06-23 at 19:31 +0300, Yigal Korman wrote: > On Thu, Jun 23, 2016 at 2:54 AM, Toshi Kani wrote: > > > > > > Currently, presence of direct_access() in block_device_operations > > indicates support of DAX on its block device.  Because > > block_device_operations is instantiated with 'c

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Yigal Korman
On Thu, Jun 23, 2016 at 8:36 PM, Kani, Toshimitsu wrote: > On Thu, 2016-06-23 at 19:31 +0300, Yigal Korman wrote: >> On Thu, Jun 23, 2016 at 2:54 AM, Toshi Kani wrote: >> > >> > >> > Currently, presence of direct_access() in block_device_operations >> > indicates support of DAX on its block devic

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Dan Williams
On Thu, Jun 23, 2016 at 11:05 AM, Yigal Korman wrote: > On Thu, Jun 23, 2016 at 8:36 PM, Kani, Toshimitsu wrote: >> On Thu, 2016-06-23 at 19:31 +0300, Yigal Korman wrote: >>> On Thu, Jun 23, 2016 at 2:54 AM, Toshi Kani wrote: >>> > >>> > >>> > Currently, presence of direct_access() in block_devi

[PATCH 0/3] Misc. ndctl fixes

2016-06-23 Thread Jeff Moyer
Static checkers turned up a few potential problems in the code. This series fixes them. Cheers, Jeff [PATCH 1/3] util_namespace_to_json: fix potential null pointer [PATCH 2/3] daxctl_region_unref: fix a potential null pointer [PATCH 3/3] validate_namespace_options: fix bogus test ___

[PATCH 1/3] util_namespace_to_json: fix potential null pointer dereference

2016-06-23 Thread Jeff Moyer
Coverity pointed out that "dax" could be NULL, and it goes unchecked. Signed-off-by: Jeff Moyer --- ndctl/util/json.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ndctl/util/json.c b/ndctl/util/json.c index d144039..92e50fa 100644 --- a/ndctl/util/json.c +++ b/ndctl/util/json.c @@ -133,

[PATCH 2/3] daxctl_region_unref: fix a potential null pointer dereference

2016-06-23 Thread Jeff Moyer
Move the assignment of ctx to after the NULL check. Signed-off-by: Jeff Moyer --- daxctl/lib/libdaxctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c index a8ad58d..9d71a29 100644 --- a/daxctl/lib/libdaxctl.c +++ b/daxctl/l

[PATCH 3/3] validate_namespace_options: fix bogus test

2016-06-23 Thread Jeff Moyer
Another coverity find. The patch is self-explanatory, I hope. Signed-off-by: Jeff Moyer --- ndctl/builtin-xaction-namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ndctl/builtin-xaction-namespace.c b/ndctl/builtin-xaction-namespace.c index 8ce7c3e..7411a01 10064

Re: [PATCH 1/3] util_namespace_to_json: fix potential null pointer dereference

2016-06-23 Thread Dan Williams
On Thu, Jun 23, 2016 at 12:59 PM, Jeff Moyer wrote: > Coverity pointed out that "dax" could be NULL, and it goes unchecked. > > Signed-off-by: Jeff Moyer > --- > ndctl/util/json.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ndctl/util/json.c b/ndctl/util/json.c > index d144039..92

[PATCH v3 0/4] Support DAX for device-mapper linear devices

2016-06-23 Thread Mike Snitzer
Jens, please pick up the first 2 block patches and I'll get the other 2 DM patches staged for 4.8. v3: - fixed "warning: context imbalance in 'dm_blk_direct_access' - different lock contexts for basic block" due to missing dm_put_live_table in dm_blk_direct_access's dm_get_live_table error

[PATCH v3 1/4] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Mike Snitzer
From: Toshi Kani Currently, presence of direct_access() in block_device_operations indicates support of DAX on its block device. Because block_device_operations is instantiated with 'const', this DAX capablity may not be enabled conditinally. In preparation for supporting DAX to device-mapper d

[PATCH v3 4/4] dm linear: add DAX support

2016-06-23 Thread Mike Snitzer
From: Toshi Kani Change dm-linear to implement direct_access function, linear_direct_access(), which maps sector and calls direct_access function of its physical target device. Signed-off-by: Toshi Kani Signed-off-by: Mike Snitzer Cc: Alasdair Kergon Cc: Dan Williams Cc: Ross Zwisler --- d

[PATCH v3 3/4] dm: add infrastructure for DAX support

2016-06-23 Thread Mike Snitzer
From: Toshi Kani Change mapped device to implement direct_access function, dm_blk_direct_access(), which calls a target direct_access function. 'struct target_type' is extended to have target direct_access interface. This function limits direct accessible size to the dm_target's limit with max_io

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Mike Snitzer
On Thu, Jun 23 2016 at 1:36pm -0400, Kani, Toshimitsu wrote: > On Thu, 2016-06-23 at 19:31 +0300, Yigal Korman wrote: > > On Thu, Jun 23, 2016 at 2:54 AM, Toshi Kani wrote: > > > > > > > > > Currently, presence of direct_access() in block_device_operations > > > indicates support of DAX on it

[PATCH v3 2/4] block: expose QUEUE_FLAG_DAX in sysfs

2016-06-23 Thread Mike Snitzer
From: Yigal Korman Provides the ability to identify DAX enabled devices in userspace. Signed-off-by: Yigal Korman Signed-off-by: Toshi Kani Acked-by: Dan Williams Signed-off-by: Mike Snitzer --- block/blk-sysfs.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/blk-sys

Re: xfs: untangle the direct I/O and DAX path, fix DAX locking

2016-06-23 Thread Dave Chinner
On Wed, Jun 22, 2016 at 05:27:08PM +0200, Christoph Hellwig wrote: > The last patch is what started the series: XFS currently uses the > direct I/O locking strategy for DAX because DAX was overloaded onto > the direct I/O path. For XFS this means that we only take a shared > inode lock instead of

Re: [PATCH v3 3/4] dm: add infrastructure for DAX support

2016-06-23 Thread Kani, Toshimitsu
On Thu, 2016-06-23 at 17:05 -0400, Mike Snitzer wrote:  : > +static int device_supports_dax(struct dm_target *ti, struct dm_dev *dev, > +    sector_t start, sector_t len, void *data) > +{ > + struct request_queue *q = bdev_get_queue(dev->bdev); > + > + return q && bl

Re: xfs: untangle the direct I/O and DAX path, fix DAX locking

2016-06-23 Thread Dan Williams
On Thu, Jun 23, 2016 at 4:24 PM, Dave Chinner wrote: > On Wed, Jun 22, 2016 at 05:27:08PM +0200, Christoph Hellwig wrote: >> The last patch is what started the series: XFS currently uses the >> direct I/O locking strategy for DAX because DAX was overloaded onto >> the direct I/O path. For XFS th

Re: [RFC PATCH 0/2] Initial support for badblock checking in xfs

2016-06-23 Thread Darrick J. Wong
On Mon, Jun 20, 2016 at 12:48:27PM -0600, Vishal Verma wrote: > On 06/16, Vishal Verma wrote: > > These are early/RFC patches to add badblock support in xfs. > > > > Patch 1 should be relatively straightforward - it adds a notifier chain > > to badblocks that filesystems can register with. > > >

Re: [PATCH v3 3/4] dm: add infrastructure for DAX support

2016-06-23 Thread Mike Snitzer
On Thu, Jun 23 2016 at 7:36pm -0400, Kani, Toshimitsu wrote: > On Thu, 2016-06-23 at 17:05 -0400, Mike Snitzer wrote: >  : > > +static int device_supports_dax(struct dm_target *ti, struct dm_dev *dev, > > +    sector_t start, sector_t len, void *data) > > +{ > > + struct

ESPAGNE , maison neuve avec piscine pour 193500 euros

2016-06-23 Thread reina
REINA INMO ESPAGNE Investir au soleil de la méditerranée HOTLINEService commercial en Français : +34 966 782 414Service commercial en Anglais : +34 966 782 178Service gestion locative : +34 622 630 748Service travaux & après-vente : +34 966 782 178 Toutes nos maisons à v

[PATCH] libnvdimm, pfn, dax: fix initialization vs autodetect for mode + alignment

2016-06-23 Thread Dan Williams
The updated ndctl unit tests discovered that if a pfn configuration with a 4K alignment is read from the namespace, that alignment will be ignored in favor of the default 2M alignment. The result is that the configuration will fail initialization with a message like: dax6.1: bad offset: 0x220