Re: Enabling peer to peer device transactions for PCIe devices

2017-01-11 Thread Stephen Bates
On Fri, January 6, 2017 4:10 pm, Logan Gunthorpe wrote: > > > On 06/01/17 11:26 AM, Jason Gunthorpe wrote: > > >> Make a generic API for all of this and you'd have my vote.. >> >> >> IMHO, you must support basic pinning semantics - that is necessary to >> support generic short lived DMA (eg filesys

[PATCH v7] x86: fix kaslr and memmap collision

2017-01-11 Thread Dave Jiang
CONFIG_RANDOMIZE_BASE relocates the kernel to a random base address. However it does not take into account the memmap= parameter passed in from the kernel cmdline. This results in the kernel sometimes being put in the middle of memmap. Teaching kaslr to not insert the kernel in memmap defined regio

Re: [PATCH v6] x86: fix kaslr and memmap collision

2017-01-11 Thread Dave Jiang
On 01/11/2017 05:00 AM, Thomas Gleixner wrote: > On Tue, 10 Jan 2017, Dave Jiang wrote: >> +unsigned long simple_strtoul(const char *cp, char **endp, unsigned int >> base); >> +long simple_strtol(const char *cp, char **endp, unsigned int base); > > What are those functions for? They are not use

Re: [PATCH v4] DAX: enable iostat for read/write

2017-01-11 Thread Kani, Toshimitsu
On Tue, 2017-01-10 at 20:36 -0800, Joe Perches wrote: > > On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote: > > DAX IO path does not support iostat, but its metadata IO path does. > > Therefore, iostat shows metadata IO statistics only, which has been > > confusing to users. > > [] > > diff --

Re: [PATCH v6] x86: fix kaslr and memmap collision

2017-01-11 Thread Thomas Gleixner
On Tue, 10 Jan 2017, Dave Jiang wrote: > +unsigned long simple_strtoul(const char *cp, char **endp, unsigned int base); > +long simple_strtol(const char *cp, char **endp, unsigned int base); What are those functions for? They are not used in that patch at all. > +static void mem_avoid_memmap(void

Re: [PATCH 2/2] dax: assert that i_rwsem is held exclusive for writes

2017-01-11 Thread Jan Kara
On Tue 10-01-17 16:48:08, Christoph Hellwig wrote: > Make sure all callers follow the same locking protocol, given that DAX > transparantly replaced the normal buffered I/O path. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Probably also for Ted since it

Re: [PATCH] dax: fix build warnings with FS_DAX and !FS_IOMAP

2017-01-11 Thread Christoph Hellwig
Looks fine: Reviewed-by: Christoph Hellwig ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 1/2] ext4: fix DAX write locking

2017-01-11 Thread Jan Kara
On Tue 10-01-17 16:48:07, Christoph Hellwig wrote: > Unlike O_DIRECT DAX is not an optional opt-in feature selected by the > application, so we'll have to provide the traditional synchronŃ–zation > of overlapping writes as we do for buffered writes. > > This was broken historically for DAX, but got

Re: [PATCH] dax: fix build warnings with FS_DAX and !FS_IOMAP

2017-01-11 Thread Jan Kara
On Tue 10-01-17 15:29:43, Ross Zwisler wrote: > As reported by Arnd: > > https://lkml.org/lkml/2017/1/10/756 > > Compiling with the following configuration: > > # CONFIG_EXT2_FS is not set > # CONFIG_EXT4_FS is not set > # CONFIG_XFS_FS is not set > # CONFIG_FS_IOMAP depends on the above