Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 02:25:35PM -0800, Dan Williams wrote: > On Fri, Feb 10, 2017 at 12:17 PM, Greg Kroah-Hartman > wrote: > > On Fri, Feb 10, 2017 at 11:41:20AM -0800, Dan Williams wrote: > >> On Fri, Feb 10, 2017 at 11:19 AM, Logan Gunthorpe > >> wrote: > >> > I copied this code and per fee

Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Dan Williams
On Fri, Feb 10, 2017 at 12:17 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 10, 2017 at 11:41:20AM -0800, Dan Williams wrote: >> On Fri, Feb 10, 2017 at 11:19 AM, Logan Gunthorpe >> wrote: >> > I copied this code and per feedback from Greg Kroah-Hartman [1] the >> > cdev's kobject's parent should

Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 11:41:20AM -0800, Dan Williams wrote: > On Fri, Feb 10, 2017 at 11:19 AM, Logan Gunthorpe wrote: > > I copied this code and per feedback from Greg Kroah-Hartman [1] the > > cdev's kobject's parent should not be set to the related device. > > This should have minor consequen

Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 12:19:30PM -0700, Logan Gunthorpe wrote: > I copied this code and per feedback from Greg Kroah-Hartman [1] the > cdev's kobject's parent should not be set to the related device. > This should have minor consequences but isn't doing what anyone > expects it to. > > This patc

Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Dan Williams
On Fri, Feb 10, 2017 at 11:19 AM, Logan Gunthorpe wrote: > I copied this code and per feedback from Greg Kroah-Hartman [1] the > cdev's kobject's parent should not be set to the related device. > This should have minor consequences but isn't doing what anyone > expects it to. > > This patch then f

Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Logan Gunthorpe
Hey, Also on the subject of very minor fixes: I noticed drivers/dax is not in the maintainers file. I just assumed the nvdimm list should have been included with those from get_maintainers. Thanks, Logan On 10/02/17 12:19 PM, Logan Gunthorpe wrote: > I copied this code and per feedback from Gre

[PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Logan Gunthorpe
I copied this code and per feedback from Greg Kroah-Hartman [1] the cdev's kobject's parent should not be set to the related device. This should have minor consequences but isn't doing what anyone expects it to. This patch then fixes device-dax so it doesn't make the same mistake. [1] https://lkm

Re: How is a Region format interface codec used in NFIT/PEME/BLK/BTT driver?

2017-02-10 Thread Linda Knippers
On 2/9/2017 9:02 PM, Dan Williams wrote: > On Thu, Feb 9, 2017 at 11:45 AM, Soccer Liu wrote: >> Hi: >> >> I am trying to figure out what changes might be needed in the NVDIMM >> driver set for adding a new Region format interface code. >> After some researching, I found the following consta