Re: [RFC patch 1/4]ndctl: nvdimmd: notify/monitor the feathers of over threshold event

2017-10-12 Thread Qi, Fuli
Let's use the same logging scheme as libndctl where we have 'struct log_ctx' and the the log function can be set to a custom routine. That way we can redirect log messages to syslog or structured json output simply by changing log_ctx.log_fn. Thinking further about this, using log_ctx is

Re: ffsb job does not exit on xfs 4.14-rc1+

2017-10-12 Thread Xiong Zhou
On Thu, Oct 12, 2017 at 08:10:10AM +1100, Dave Chinner wrote: > On Wed, Oct 11, 2017 at 09:54:15PM +0800, Xiong Zhou wrote: > > On Mon, Sep 25, 2017 at 10:49:03AM +0200, Carlos Maiolino wrote: > > > On Mon, Sep 25, 2017 at 01:40:06AM +, Xiong Zhou wrote: > > > > Hi, > > > > > > > > ffsb test

[ndctl PATCH v2 6/6] ndctl/test: add a new unit test for BTT error clearing

2017-10-12 Thread Vishal Verma
The new error injection command allows us to inject errors that persist through changing the mode of a BTT namespace to 'raw' and back. This allows us to test error clearing with a BTT by adding a selective error block to the raw namespace, enabling the BTT, and then clearing it via a write. Cc:

[ndctl PATCH v2 4/6] ndctl/test: add a new unit test for inject-error

2017-10-12 Thread Vishal Verma
Add a new unit test to test all the features of the inject-error command. Cc: Dan Williams Signed-off-by: Vishal Verma --- test/Makefile.am | 3 +- test/inject-error.sh | 120 +++ 2 files

[ndctl PATCH v2 5/6] ndctl/test: update existing unit tests to use inject-error

2017-10-12 Thread Vishal Verma
Until now, various unit tests related to error handling used to expect 'canned' errors to be present in the middle of every nfit_test namespace. With the ACPI error injection patches for nfit_test, this is no longer the case. Update the existing unit tests it inject any errors they need for

[ndctl PATCH v2 0/6] add an inject-error command to ndctl

2017-10-12 Thread Vishal Verma
v2: patch 1: - use poll() instead of a sleep loop when waiting for a scrub. (Dan) patch 2 (new): - move the acpi nfit specific routines into generic wrappers exported by the library. (Dan) patch 3: - rename 'clear' to 'uninject' use 'block' instead of 'sector' (Dan) - cleanup

[ndctl PATCH v2 3/6] ndctl: add an inject-error command

2017-10-12 Thread Vishal Verma
Add an inject-error command to ndctl. This uses the error injection DSMs in ACPI6.2 to provide a generic error injection and management interface. Once can inject errors, and view as well as clear injected errors using these commands. Cc: Dan Williams Signed-off-by:

[ndctl PATCH v2 2/6] libndctl: add error injection related interfaces

2017-10-12 Thread Vishal Verma
Add interfaces to enable error injection commands. Add nfit specific error injection helpers in ndctl/lib/nfit.c, and generic wrappers for them in libndctl. Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/lib/Makefile.am | 1 +

[ndctl PATCH v2 1/6] libndctl: add APIs to get scrub count and to wait for a scrub

2017-10-12 Thread Vishal Verma
The kernel uses sysfs to notify userspace of the number of completed Address Range Scrubs, as well as any ongoing scrubs. Add libndctl helpers to get the scrub count, and to wait for an in-progress scrub to complete. Cc: Dan Williams Signed-off-by: Vishal Verma

答复:企业技术人员如何胜任管理工作

2017-10-12 Thread 翟晴
linux-nvdimm 您好!课题内容在附件,请查收 ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > Dan, > > > > I have a query regarding below patch [*]. My assumption is its halted > > because of memory hotplug restructuring work? Anything I am missing > > here? > > > > [*] https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg02978.html > > It's fallen to the back of my queue since

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 3:52 PM, Pankaj Gupta wrote: > Dan, > > I have a query regarding below patch [*]. My assumption is its halted > because of memory hotplug restructuring work? Anything I am missing > here? > > [*]

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > > wrote: > > > > > > > > > >   This patch adds virtio-pmem driver for KVM guest. > > > > > >   Guest reads the persistent memory range information > > > > > >   over virtio bus from Qemu and reserves the range > > > > > >   as persistent memory. Guest also allocates a block > > > > > >  

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Rik van Riel
On Thu, 2017-10-12 at 18:18 -0400, Pankaj Gupta wrote: > > > > On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta > > wrote: > > > > > > > >   This patch adds virtio-pmem driver for KVM guest. > > > > >   Guest reads the persistent memory range information > > > > >   over virtio

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta wrote: > > > >> > This patch adds virtio-pmem driver for KVM guest. > >> > Guest reads the persistent memory range information > >> > over virtio bus from Qemu and reserves the range > >> > as persistent memory. Guest

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta wrote: > >> > This patch adds virtio-pmem driver for KVM guest. >> > Guest reads the persistent memory range information >> > over virtio bus from Qemu and reserves the range >> > as persistent memory. Guest also allocates

Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files

2017-10-12 Thread Pankaj Gupta
> > On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > > This patch moves common code to base header files > > so that it can be used for both ACPI pmem and VIRTIO pmem > > drivers. More common code needs to be moved out in future > > based on functionality required

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information > > over virtio bus from Qemu and reserves the range > > as persistent memory. Guest also allocates a block > > device corresponding to the pmem range which later > > can be

Re: [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > Guest reads the persistent memory range information > over virtio bus from Qemu and reserves the range > as persistent memory. Guest also allocates a block >

Re: [RFC 1/2] pmem: Move reusable code to base header files

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for

Re: [PATCH v7 07/12] dma-mapping: introduce dma_has_iommu()

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 11:27 AM, Jason Gunthorpe wrote: > On Tue, Oct 10, 2017 at 01:17:26PM -0700, Dan Williams wrote: > >> Also keep in mind that what triggers the lease break is another >> application trying to write or punch holes in a file that is mapped >>

Re: [PATCH v7 07/12] dma-mapping: introduce dma_has_iommu()

2017-10-12 Thread Jason Gunthorpe
On Tue, Oct 10, 2017 at 01:17:26PM -0700, Dan Williams wrote: > Also keep in mind that what triggers the lease break is another > application trying to write or punch holes in a file that is mapped > for RDMA. So, if the hardware can't handle the iommu mapping getting > invalidated asynchronously

Re: [PATCH v9 0/6] MAP_DIRECT for DAX userspace flush

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 7:23 AM, Christoph Hellwig wrote: > Sorry for chiming in so late, been extremely busy lately. > > From quickly glacing over what the now finally described use case is > (which contradicts the subject btw - it's not about flushing, it's > about not removing

Re: [PATCH v9 1/6] mm: introduce MAP_SHARED_VALIDATE, a mechanism to safely define new mmap flags

2017-10-12 Thread Linus Torvalds
On Thu, Oct 12, 2017 at 6:51 AM, Jan Kara wrote: > > When thinking a bit more about this I've realized one problem: Currently > user can call mmap() with MAP_SHARED type and MAP_SYNC or MAP_DIRECT flags > and he will get the new semantics (if the kernel happens to support it). I >

Re: [PATCH v2 5/5] ext4: remove duplicate extended attributes defs

2017-10-12 Thread Theodore Ts'o
On Mon, Sep 11, 2017 at 11:05:26PM -0600, Ross Zwisler wrote: > The following commit: > > commit 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR > interface support") > > added several defines related to extended attributes to ext4.h. They were > added within an #ifndef

Re: [PATCH v2 4/5] ext4: add ext4_should_use_dax()

2017-10-12 Thread Theodore Ts'o
On Tue, Sep 12, 2017 at 08:46:12AM +0200, Jan Kara wrote: > On Mon 11-09-17 23:05:25, Ross Zwisler wrote: > > This helper, in the spirit of ext4_should_dioread_nolock() et al., replaces > > the complex conditional in ext4_set_inode_flags(). > > > > Signed-off-by: Ross Zwisler

Re: [PATCH v2 2/5] ext4: prevent data corruption with journaling + DAX

2017-10-12 Thread Theodore Ts'o
On Mon, Sep 11, 2017 at 11:05:23PM -0600, Ross Zwisler wrote: > The current code has the potential for data corruption when changing an > inode's journaling mode, as that can result in a subsequent unsafe change > in S_DAX. > > I've captured an instance of this data corruption in the following

Re: [PATCH v2 1/5] ext4: prevent data corruption with inline data + DAX

2017-10-12 Thread Theodore Ts'o
On Mon, Sep 11, 2017 at 11:05:22PM -0600, Ross Zwisler wrote: > If an inode has inline data it is currently prevented from using DAX by a > check in ext4_set_inode_flags(). When the inode grows inline data via > ext4_create_inline_data() or removes its inline data via >

[RFC] QEMU: Add virtio pmem device

2017-10-12 Thread Pankaj Gupta
This patch adds virtio-pmem Qemu device. This device configures memory address range information with file backend type. It acts like persistent memory device for KVM guest. It presents the memory address range to virtio-pmem driver over virtio channel and does the block flush whenever there

[RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information over virtio bus from Qemu and reserves the range as persistent memory. Guest also allocates a block device corresponding to the pmem range which later can be accessed with DAX

[RFC 1/2] pmem: Move reusable code to base header files

2017-10-12 Thread Pankaj Gupta
This patch moves common code to base header files so that it can be used for both ACPI pmem and VIRTIO pmem drivers. More common code needs to be moved out in future based on functionality required for virtio_pmem driver and coupling of code with existing ACPI pmem driver. Signed-off-by:

[RFC 0/2] KVM "fake DAX" device flushing

2017-10-12 Thread Pankaj Gupta
We are sharing the prototype version of 'fake DAX' flushing interface for the initial feedback. This is still work in progress and not yet ready for merging. Prototype right now just implements basic functionality without advanced features with two major parts: - Qemu virtio-pmem device It

Re: [PATCH v9 0/6] MAP_DIRECT for DAX userspace flush

2017-10-12 Thread Christoph Hellwig
Sorry for chiming in so late, been extremely busy lately. >From quickly glacing over what the now finally described use case is (which contradicts the subject btw - it's not about flushing, it's about not removing block mapping under a MR) and the previous comments I think that mmap is simply the

Re: [PATCH v9 1/6] mm: introduce MAP_SHARED_VALIDATE, a mechanism to safely define new mmap flags

2017-10-12 Thread Jan Kara
Hi, > diff --git a/mm/mmap.c b/mm/mmap.c > index 680506faceae..2649c00581a0 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1389,6 +1389,18 @@ unsigned long do_mmap(struct file *file, unsigned long > addr, > struct inode *inode = file_inode(file); > > switch (flags

Re: [RFC] KVM "fake DAX" device flushing

2017-10-12 Thread Pankaj Gupta
> On Thu, Oct 12, 2017 at 12:21:46AM +0530, Pankaj Gupta wrote: > > We are sharing the prototype version of 'fake DAX' flushing > > interface for the initial feedback. This is still work in progress > > and not yet ready for merging. > > > > Protoype right now just implements basic functionality

Re: [RFC] KVM "fake DAX" device flushing

2017-10-12 Thread Stefan Hajnoczi
On Thu, Oct 12, 2017 at 12:21:46AM +0530, Pankaj Gupta wrote: > We are sharing the prototype version of 'fake DAX' flushing > interface for the initial feedback. This is still work in progress > and not yet ready for merging. > > Protoype right now just implements basic functionality without