[PATCH] kernel/memremap: Remove stale devres_free() call

devm_memremap_pages() was re-worked in e8d513483300 to take a caller allocated struct dev_pagemap as a function parameter. A call to devres_free() was left in the error cleanup path which results in a kernel panic if the remap fails for some reason. Remove it to fix the panic and let

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

Re: [PATCH] device-dax: remove redundant __func__ in dev_dbg

On Mon, Mar 05, 2018 at 05:09:32PM -0800, Dan Williams wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the dax modules to > do it again. If a user decides to add the +f switch for the dax modules' > dynamic debug

Re: [PATCH] libnvdimm: remove redundant __func__ in dev_dbg

On Mon, Mar 05, 2018 at 05:09:21PM -0800, Dan Williams wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the libnvdimm > modules to do it again. If a user decides to add the +f switch for > libnvdimm's dynamic debug

Returned mail: Data format error

Öº±gqRnÈZèÞX ô>ï2w·ÔýB½ôeYuž)tXj’ú8!j>™iªChí$Zgø‡SÙWw?“ÓZß.Œß”Ná߯N(¬… ¤wÅx6—±$£¡»O1<ý™å¢l)š¥â"ŠCÆêÈ&ëv‹“Ô˜Ye  FáÐä¨üM‰fÕhñÇö‰«»Ë.ÆzÎÜÛ%w[sŸ*m—ŠÔލck£Öñ ]ïYS Íê‘Ý°3øR[ò¾ÄjuA…YbEԗ˜¢L…‹eXùÀL»¾TLˆõ¤èÀÐ7£g8 ­z±ëc¸KNbþÖĈµVÆoC'¶ø6ƒ÷-ÒÌ£2ïA¿Z¯ï7b(£T2(‡ ö8&‰¸!ï3ý»Ã.¾Ogñfg1ˆâZ¦av¢E‡"Ž—¨DÒZ)Oãøµõ

转发:/ 如何进行产品测试需求分析，有效控制测试输入？

linux-nvdimm//讨论主题 1. 如何进行测试需求分析，有效控制测试输入？ 2. 如何根据公司不同的发展阶段确定相应的测试组织结构？确定测试投入？ 3. 如何设计高质量的测试用例，确保测试的完备性？ 4. 如何对测试缺陷进行深入分析，明确问题根源，减少测试重复？ 5. 如何确保测试人员有效参与到产品开发前期，加深对产品的了解？ 6. 如何规划测试人员的职业发展，提升测试人员的成就感？ 详细 内容 请 阅 读 附 件 2018-3-6 ___ Linux-nvdimm

[PATCH] libnvdimm: remove redundant __func__ in dev_dbg

Dynamic debug can be instructed to add the function name to the debug output using the +f switch, so there is no need for the libnvdimm modules to do it again. If a user decides to add the +f switch for libnvdimm's dynamic debug this results in double prints of the function name. Reported-by:

[PATCH] device-dax: remove redundant __func__ in dev_dbg

Dynamic debug can be instructed to add the function name to the debug output using the +f switch, so there is no need for the dax modules to do it again. If a user decides to add the +f switch for the dax modules' dynamic debug this results in double prints of the function name. Reported-by:

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 05/03/18 05:49 PM, Oliver wrote: It's in arch/powerpc/kernel/io.c as _memcpy_toio() and it has two full barriers! Awesome! Our io.h indicates that our iomem accessors are designed to provide x86ish strong ordering of accesses to MMIO space. The git log indicates arch/powerpc/kernel/io.c

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On Tue, Mar 6, 2018 at 4:10 AM, Logan Gunthorpe wrote: > > > On 05/03/18 09:00 AM, Keith Busch wrote: >> >> On Mon, Mar 05, 2018 at 12:33:29PM +1100, Oliver wrote: >>> >>> On Thu, Mar 1, 2018 at 10:40 AM, Logan Gunthorpe >>> wrote: @@ -429,10

Re: [ndctl PATCH] ndctl, create-namespace: fix minimum alignment detection

On Sat, 2018-03-03 at 13:49 -0800, Dan Williams wrote: > Commit 0c31ce0a2875 "ndctl, create-namespace: fix --align= > default..." > tried to make casual testing with nfit_test easier by auto-detecting > the > alignment. However, this auto-detection always falls back to 4K > alignment on kernels

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

On Tue, Feb 06, 2018 at 03:19:15PM -0800, Darrick J. Wong wrote: <> > The last time I paid much attention to DAX was the thread "re-enable XFS > per-inode DAX"[1] last September. Motivating me to merge anything else > into DAX involves convincing me that we (mm, fs, dax developers) have > some

[ndctl PATCH] ndctl, test: add a unit test for partition rescanning

pre-4.16 kernels had a bug where BTT partitions wouldn't come up on driver probe because we were adding a zero-sized disk. Add a unit test that creates partitions, and cycles the namespace to ensure the partitions are automatically brought up. This performs the test for raw, memory, and sector

[PATCH] libnvdimm, {btt, blk}: do integrity setup before add_disk()

Prior to 25520d55cdb6 ("block: Inline blk_integrity in struct gendisk") we needed to temporarily add a zero-capacity disk before registering for blk-integrity. But adding a zero-capacity disk caused the partition table scanning to bail early, and this resulted in partitions not coming up after a

Re: [PATCH 2/2] ndctl: merge firmware-update to dimm.c as one of the dimm ops

On Tue, Feb 27, 2018 at 4:40 PM, Dave Jiang wrote: > Since update-firmware replicate a lot of the parsing code that dimm.c > already uses, moving update-firmware to dimm.c and utilize the already > working functionalities. > > Signed-off-by: Dave Jiang

Re: [PATCH 1/2] ndctl: add check for update firmware supported

On Tue, Feb 27, 2018 at 4:40 PM, Dave Jiang wrote: > Adding generic and intel support function to allow check if update firmware > is supported by the kernel. > > Signed-off-by: Dave Jiang > --- > ndctl/lib/firmware.c | 11 +++ >

Re: [PATCH v2 04/10] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

On 05/03/18 03:28 PM, Bjorn Helgaas wrote: If you put the #ifdef right here, then it's easier to read because we can see that "oh, this is a special and uncommon case that I can probably ignore". Makes sense. I'll do that. Thanks, Logan ___

Re: [PATCH v2 04/10] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

On Thu, Mar 01, 2018 at 12:13:10PM -0700, Logan Gunthorpe wrote: > > > On 01/03/18 11:02 AM, Bjorn Helgaas wrote: > > > void pci_enable_acs(struct pci_dev *dev) > > > { > > > + if (pci_p2pdma_disable_acs(dev)) > > > + return; > > > > This doesn't read naturally to me. I do see that

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On Mon, Mar 05, 2018 at 01:42:12PM -0700, Keith Busch wrote: > On Mon, Mar 05, 2018 at 01:10:53PM -0700, Jason Gunthorpe wrote: > > So when reading the above mlx code, we see the first wmb() being used > > to ensure that CPU stores to cachable memory are visible to the DMA > > triggered by the

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On Mon, Mar 05, 2018 at 01:10:53PM -0700, Jason Gunthorpe wrote: > So when reading the above mlx code, we see the first wmb() being used > to ensure that CPU stores to cachable memory are visible to the DMA > triggered by the doorbell ring. IIUC, we don't need a similar barrier for NVMe to ensure

Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory

>Yes i need to document that some more in hmm.txt... Hi Jermone, thanks for the explanation. Can I suggest you update hmm.txt with what you sent out? > I am about to send RFC for nouveau, i am still working out some bugs. Great. I will keep an eye out for it. An example user of hmm will

转发:/ 战略驱动的流程与组织变革

linux-nvdimm// 战略驱动的流程与组织变革 2018年03月16-17日深圳 2018年03月30-31日上海 【费用】 6800元/人 报名咨询电话：0755-61288035 021-31261580 手机：18890700600 （微信同号）赵先生 在线咨询 QQ：6983436 报名信箱：6983...@qq.com (报名请回复索取报名表） 参课对象 流程管理专业人员及业务中基层干部、各业务领域及职能领域负责人、流程建设推进委员会成员 课程背景

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 05/03/18 01:10 PM, Jason Gunthorpe wrote: So when reading the above mlx code, we see the first wmb() being used to ensure that CPU stores to cachable memory are visible to the DMA triggered by the doorbell ring. Oh, yes, that makes sense. Disregard my previous email as I was wrong. Logan

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 05/03/18 12:57 PM, Sagi Grimberg wrote: Keith, while we're on this, regardless of cmb, is SQE memcopy and DB update ordering always guaranteed? If you look at mlx4 (rdma device driver) that works exactly the same as nvme you will find: --     qp->sq.head += nreq;    

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

- if (nvmeq->sq_cmds_io) - memcpy_toio(>sq_cmds_io[tail], cmd, sizeof(*cmd)); - else - memcpy(>sq_cmds[tail], cmd, sizeof(*cmd)); + memcpy(>sq_cmds[tail], cmd, sizeof(*cmd)); Hmm, how safe is replacing memcpy_toio() with regular memcpy()? On PPC

Re: [PATCH 1/3] nfit_test: improve structure offset handling

On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote: > In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value > which we use to calculate where in our 'nfit_buf' we will place our next > structure. The handling of 'offset' and the calculation of the placement > of the

转发:/ 用人单位必备合同法知识

linux-nvdimm// 详-细 -内 -容 -请 -阅 -读 -附 -件 2018-3-6 ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Mon, Mar 5, 2018 at 10:01 AM, Ross Zwisler wrote: > On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: >> On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler >> wrote: >> > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 05/03/18 11:02 AM, Sinan Kaya wrote: writel has a barrier inside on ARM64. https://elixir.bootlin.com/linux/latest/source/arch/arm64/include/asm/io.h#L143 Yes, and no barrier inside memcpy_toio as it uses __raw_writes. This should be sufficient as we are only accessing addresses that

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 3/5/2018 12:10 PM, Logan Gunthorpe wrote: > > > On 05/03/18 09:00 AM, Keith Busch wrote: >> On Mon, Mar 05, 2018 at 12:33:29PM +1100, Oliver wrote: >>> On Thu, Mar 1, 2018 at 10:40 AM, Logan Gunthorpe >>> wrote: @@ -429,10 +429,7 @@ static void

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler > wrote: > > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > >> Dynamic debug can be instructed to add the function name to the debug >

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler wrote: > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: >> Dynamic debug can be instructed to add the function name to the debug >> output using the +f switch, so there is no need for the nfit module

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 05/03/18 09:00 AM, Keith Busch wrote: On Mon, Mar 05, 2018 at 12:33:29PM +1100, Oliver wrote: On Thu, Mar 1, 2018 at 10:40 AM, Logan Gunthorpe wrote: @@ -429,10 +429,7 @@ static void __nvme_submit_cmd(struct nvme_queue *nvmeq, { u16 tail = nvmeq->sq_tail;

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On Mon, Mar 05, 2018 at 12:33:29PM +1100, Oliver wrote: > On Thu, Mar 1, 2018 at 10:40 AM, Logan Gunthorpe wrote: > > @@ -429,10 +429,7 @@ static void __nvme_submit_cmd(struct nvme_queue *nvmeq, > > { > > u16 tail = nvmeq->sq_tail; > > > - if