Re: [PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-06 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

2018-03-06 Thread Oliver
On Tue, Mar 6, 2018 at 12:14 PM, Logan Gunthorpe wrote: > > On 05/03/18 05:49 PM, Oliver wrote: >> >> It's in arch/powerpc/kernel/io.c as _memcpy_toio() and it has two full >> barriers! >> >> Awesome! >> >> Our io.h indicates that our iomem accessors are designed to provide x86ish >> strong orderi

[PATCH] ndctl: removing daxctl io

2018-03-06 Thread Dave Jiang
With PMDK implementing daxio, we no longer need daxctl io. Removing and free up dependency on libpmem. Signed-off-by: Dave Jiang --- Documentation/daxctl/Makefile.am |3 Documentation/daxctl/daxctl-io.txt | 72 configure.ac | 11 - daxctl/Makefile.am

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 8:06 PM, Ross Zwisler wrote: > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: >> Dynamic debug can be instructed to add the function name to the debug >> output using the +f switch, so there is no need for the nfit module to >> do it again. If a user dec

Re: [PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-06 Thread Logan Gunthorpe
On 05/03/18 09:56 PM, Oliver O'Halloran wrote: devm_memremap_pages() was re-worked in e8d513483300 to take a caller allocated struct dev_pagemap as a function parameter. A call to devres_free() was left in the error cleanup path which results in a kernel panic if the remap fails for some reason

Re: [PATCH] libnvdimm: remove redundant __func__ in dev_dbg

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 7:54 PM, Ross Zwisler wrote: > On Mon, Mar 05, 2018 at 05:09:21PM -0800, Dan Williams wrote: >> Dynamic debug can be instructed to add the function name to the debug >> output using the +f switch, so there is no need for the libnvdimm >> modules to do it again. If a user dec

[PATCH v2 2/2] ndctl: merge firmware-update to dimm.c as one of the dimm ops

2018-03-06 Thread Dave Jiang
Since update-firmware replicate a lot of the parsing code that dimm.c already uses, moving update-firmware to dimm.c and utilize the already working functionalities. Signed-off-by: Dave Jiang --- ndctl/Makefile.am |1 ndctl/dimm.c| 466

[PATCH v2 0/2] ndctl: move firmware update to dimm action

2018-03-06 Thread Dave Jiang
The following series moves firmware update to dimm.c in order to take advantage of the command line parsing that already exists and remove duplications. v2: - Add distinct return errors for lack of support in ndctl, kernel, or platform. - Moved the firmware update defines and structs to its own

[PATCH v2 1/2] ndctl: add check for update firmware supported

2018-03-06 Thread Dave Jiang
Adding generic and intel support function to allow check if update firmware is supported by the kernel. Signed-off-by: Dave Jiang --- ndctl/lib/firmware.c | 11 +++ ndctl/lib/intel.c | 24 ndctl/lib/libndctl.sym |1 + ndctl/lib/private.h|1

Re: [PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 8:55 AM, Logan Gunthorpe wrote: > > > On 05/03/18 09:56 PM, Oliver O'Halloran wrote: >> >> devm_memremap_pages() was re-worked in e8d513483300 to take a caller >> allocated struct dev_pagemap as a function parameter. A call to >> devres_free() was left in the error cleanup p

Re: [PATCH 1/3] nfit_test: improve structure offset handling

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 10:42 AM, Ross Zwisler wrote: > On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote: >> In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value >> which we use to calculate where in our 'nfit_buf' we will place our next >> structure. The handling of

Re: [PATCH] libnvdimm, {btt, blk}: do integrity setup before add_disk()

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 3:56 PM, Vishal Verma wrote: > Prior to 25520d55cdb6 ("block: Inline blk_integrity in struct gendisk") > we needed to temporarily add a zero-capacity disk before registering for > blk-integrity. But adding a zero-capacity disk caused the partition > table scanning to bail ea

Re: [PATCH v2 1/2] ndctl: add check for update firmware supported

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 10:25 AM, Dave Jiang wrote: > Adding generic and intel support function to allow check if update firmware > is supported by the kernel. > > Signed-off-by: Dave Jiang [..] > diff --git a/ndctl/update.c b/ndctl/update.c > index 0f0f0d81..b4ae1ddb 100644 > --- a/ndctl/update.c

Re: [PATCH v2 1/2] ndctl: add check for update firmware supported

2018-03-06 Thread Dave Jiang
On 03/06/2018 01:55 PM, Dan Williams wrote: > On Tue, Mar 6, 2018 at 10:25 AM, Dave Jiang wrote: >> Adding generic and intel support function to allow check if update firmware >> is supported by the kernel. >> >> Signed-off-by: Dave Jiang > [..] >> diff --git a/ndctl/update.c b/ndctl/update.c >

Re: [ndctl PATCH] ndctl, test: add a unit test for partition rescanning

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 3:56 PM, Vishal Verma wrote: > pre-4.16 kernels had a bug where BTT partitions wouldn't come up on > driver probe because we were adding a zero-sized disk. Add a unit test > that creates partitions, and cycles the namespace to ensure the > partitions are automatically brough

Re: [ndctl PATCH] ndctl, test: add a unit test for partition rescanning

2018-03-06 Thread Verma, Vishal L
On Tue, 2018-03-06 at 13:34 -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 3:56 PM, Vishal Verma m> wrote: > > pre-4.16 kernels had a bug where BTT partitions wouldn't come up on > > driver probe because we were adding a zero-sized disk. Add a unit > > test > > that creates partitions, and c

Re: [ndctl PATCH] ndctl, test: add a unit test for partition rescanning

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 1:41 PM, Verma, Vishal L wrote: > > On Tue, 2018-03-06 at 13:34 -0800, Dan Williams wrote: >> On Mon, Mar 5, 2018 at 3:56 PM, Vishal Verma > m> wrote: >> > pre-4.16 kernels had a bug where BTT partitions wouldn't come up on >> > driver probe because we were adding a zero-siz

Re: [ndctl PATCH] ndctl, test: add a unit test for partition rescanning

2018-03-06 Thread Verma, Vishal L
On Tue, 2018-03-06 at 13:47 -0800, Dan Williams wrote: > On Tue, Mar 6, 2018 at 1:41 PM, Verma, Vishal L > wrote: > > > > On Tue, 2018-03-06 at 13:34 -0800, Dan Williams wrote: > > > On Mon, Mar 5, 2018 at 3:56 PM, Vishal Verma > > l.co > > > m> wrote: > > > > pre-4.16 kernels had a bug where B

Re: [ndctl PATCH] ndctl, test: add a unit test for partition rescanning

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 1:49 PM, Verma, Vishal L wrote: > > On Tue, 2018-03-06 at 13:47 -0800, Dan Williams wrote: >> On Tue, Mar 6, 2018 at 1:41 PM, Verma, Vishal L >> wrote: >> > >> > On Tue, 2018-03-06 at 13:34 -0800, Dan Williams wrote: >> > > On Mon, Mar 5, 2018 at 3:56 PM, Vishal Verma > > >

Re: [ndctl PATCH] ndctl, test: add a unit test for partition rescanning

2018-03-06 Thread Verma, Vishal L
On Tue, 2018-03-06 at 14:04 -0800, Dan Williams wrote: > On Tue, Mar 6, 2018 at 1:49 PM, Verma, Vishal L > wrote: > > > > On Tue, 2018-03-06 at 13:47 -0800, Dan Williams wrote: > > > On Tue, Mar 6, 2018 at 1:41 PM, Verma, Vishal L > > > wrote: > > > > > > > > On Tue, 2018-03-06 at 13:34 -0800,

[PATCH v3 1/2] ndctl: add check for update firmware supported

2018-03-06 Thread Dave Jiang
Adding generic and intel support function to allow check if update firmware is supported by the kernel. Signed-off-by: Dave Jiang Reviewed-by: Dan Williams --- ndctl/lib/firmware.c | 11 +++ ndctl/lib/intel.c | 24 ndctl/lib/libndctl.sym |1 + ndc

[PATCH v3 2/2] ndctl: merge firmware-update to dimm.c as one of the dimm ops

2018-03-06 Thread Dave Jiang
Since update-firmware replicate a lot of the parsing code that dimm.c already uses, moving update-firmware to dimm.c and utilize the already working functionalities. Signed-off-by: Dave Jiang --- ndctl/Makefile.am |1 ndctl/dimm.c| 466

[PATCH v3 0/2] ndctl: move firmware update to dimm action

2018-03-06 Thread Dave Jiang
The following series moves firmware update to dimm.c in order to take advantage of the command line parsing that already exists and remove duplications. v3: - Modified error printout for op not supported per Dan's comment. v2: - Add distinct return errors for lack of support in ndctl, kernel, or

[PATCH v3 1/2] ndctl: add check for update firmware supported

2018-03-06 Thread Dave Jiang
Adding generic and intel support function to allow check if update firmware is supported by the kernel. Signed-off-by: Dave Jiang Reviewed-by: Dan Williams --- ndctl/lib/firmware.c | 11 +++ ndctl/lib/intel.c | 24 ndctl/lib/libndctl.sym |1 + ndc

Re: [PATCH] libnvdimm: remove redundant __func__ in dev_dbg

2018-03-06 Thread Ross Zwisler
On Tue, Mar 06, 2018 at 08:59:11AM -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 7:54 PM, Ross Zwisler > wrote: > > On Mon, Mar 05, 2018 at 05:09:21PM -0800, Dan Williams wrote: > >> Dynamic debug can be instructed to add the function name to the debug > >> output using the +f switch, so the

Delivery reports about your e-mail

2018-03-06 Thread Mail Delivery Subsystem
___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm