Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mike Snitzer
On Wed, May 30 2018 at 10:46P -0400, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > > > Fine I'll deal with it. reordering the fields eliminated holes in the > > > > structure and reduced struct members spanning cache lines. > > > > > > And what about this? > > >

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mike Snitzer
On Wed, May 30 2018 at 10:09P -0400, Mikulas Patocka wrote: > And what about this? > #define WC_MODE_PMEM(wc)((wc)->pmem_mode) > > The code that I had just allowed the compiler to optimize out > persistent-memory code if we have DM_WRITECACHE_ONLY_SSD defined - and you

Question about Experimental of Filesystem DAX.

2018-05-30 Thread Yasunori Goto
Hello, I would like to know about the Experimental message of Filesystem DAX. DAX enabled. Warning: EXPERIMENTAL, use at your own risk AFAIK, the final issue of Filesystem DAX is met

Re: [PATCH 05/11] filesystem-dax: set page->index

2018-05-30 Thread Dan Williams
On Wed, May 30, 2018 at 1:13 AM, Jan Kara wrote: > On Tue 29-05-18 18:38:41, Dan Williams wrote: >> On Wed, May 23, 2018 at 1:40 AM, Jan Kara wrote: >> > On Tue 22-05-18 07:39:57, Dan Williams wrote: >> >> In support of enabling memory_failure() handling for filesystem-dax >> >> mappings, set ->i

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Dan Williams
On Wed, May 30, 2018 at 8:58 AM, Dan Williams wrote: > On Wed, May 30, 2018 at 6:07 AM, Mikulas Patocka wrote: >> >> >> On Mon, 28 May 2018, Dan Williams wrote: >> >>> On Mon, May 28, 2018 at 6:32 AM, Mikulas Patocka >>> wrote: >>> > >>> > >>> > On Sat, 26 May 2018, Dan Williams wrote: >>> > >>

Re: [PATCH 03/11] device-dax: enable page_mapping()

2018-05-30 Thread kbuild test robot
Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc7 next-20180530] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: arch_wb_cache_pmem on ARM64

2018-05-30 Thread Mark Rutland
On Wed, May 30, 2018 at 06:31:42PM +0100, Robin Murphy wrote: > On 30/05/18 18:00, Mikulas Patocka wrote: > > Hi > > > > I'd like to ask what's the purpose of dmb(osh) in the function > > arch_wb_cache_pmem in arch/arm64/mm/flush.c? > > > > void arch_wb_cache_pmem(void *addr, size_t size) > > { >

Re: arch_wb_cache_pmem on ARM64

2018-05-30 Thread Robin Murphy
On 30/05/18 18:00, Mikulas Patocka wrote: Hi I'd like to ask what's the purpose of dmb(osh) in the function arch_wb_cache_pmem in arch/arm64/mm/flush.c? void arch_wb_cache_pmem(void *addr, size_t size) { /* Ensure order against any prior non-cacheable writes */ dmb(osh);

arch_wb_cache_pmem on ARM64

2018-05-30 Thread Mikulas Patocka
Hi I'd like to ask what's the purpose of dmb(osh) in the function arch_wb_cache_pmem in arch/arm64/mm/flush.c? void arch_wb_cache_pmem(void *addr, size_t size) { /* Ensure order against any prior non-cacheable writes */ dmb(osh); __clean_dcache_area_pop(addr, size); } Th

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Dan Williams
On Wed, May 30, 2018 at 6:07 AM, Mikulas Patocka wrote: > > > On Mon, 28 May 2018, Dan Williams wrote: > >> On Mon, May 28, 2018 at 6:32 AM, Mikulas Patocka wrote: >> > >> > >> > On Sat, 26 May 2018, Dan Williams wrote: >> > >> >> On Sat, May 26, 2018 at 12:02 AM, Mikulas Patocka >> >> wrote: >

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mikulas Patocka
On Wed, 30 May 2018, Mike Snitzer wrote: > On Wed, May 30 2018 at 10:09am -0400, > Mikulas Patocka wrote: > > > > > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > > > On Wed, May 30 2018 at 9:33am -0400, > > > Mikulas Patocka wrote: > > > > > > > > > > > > > > > On Wed, 30 May 201

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mike Snitzer
On Wed, May 30 2018 at 10:09am -0400, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > On Wed, May 30 2018 at 9:33am -0400, > > Mikulas Patocka wrote: > > > > > > > > > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > > > > > On Wed, May 30 2018 at 9:21am -0

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mikulas Patocka
On Wed, 30 May 2018, Mike Snitzer wrote: > On Wed, May 30 2018 at 9:33am -0400, > Mikulas Patocka wrote: > > > > > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > > > On Wed, May 30 2018 at 9:21am -0400, > > > Mikulas Patocka wrote: > > > > > > > > > > > > > > > On Wed, 30 May 201

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mike Snitzer
On Wed, May 30 2018 at 9:33am -0400, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > On Wed, May 30 2018 at 9:21am -0400, > > Mikulas Patocka wrote: > > > > > > > > > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > > > > > That is really great news, can yo

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Jeff Moyer
Jeff Moyer writes: > Dan Williams writes: > >> When I read your patch I came away with the impression that ARM had >> not added memcpy_flushcache() yet and you were working around that >> fact. Now that I look, ARM *does* define memcpy_flushcache() and >> you're avoiding it. You use memcpy+arch_

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mikulas Patocka
On Wed, 30 May 2018, Jeff Moyer wrote: > Dan Williams writes: > > > When I read your patch I came away with the impression that ARM had > > not added memcpy_flushcache() yet and you were working around that > > fact. Now that I look, ARM *does* define memcpy_flushcache() and > > you're avoidi

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Jeff Moyer
Dan Williams writes: > When I read your patch I came away with the impression that ARM had > not added memcpy_flushcache() yet and you were working around that > fact. Now that I look, ARM *does* define memcpy_flushcache() and > you're avoiding it. You use memcpy+arch_wb_pmem where arch_wb_pmem o

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mikulas Patocka
On Wed, 30 May 2018, Mike Snitzer wrote: > On Wed, May 30 2018 at 9:21am -0400, > Mikulas Patocka wrote: > > > > > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > > > That is really great news, can you submit an incremental patch that > > > layers ontop of the linux-dm.git 'dm-4.18' br

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mike Snitzer
On Wed, May 30 2018 at 9:21am -0400, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > That is really great news, can you submit an incremental patch that > > layers ontop of the linux-dm.git 'dm-4.18' branch? > > > > Thanks, > > Mike > > I've sent the current vers

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mikulas Patocka
On Wed, 30 May 2018, Mike Snitzer wrote: > That is really great news, can you submit an incremental patch that > layers ontop of the linux-dm.git 'dm-4.18' branch? > > Thanks, > Mike I've sent the current version that I have. I fixed the bugs that were reported here (missing DAX, dm_bufio_cl

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mike Snitzer
On Wed, May 30 2018 at 9:07am -0400, Mikulas Patocka wrote: > > > On Mon, 28 May 2018, Dan Williams wrote: > > > On Mon, May 28, 2018 at 6:32 AM, Mikulas Patocka > > wrote: > > > > > > I measured it (with nvme backing store) and late cache flushing has 12% > > > better performance than eage

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-30 Thread Mikulas Patocka
On Mon, 28 May 2018, Dan Williams wrote: > On Mon, May 28, 2018 at 6:32 AM, Mikulas Patocka wrote: > > > > > > On Sat, 26 May 2018, Dan Williams wrote: > > > >> On Sat, May 26, 2018 at 12:02 AM, Mikulas Patocka > >> wrote: > >> > > >> > > >> > On Fri, 25 May 2018, Dan Williams wrote: > >> >

Re: [PATCH 05/11] filesystem-dax: set page->index

2018-05-30 Thread Jan Kara
On Tue 29-05-18 18:38:41, Dan Williams wrote: > On Wed, May 23, 2018 at 1:40 AM, Jan Kara wrote: > > On Tue 22-05-18 07:39:57, Dan Williams wrote: > >> In support of enabling memory_failure() handling for filesystem-dax > >> mappings, set ->index to the pgoff of the page. The rmap implementation >