RE: [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-31 Thread Elliott, Robert (Persistent Memory)
> Ping on this series. Rob, I think I've addressed all your feedback. > Can you please verify? I haven't tested it, but it reads OK. I'm OK with just extending the valid count for bits set to one for now; we can add a new argument later if a need arises for extending it to express new bits set

Re: [PATCH] nvdimm: preserve read-only setting for pmem devices

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 4:36 PM, Robert Elliott wrote: > The pmem driver don't honor a forced read-only setting for very long: > $ blockdev --setro /dev/pmem0 > $ blockdev --getro /dev/pmem0 > 1 > > followed by various commands like these: > $ blockdev --rereadpt

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 7:24 PM, Dave Chinner wrote: > On Thu, May 31, 2018 at 06:57:33PM -0700, Dan Williams wrote: >> On Thu, May 31, 2018 at 6:26 PM, Dave Chinner wrote: >> > On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: >> >> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dave Chinner
On Thu, May 31, 2018 at 06:57:33PM -0700, Dan Williams wrote: > On Thu, May 31, 2018 at 6:26 PM, Dave Chinner wrote: > > On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > >> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > >> > On Tue, May 29, 2018 at 02:25:10PM

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 6:26 PM, Dave Chinner wrote: > On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: >> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: >> > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: >> > > On Tue, May 29, 2018 at 01:51:01PM

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dave Chinner
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > >

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 4:05 PM, Dave Chinner wrote: > On Thu, May 31, 2018 at 11:26:43AM -0700, Dan Williams wrote: >> On Thu, May 31, 2018 at 10:46 AM, Darrick J. Wong >> wrote: >> > On Thu, May 31, 2018 at 09:29:15AM -0700, Dan Williams wrote: >> >> On Thu, May 31, 2018 at 8:07 AM, Ross

[PATCH] nvdimm: preserve read-only setting for pmem devices

2018-05-31 Thread Robert Elliott
The pmem driver don't honor a forced read-only setting for very long: $ blockdev --setro /dev/pmem0 $ blockdev --getro /dev/pmem0 1 followed by various commands like these: $ blockdev --rereadpt /dev/pmem0 or $ mkfs.ext4 /dev/pmem0 results in this

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Dave Chinner
On Thu, May 31, 2018 at 11:26:43AM -0700, Dan Williams wrote: > On Thu, May 31, 2018 at 10:46 AM, Darrick J. Wong > wrote: > > On Thu, May 31, 2018 at 09:29:15AM -0700, Dan Williams wrote: > >> On Thu, May 31, 2018 at 8:07 AM, Ross Zwisler > >> wrote: > >> > On Thu, May 31, 2018 at 11:27:33AM

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Darrick J. Wong
On Thu, May 31, 2018 at 04:52:06PM -0400, Mike Snitzer wrote: > On Thu, May 31 2018 at 3:13pm -0400, > Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > > On Tue, May 29, 2018

Re: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-31 Thread Dan Williams
On Fri, May 25, 2018 at 1:49 AM, Qi, Fuli wrote: >> As mentioned above this function seems to assume that the only DIMM events to >> send are DIMM health events. It's ok to save other object monitoring to a >> later patch, >> but let's at least support DIMM health >> events: >> >>

Re: [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-31 Thread Ross Zwisler
On Fri, May 25, 2018 at 08:51:22PM +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > > Changes since v3: > > * Updated the text in docs/nvdimm.txt to make it clear that the value > >being passed in on the command line in an integer made up of

Re: [PATCH 05/11] filesystem-dax: set page->index

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 3:08 AM, Jan Kara wrote: [..] >> >> As far as I can see reflink+dax would require teaching kernel code >> >> paths that ->mapping may not be a singular relationship. Something >> >> along the line's of what Jerome was presenting at LSF to create a >> >> special value to

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Mike Snitzer
On Thu, May 31 2018 at 3:13pm -0400, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > > >

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Ross Zwisler
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > >

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 12:13 PM, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: >> On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: >> > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: >> > > From: Dave Jiang >> > > >> > >

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Ross Zwisler
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > >

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Ross Zwisler
On Thu, May 31, 2018 at 11:26:43AM -0700, Dan Williams wrote: > On Thu, May 31, 2018 at 10:46 AM, Darrick J. Wong > wrote: > > On Thu, May 31, 2018 at 09:29:15AM -0700, Dan Williams wrote: > >> On Thu, May 31, 2018 at 8:07 AM, Ross Zwisler > >> wrote: > >> > On Thu, May 31, 2018 at 11:27:33AM

Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Darrick J. Wong
On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > From: Dave Jiang > > > > > > The function return values are confusing with the way the function

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 10:46 AM, Darrick J. Wong wrote: > On Thu, May 31, 2018 at 09:29:15AM -0700, Dan Williams wrote: >> On Thu, May 31, 2018 at 8:07 AM, Ross Zwisler >> wrote: >> > On Thu, May 31, 2018 at 11:27:33AM +0900, Yasunori Goto wrote: >> >> Hello, >> >> >> >> >> >> I would like to

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Darrick J. Wong
On Thu, May 31, 2018 at 09:29:15AM -0700, Dan Williams wrote: > On Thu, May 31, 2018 at 8:07 AM, Ross Zwisler > wrote: > > On Thu, May 31, 2018 at 11:27:33AM +0900, Yasunori Goto wrote: > >> Hello, > >> > >> > >> I would like to know about the Experimental message of Filesystem DAX. > >>

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 8:31 AM, Mikulas Patocka wrote: > > > On Thu, 31 May 2018, Dan Williams wrote: > >> On Thu, May 31, 2018 at 1:19 AM, Mikulas Patocka wrote: >> > >> > >> > On Wed, 30 May 2018, Dan Williams wrote: >> > >> >> > Great find! Thanks for the due diligence. Feel free to add: >>

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 8:07 AM, Ross Zwisler wrote: > On Thu, May 31, 2018 at 11:27:33AM +0900, Yasunori Goto wrote: >> Hello, >> >> >> I would like to know about the Experimental message of Filesystem DAX. >> >> DAX enabled. Warning:

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mikulas Patocka
On Thu, 31 May 2018, Dan Williams wrote: > On Thu, May 31, 2018 at 1:19 AM, Mikulas Patocka wrote: > > > > > > On Wed, 30 May 2018, Dan Williams wrote: > > > >> > Great find! Thanks for the due diligence. Feel free to add: > >> > > >> > Acked-by: Dan Williams > >> > > >> > ...on the

Re: Question about Experimental of Filesystem DAX.

2018-05-31 Thread Ross Zwisler
On Thu, May 31, 2018 at 11:27:33AM +0900, Yasunori Goto wrote: > Hello, > > > I would like to know about the Experimental message of Filesystem DAX. > > DAX enabled. Warning: EXPERIMENTAL, use at your own risk >

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 1:19 AM, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Dan Williams wrote: > >> > Great find! Thanks for the due diligence. Feel free to add: >> > >> > Acked-by: Dan Williams >> > >> > ...on the reworks to unify ARM and x86. >> >> One more note. The side effect of

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mike Snitzer
On Thu, May 31 2018 at 4:16am -0400, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > On Wed, May 30 2018 at 10:09P -0400, > > Mikulas Patocka wrote: > > > > > And what about this? > > > #define WC_MODE_PMEM(wc)((wc)->pmem_mode) > > > >

Re: [PATCH 05/11] filesystem-dax: set page->index

2018-05-31 Thread Jan Kara
On Wed 30-05-18 16:21:33, Dan Williams wrote: > On Wed, May 30, 2018 at 1:13 AM, Jan Kara wrote: > > On Tue 29-05-18 18:38:41, Dan Williams wrote: > >> On Wed, May 23, 2018 at 1:40 AM, Jan Kara wrote: > >> > On Tue 22-05-18 07:39:57, Dan Williams wrote: > >> >> In support of enabling

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mikulas Patocka
On Wed, 30 May 2018, Dan Williams wrote: > > Great find! Thanks for the due diligence. Feel free to add: > > > > Acked-by: Dan Williams > > > > ...on the reworks to unify ARM and x86. > > One more note. The side effect of not using dax_flush() is that you > may end up flushing caches on

Re: [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mikulas Patocka
On Wed, 30 May 2018, Mike Snitzer wrote: > On Wed, May 30 2018 at 10:09P -0400, > Mikulas Patocka wrote: > > > And what about this? > > #define WC_MODE_PMEM(wc)((wc)->pmem_mode) > > > > The code that I had just allowed the compiler to optimize out > >