On 6/27/18 9:37 PM, Linus Torvalds wrote:
> On Wed, Jun 27, 2018 at 7:17 PM Eric Sandeen wrote:
>>
>> What broke is that mmap(MAP_SHARED|MAP_PRIVATE) now succeeds without error,
>> whereas before it rightly returned -EINVAL.
>
> You're still confusing *behavior* with breakage.
>
> Yes. New *beha
> -Original Message-
> From: Dan Williams [mailto:dan.j.willi...@intel.com]
> Sent: Thursday, June 28, 2018 12:53 PM
> To: Qi, Fuli/斉 福利
> Cc: linux-nvdimm
> Subject: Re: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor
>
> On Wed, Jun 27, 2018 at 8:02 PM, Qi, Fuli wrote:
> > Thanks for
On Wed, Jun 27, 2018 at 8:02 PM, Qi, Fuli wrote:
> Thanks for your comments.
>
Thanks for continuing to work through the feedback.
>> > +static struct monitor_dimm *util_dimm_event_filter(struct monitor_dimm
>> > *mdimm,
>> > + const char *__ident)
>> > +{
>> > + char *ident
Thanks for your comments.
> -Original Message-
> From: Dan Williams [mailto:dan.j.willi...@intel.com]
> Sent: Thursday, June 28, 2018 12:09 AM
> To: Qi, Fuli/斉 福利
> Cc: linux-nvdimm
> Subject: Re: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor
>
> On Tue, Jun 26, 2018 at 10:24 PM, QI
On Wed, Jun 27, 2018 at 7:17 PM Eric Sandeen wrote:
>
> What broke is that mmap(MAP_SHARED|MAP_PRIVATE) now succeeds without error,
> whereas before it rightly returned -EINVAL.
You're still confusing *behavior* with breakage.
Yes. New *behavior* is that MAP_SHARED|MAP_PRIVATE is now a valid
thi
On 6/27/18 9:10 PM, Linus Torvalds wrote:
> On Wed, Jun 27, 2018 at 6:45 PM Eric Sandeen wrote:
>>
>> Thus the invalid flag combination of (MAP_SHARED|MAP_PRIVATE) now
>> passes without error, which is a regression.
>
> It's not a regression, it's just new behavior.
>
> "regression" doesn't mean
On Wed, Jun 27, 2018 at 6:45 PM Eric Sandeen wrote:
>
> Thus the invalid flag combination of (MAP_SHARED|MAP_PRIVATE) now
> passes without error, which is a regression.
It's not a regression, it's just new behavior.
"regression" doesn't mean "things changed". It means "something broke".
What br
mmap(2) says the syscall will return EINVAL if "flags contained neither
MAP_PRIVATE or MAP_SHARED, or contained both of these values."
^
However, commit
1c972597 ("mm: introduce MAP_SHARED_VALIDATE ...")
introduced a new flag, MAP_SHARED_V
Hi, Vishal-san,
> We were missing a CONTRIBUTING file to help new contributors follow the
> expected guidelines. Add one that refers to the Linux Kernel for most of
> these things, such as Coding style, Submitting Patches, and the DCO.
>
> Cc: Dan Williams
> Signed-off-by: Vishal Verma
> ---
>
On Wed, Jun 27, 2018 at 4:19 PM, Vishal Verma wrote:
> We were missing a CONTRIBUTING file to help new contributors follow the
> expected guidelines. Add one that refers to the Linux Kernel for most of
> these things, such as Coding style, Submitting Patches, and the DCO.
>
> Cc: Dan Williams
> S
We were missing a CONTRIBUTING file to help new contributors follow the
expected guidelines. Add one that refers to the Linux Kernel for most of
these things, such as Coding style, Submitting Patches, and the DCO.
Cc: Dan Williams
Signed-off-by: Vishal Verma
---
CONTRIBUTING.md | 31 +++
On Wed, Jun 27, 2018 at 04:15:43PM -0600, Vishal Verma wrote:
> The first bullet in the modes description was merged in with the
> previous paragraph in the online version of the man pages. Fix by adding
> a newline before the bulleted list.
>
> Reported-by: Ross Zwisler
> Signed-off-by: Vishal V
The first bullet in the modes description was merged in with the
previous paragraph in the online version of the man pages. Fix by adding
a newline before the bulleted list.
Reported-by: Ross Zwisler
Signed-off-by: Vishal Verma
---
Documentation/ndctl/namespace-description.txt | 1 +
1 file cha
Follow the lead of xfs_break_dax_layouts() and add synchronization between
operations in ext4 which remove blocks from an inode (hole punch, truncate
down, etc.) and pages which are pinned due to DAX DMA operations.
Signed-off-by: Ross Zwisler
Reviewed-by: Jan Kara
---
fs/ext4/ext4.h | 1 +
This series from Dan:
https://lists.01.org/pipermail/linux-nvdimm/2018-March/014913.html
added synchronization between DAX dma and truncate/hole-punch in XFS.
This short series adds analogous support to ext4.
I've added calls to ext4_break_layouts() everywhere that ext4 removes
blocks from an in
Inodes using DAX should only ever have exceptional entries in their page
caches. Make this clear by warning if the iteration in
dax_layout_busy_page() ever sees a non-exceptional entry, and by adding a
comment for the pagevec_release() call which only deals with struct page
pointers.
Signed-off-b
On Fri, Jun 22, 2018 at 10:19:15AM +0200, Jan Kara wrote:
> On Wed 20-06-18 16:15:03, Ross Zwisler wrote:
> > Follow the lead of xfs_break_dax_layouts() and add synchronization between
> > operations in ext4 which remove blocks from an inode (hole punch, truncate
> > down, etc.) and pages which are
On Wed, Jun 27, 2018 at 8:43 AM, Jeff Moyer wrote:
> This is easily triggered from userspace, so let's ratelimit the
> messages.
>
> Signed-off-by: Jeff Moyer
>
> ---
> v2 - fix up all of the dev_info calls in check_vma
Looks good,
Reviewed-by: Dan Williams
This is easily triggered from userspace, so let's ratelimit the
messages.
Signed-off-by: Jeff Moyer
---
v2 - fix up all of the dev_info calls in check_vma
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index de2f8297a210..108c37fca782 100644
--- a/drivers/dax/device.c
+++ b/drivers/da
Hi,
I just wanted to check if you would be interested in a list of Managed
Service Providers (MSPs) and Managed Security Service Providers (MSSPs)?
• Managed Service Providers (MSP’s) – 25,000 unique companies
• Managed Security Service Providers (MSSP’s) – 7,520 unique
compa
On Wed, Jun 27, 2018 at 8:29 AM, Jeff Moyer wrote:
> Dan Williams writes:
>
>> On Wed, Jun 27, 2018 at 8:14 AM, Jeff Moyer wrote:
>>> This is easily triggered from userspace, so let's ratelimit the warning.
>>>
>>> Signed-off-by: Jeff Moyer
>>>
>>> diff --git a/drivers/dax/device.c b/drivers/da
Dan Williams writes:
> On Wed, Jun 27, 2018 at 8:14 AM, Jeff Moyer wrote:
>> This is easily triggered from userspace, so let's ratelimit the warning.
>>
>> Signed-off-by: Jeff Moyer
>>
>> diff --git a/drivers/dax/device.c b/drivers/dax/device.c
>> index de2f8297a210..16ea90615aac 100644
>> ---
On Wed, Jun 27, 2018 at 8:14 AM, Jeff Moyer wrote:
> This is easily triggered from userspace, so let's ratelimit the warning.
>
> Signed-off-by: Jeff Moyer
>
> diff --git a/drivers/dax/device.c b/drivers/dax/device.c
> index de2f8297a210..16ea90615aac 100644
> --- a/drivers/dax/device.c
> +++ b/d
This is easily triggered from userspace, so let's ratelimit the warning.
Signed-off-by: Jeff Moyer
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index de2f8297a210..16ea90615aac 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -196,7 +196,8 @@ static int check_vma(struc
On Tue, Jun 26, 2018 at 10:24 PM, QI Fuli wrote:
> Ndctl monitor is used for monitoring the smart events of nvdimm DIMMs.
> When a smart event fires, monitor will output the notifications which
> include dimm health status and evnet informations to syslog or a
> logfile by setting [--logfile] opti
On Wed, Jun 27, 2018 at 4:03 PM, Dan Williams wrote:
> On Wed, Jun 27, 2018 at 4:23 AM, Yigal Korman wrote:
>> Hi,
>> I'm a bit late on this but I have a question about the original patch -
>> I thought that in order for movnt (movntil, movntiq) to push the data
>> into the persistency domain (AD
On Wed, Jun 27, 2018 at 4:23 AM, Yigal Korman wrote:
> Hi,
> I'm a bit late on this but I have a question about the original patch -
> I thought that in order for movnt (movntil, movntiq) to push the data
> into the persistency domain (ADR),
> one must work with length that is multiple of cachelin
Hi,
I'm a bit late on this but I have a question about the original patch -
I thought that in order for movnt (movntil, movntiq) to push the data
into the persistency domain (ADR),
one must work with length that is multiple of cacheline size,
otherwise the write-combine buffers remain partially
fil
28 matches
Mail list logo
