> -Original Message-
> From: Dan Williams
> Sent: Tuesday, September 04, 2018 11:58 PM
> To: Ocean He
> Cc: Ross Zwisler ; Vishal L Verma
> ; Dave Jiang ; linux-
> nvdimm ; Linux Kernel Mailing List ker...@vger.kernel.org>; Ocean HY1 He
> Subject: [External] Re: [PATCH v2] libnvdimm,
On Fri, Aug 31, 2018 at 11:42:55AM +0200, Jan Kara wrote:
> On Fri 31-08-18 09:38:09, Dave Chinner wrote:
> > On Thu, Aug 30, 2018 at 03:47:32PM -0400, Mikulas Patocka wrote:
> > > You can't support dax on snapshot - if someone maps a block and the block
> > > needs to be moved, then what?
> >
>
亲：
附-件-内-容-请-您-亲-启
4:10:07
圣人择可言而后言，择可行而后行。
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
On Tue, Sep 4, 2018 at 3:47 AM, Ocean He wrote:
> From: Ocean He
>
> There is no need to finish entire loop to execute NDD_ALIASING bit test
> against every nvdimm->flags.
Of course there is. I see nothing stopping someone mixing an NVDIMM
that supports labels with one that doesn't. If anything
On 04/09/18 09:16 AM, Jason Gunthorpe wrote:
>> if (iod->nents) {
>> -dma_unmap_sg(dev->dev, iod->sg, iod->nents, dma_dir);
>> +/* P2PDMA requests do not need to be unmapped */
>> +if (!is_pci_p2pdma_page(sg_page(iod->sg)))
>> +dma_unm
Hi Pankaj,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux-nvdimm/libnvdimm-for-next]
[also build test WARNING on v4.19-rc2 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https:/
On Thu, Aug 30, 2018 at 12:53:49PM -0600, Logan Gunthorpe wrote:
> For P2P requests, we must use the pci_p2pmem_map_sg() function
> instead of the dma_map_sg functions.
>
> With that, we can then indicate PCI_P2P support in the request queue.
> For this, we create an NVME_F_PCI_P2P flag which tell
Hi Pankaj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v4.19-rc2 next-20180903]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.
From: Ocean He
There is no need to finish entire loop to execute NDD_ALIASING bit test
against every nvdimm->flags. In practice, all the nd_mapping->nvdimm
have the same flags. So it's safe to return ND_DEVICE_NAMESPACE_PMEM
if the NDD_ALIASING bit is found inside the loop, while saving a few
cpu
