Re: [PATCH 0/3] libnvdimm: reset seeds for next namespace creation

2018-09-10 Thread Dan Williams
On Sun, Sep 9, 2018 at 11:21 PM, Ocean He wrote: > From: Ocean He > > When pmem namespaces created are smaller than section size twice, the > second creation would fail and meanwhile there is a kernel call trace > which comes from commit 15d36fecd0bdc7510b70 ("mm: disallow mappings that >

Re: [PATCH 3/3] libnvdimm, region_devs: reset related seeds when fail to create namespace

2018-09-10 Thread kbuild test robot
Hi Ocean, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux-nvdimm/libnvdimm-for-next] [also build test WARNING on v4.19-rc3 next-20180910] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[RFC PATCH] libnvdimm, region_devs: nd_region_detach_and_reset() can be static

2018-09-10 Thread kbuild test robot
Fixes: 39ac5d361db2 ("libnvdimm, region_devs: reset related seeds when fail to create namespace") Signed-off-by: kbuild test robot --- region_devs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index

Re: [PATCH 4/4] nvdimm: Trigger the device probe on a cpu local to the device

2018-09-10 Thread Alexander Duyck
On Mon, Sep 10, 2018 at 4:44 PM Alexander Duyck wrote: > > From: Alexander Duyck > > This patch is based off of the pci_call_probe function used to initialize > PCI devices. The general idea here is to move the probe call to a location > that is local to the memory being initialized. By doing

Re: [PATCH 1/4] mm: Provide kernel parameter to allow disabling page init poisoning

2018-09-10 Thread Alexander Duyck
On Mon, Sep 10, 2018 at 4:43 PM Alexander Duyck wrote: > > From: Alexander Duyck > > On systems with a large amount of memory it can take a significant amount > of time to initialize all of the page structs with the PAGE_POISON_PATTERN > value. I have seen it take over 2 minutes to initialize a

[PATCH 1/4] mm: Provide kernel parameter to allow disabling page init poisoning

2018-09-10 Thread Alexander Duyck
From: Alexander Duyck On systems with a large amount of memory it can take a significant amount of time to initialize all of the page structs with the PAGE_POISON_PATTERN value. I have seen it take over 2 minutes to initialize a system with over 12GB of RAM. In order to work around the issue I

[PATCH 2/4] mm: Create non-atomic version of SetPageReserved for init use

2018-09-10 Thread Alexander Duyck
From: Alexander Duyck It doesn't make much sense to use the atomic SetPageReserved at init time when we are using memset to clear the memory and manipulating the page flags via simple "&=" and "|=" operations in __init_single_page. This patch adds a non-atomic version __SetPageReserved that can

[PATCH 3/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-10 Thread Alexander Duyck
From: Alexander Duyck The ZONE_DEVICE pages were being initialized in two locations. One was with the memory_hotplug lock held and another was outside of that lock. The problem with this is that it was nearly doubling the memory initialization time. Instead of doing this twice, once while

[PATCH 0/4] Address issues slowing persistent memory initialization

2018-09-10 Thread Alexander Duyck
This patch set is meant to be a v3 to my earlier patch set "Address issues slowing memory init"[1]. However I have added 2 additional patches to address issues seen in which NVDIMM memory was slow to initialize especially on systems with multiple NUMA nodes. Since v2 of the patch set I have

[PATCH] dax: add missing address_space_operations for device dax

2018-09-10 Thread Dave Jiang
With address_space_operations missing for device dax, namely the .set_page_dirty, we hit a kernel warning when running destructive ndctl unit test: make TESTS=device-dax check WARNING: CPU: 3 PID: 7380 at fs/buffer.c:581 __set_page_dirty+0xb1/0xc0 Setting address_space_operations to

Re: [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch

2018-09-10 Thread Eric Sandeen
On 8/7/18 3:45 AM, Jan Kara wrote: > On Fri 27-07-18 10:28:51, Ross Zwisler wrote: >> + fsdevel and the xfs list. >> >> On Wed, Jul 25, 2018 at 4:28 PM Ross Zwisler >> wrote: >>> On Wed, Jul 11, 2018 at 10:17:41AM +0200, Jan Kara wrote: On Tue 10-07-18 13:10:29, Ross Zwisler wrote: >

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-09-10 Thread Alexander Duyck
On Mon, Sep 10, 2018 at 12:06 PM Dan Williams wrote: > > [ adding Alex ] > > On Tue, Jul 24, 2018 at 12:29 AM, Michal Hocko wrote: > > On Mon 23-07-18 09:15:32, Dave Hansen wrote: > >> On 07/23/2018 04:09 AM, Michal Hocko wrote: > >> > On Thu 19-07-18 11:41:10, Dave Hansen wrote: > >> >> Are you

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-09-10 Thread Dan Williams
[ adding Alex ] On Tue, Jul 24, 2018 at 12:29 AM, Michal Hocko wrote: > On Mon 23-07-18 09:15:32, Dave Hansen wrote: >> On 07/23/2018 04:09 AM, Michal Hocko wrote: >> > On Thu 19-07-18 11:41:10, Dave Hansen wrote: >> >> Are you looking for the actual end-user reports? This was more of a >> >>

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-10 Thread Logan Gunthorpe
On 10/09/18 10:41 AM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 03:03:18PM -0600, Logan Gunthorpe wrote: >> There is no special p2p submission process. In the nvme-of case we are >> using the existing process and with the code in blk-core it didn't >> change it's process at all.

RE: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Kani, Toshi > Sent: Monday, September 10, 2018 9:52 AM > To: j...@suse.cz > Cc: linux-fsde...@vger.kernel.org; linux-nvdimm@lists.01.org > Subject: Re: open sets ext4_da_aops for DAX

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-10 Thread Christoph Hellwig
On Wed, Sep 05, 2018 at 03:03:18PM -0600, Logan Gunthorpe wrote: > There is no special p2p submission process. In the nvme-of case we are > using the existing process and with the code in blk-core it didn't > change it's process at all. Creating a helper will create one and I can > look at making

Re: [PATCH v2 1/2] ext4: Close race between direct IO and ext4_break_layouts()

2018-09-10 Thread Eric Sandeen
On 8/8/18 12:25 PM, Dave Jiang wrote: > From: Ross Zwisler > > If the refcount of a page is lowered between the time that it is returned > by dax_busy_page() and when the refcount is again checked in > ext4_break_layouts() => ___wait_var_event(), the waiting function > ext4_wait_dax_page() will

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Jan Kara
On Fri 07-09-18 21:23:19, Kani, Toshi wrote: > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > mounted ext4 files. Looking at open() path: > > New file > > lookup_open > ext4_create > __ext4_new_inode > ext4_set_inode_flags // Set S_DAX flag >

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Dan Williams
On Mon, Sep 10, 2018 at 7:21 AM, Kani, Toshi wrote: > On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote: >> "Kani, Toshi" writes: >> >> > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX >> > mounted ext4 files. Looking at open() path: >> >> Eek. How did you notice this? >

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Kani, Toshi
On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote: > "Kani, Toshi" writes: > > > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > > mounted ext4 files. Looking at open() path: > > Eek. How did you notice this? I tested sync path on DAX files to see if it flushes

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Jeff Moyer
"Kani, Toshi" writes: > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > mounted ext4 files. Looking at open() path: Eek. How did you notice this? -Jeff ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Your Mailbox Will Be Blocked(Last Warning)!

2018-09-10 Thread SERVER_ADMIN_TEAM
Please confirm your email address Dear Valid user, We are undergoing maintenance therefore all accounts must be updated to avoid suspension, this is to reduce the number of dormant accounts. Failure to this

[PATCH 2/3] libnvdimm, namespace_devs: add function nd_region_reset_ns_seed for namespace seed reset

2018-09-10 Thread Ocean He
From: Ocean He During runtime, if a namespace seed is used for new namespace creation but fail, then it needs to be reset for next namespace creation. Add function nd_region_reset_ns_seed for namespace seed reset and declare it in nd-core.h. Signed-off-by: Ocean He ---

[PATCH 3/3] libnvdimm, region_devs: reset related seeds when fail to create namespace

2018-09-10 Thread Ocean He
From: Ocean He During runtime, namespace creation may fail if blocked by commit 15d36fecd0bdc7510b70 ("mm: disallow mappings that conflict for devm_memremap_pages()"). To ensure pfn_seed/dax_seed and namespace_seed are ready for next namespace creation, here to do detach and reset.

[PATCH 1/3] libnvdimm, claim: remove static attribute of nd_detach_and_reset

2018-09-10 Thread Ocean He
From: Ocean He The function nd_detach_and_reset needs to be called externally, so remove the static attribute and declare it in nd-core.h. Signed-off-by: Ocean He --- drivers/nvdimm/claim.c | 2 +- drivers/nvdimm/nd-core.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 0/3] libnvdimm: reset seeds for next namespace creation

2018-09-10 Thread Ocean He
From: Ocean He When pmem namespaces created are smaller than section size twice, the second creation would fail and meanwhile there is a kernel call trace which comes from commit 15d36fecd0bdc7510b70 ("mm: disallow mappings that conflict for devm_memremap_pages()"). [ cut