Re: [PATCH V5 4/4] kvm: add a check if pfn is from NVDIMM pmem.

2018-09-18 Thread Dan Williams
On Fri, Sep 7, 2018 at 2:25 AM Zhang Yi wrote: > > For device specific memory space, when we move these area of pfn to > memory zone, we will set the page reserved flag at that time, some of > these reserved for device mmio, and some of these are not, such as > NVDIMM pmem. > > Now, we map these

Re: [PATCH V4 3/4] mm: add a function to differentiate the pages is from DAX device memory

2018-09-18 Thread Pankaj Gupta
> > DAX driver hotplug the device memory and move it to memory zone, these > pages will be marked reserved flag, however, some other kernel componet > will misconceive these pages are reserved mmio (ex: we map these dev_dax > or fs_dax pages to kvm for DIMM/NVDIMM backend). Together with the

Re: [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio

2018-09-18 Thread Pankaj Gupta
Hello Yi, > Any comments? > > Hi Pankaj and Paolo, I am just helping with the review. Paolo & Dan probably will decide. Thanks, Pankaj > > Can we Queue this to merge list since there no other comments last 2 > weeks? > > Regards > Yi. > > On 2018-09-08 at 02:03:02 +0800, Zhang Yi wrote:

Re: [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio

2018-09-18 Thread Yi Zhang
Any comments? Hi Pankaj and Paolo, Can we Queue this to merge list since there no other comments last 2 weeks? Regards Yi. On 2018-09-08 at 02:03:02 +0800, Zhang Yi wrote: > For device specific memory space, when we move these area of pfn to > memory zone, we will set the page reserved flag at

Re: [PATCH v2] libnvdimm, pfn: during init, clear errors in the metadata area

2018-09-18 Thread Dan Williams
On Tue, Sep 18, 2018 at 4:49 PM Vishal Verma wrote: > > If there are badblocks present in the 'struct page' area for pfn > namespaces, until now, the only way to clear them has been to force the > namespace into raw mode, clear the errors, and re-enable the fsdax mode. > This is clunky, given

[PATCH v2] libnvdimm, pfn: during init, clear errors in the metadata area

2018-09-18 Thread Vishal Verma
If there are badblocks present in the 'struct page' area for pfn namespaces, until now, the only way to clear them has been to force the namespace into raw mode, clear the errors, and re-enable the fsdax mode. This is clunky, given that it should be easy enough for the pfn driver to do the same.

答复:如何慧眼识英才,找到更适合的人才

2018-09-18 Thread 史�w聪
* Message-ID: <375512375512375512375512375512375512375512375512375512375512375512375512375512> * From: .linux-nvdimm. * To: Ç×£¡¡­¡­ Çë¡­¡­ ²é ¡­¡­ÔÄ ¡­¡­¸½¡­¡­ ¼þ 2018-09-19 07:13:11 ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Re: [PATCH] libnvdimm, pfn: during init, clear errors in the metadata area

2018-09-18 Thread Verma, Vishal L
On Tue, 2018-09-18 at 13:53 -0700, Dan Williams wrote: > On Tue, Sep 18, 2018 at 1:08 PM Vishal Verma wrote: > > > > If there are badblocks present in the 'struct page' area for pfn > > namespaces, until now, the only way to clear them has been to force the > > namespace into raw mode, clear

Re: [PATCH] libnvdimm, pfn: during init, clear errors in the metadata area

2018-09-18 Thread Dan Williams
On Tue, Sep 18, 2018 at 1:08 PM Vishal Verma wrote: > > If there are badblocks present in the 'struct page' area for pfn > namespaces, until now, the only way to clear them has been to force the > namespace into raw mode, clear the errors, and re-enable the fsdax mode. > This is clunky, given

[ndctl PATCH v3] ndctl: Introduce dirty-dimm command

2018-09-18 Thread Dan Williams
Some DIMMs provide a facility to track dirty-shutdown events. The counter only rolls forward after the OS sets a latch. This allows the agent tracking dirty shutdowns to ignore events that occur while the capacity has not been written. For these DIMMs dirty-dimm will trigger the counter to roll to

[ndctl PATCH] ndctl, test: add a new unit test pfn metadata error clearing

2018-09-18 Thread Vishal Verma
The pfn driver lacked a way to clear badblocks in the volatile struct page area, but this is expected to be fixed for v4.20. Add a unit test that creates an fsdax namespace, forces it to raw mode, injects errors to the metadata area, and converts it back to fsdax. For a kernel with the error

[ndctl PATCH v2 2/3] ndctl: Revert "ndctl, intel: Fallback to smart cached shutdown_count"

2018-09-18 Thread Dan Williams
Static device attribute data, if it needs to be cached and exported to unprivileged userspace, should live in sysfs. Cc: Keith Busch Cc: Vishal Verma Signed-off-by: Dan Williams --- ndctl/lib/intel.c| 41 - ndctl/lib/libndctl.c |6 +-

[ndctl PATCH v2 0/3] ndctl: Remove udev rule for latch and dirty-shutdown-count

2018-09-18 Thread Dan Williams
Changes since v1: * Add an error message for the not supported case (Vishal) * Asciidoctor format fixup --- The latch needs to be coordinated with writes to the namespace and that makes it not suitable as a dimm-add-event udev rule. Additionally, the dirty-shutdown-count is something that can

[ndctl PATCH v2 1/3] ndctl: Introduce dirty-dimm command

2018-09-18 Thread Dan Williams
Some DIMMs provide a facility to track dirty-shutdown events. The counter only rolls forward after the OS sets a latch. This allows the agent tracking dirty shutdowns to ignore events that occur while the capacity has not been written. For these DIMMs dirty-dimm will trigger the counter to roll to

[ndctl PATCH v2 3/3] ndctl: Revert "ndctl: Create ndctl udev rules for dirty shutdown"

2018-09-18 Thread Dan Williams
With the introduction of the 'ndctl dirty-dimm' command, environments that choose to implement dirty-shutdown mitigation can use 'dirty-dimm nmemX' and 'list --dimm --health nmemX' to acknowledge and retrieve these details. However, it should be noted that this is not the default. If the platform

[PATCH] libnvdimm, pfn: during init, clear errors in the metadata area

2018-09-18 Thread Vishal Verma
If there are badblocks present in the 'struct page' area for pfn namespaces, until now, the only way to clear them has been to force the namespace into raw mode, clear the errors, and re-enable the fsdax mode. This is clunky, given that it should be easy enough for the pfn driver to do the same.

Re: [ndctl PATCH 1/3] ndctl: Introduce dirty-dimm command

2018-09-18 Thread Dan Williams
On Tue, Sep 18, 2018 at 12:15 PM Verma, Vishal L wrote: > > > On Mon, 2018-09-17 at 22:49 -0700, Dan Williams wrote: > > Some DIMMs provide a facility to track dirty-shutdown events. The > > counter only rolls forward after the OS sets a latch. This allows the > > agent tracking dirty shutdowns

Re: [ndctl PATCH 1/3] ndctl: Introduce dirty-dimm command

2018-09-18 Thread Verma, Vishal L
On Mon, 2018-09-17 at 22:49 -0700, Dan Williams wrote: > Some DIMMs provide a facility to track dirty-shutdown events. The > counter only rolls forward after the OS sets a latch. This allows the > agent tracking dirty shutdowns to ignore events that occur while the > capacity has not been

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-18 Thread Darren Hart
On Fri, Sep 14, 2018 at 09:57:48PM +0100, Al Viro wrote: > On Fri, Sep 14, 2018 at 01:35:06PM -0700, Darren Hart wrote: > > > Acked-by: Darren Hart (VMware) > > > > As for a longer term solution, would it be possible to init fops in such > > a way that the compat_ioctl call defaults to

[ndctl PATCH 3/3] ndctl: Revert "ndctl: Create ndctl udev rules for dirty shutdown"

2018-09-18 Thread Dan Williams
With the introduction of the 'ndctl dirty-dimm' command, environments that choose to implement dirty-shutdown mitigation can use 'dirty-dimm nmemX' and 'list --dimm --health nmemX' to acknowledge and retrieve these details. However, it should be noted that this is not the default. If the platform

[ndctl PATCH 0/3] ndctl: Remove udev rule for latch and dirty-shutdown-count

2018-09-18 Thread Dan Williams
The latch needs to be coordinated with writes to the namespace and that makes it not suitable as a dimm-add-event udev rule. Additionally, the dirty-shutdown-count is something that can live in sysfs alongside the other health state flags in /sys/.../nmemX/nfit. Otherwise, calling any of the

[ndctl PATCH 1/3] ndctl: Introduce dirty-dimm command

2018-09-18 Thread Dan Williams
Some DIMMs provide a facility to track dirty-shutdown events. The counter only rolls forward after the OS sets a latch. This allows the agent tracking dirty shutdowns to ignore events that occur while the capacity has not been written. For these DIMMs dirty-dimm will trigger the counter to roll to

[ndctl PATCH 2/3] ndctl: Revert "ndctl, intel: Fallback to smart cached shutdown_count"

2018-09-18 Thread Dan Williams
Static device attribute data, if it needs to be cached and exported to unprivileged userspace, should live in sysfs. Cc: Keith Busch Cc: Vishal Verma Signed-off-by: Dan Williams --- ndctl/lib/intel.c| 41 - ndctl/lib/libndctl.c |6 +-