Re: [PATCH V2 1/1] device-dax: check for vma range while dax_mmap.

2018-12-12 Thread Yi Zhang
On 2018-12-10 at 16:10:31 -0800, Dan Williams wrote: > On Tue, Aug 21, 2018 at 12:38 AM Yi Zhang wrote: > > > > On 2018-08-20 at 12:50:31 -0700, Dave Jiang wrote: > > > > > > > > > On 08/20/2018 10:53 AM, Verma, Vishal L wrote: > > > > > > > > On Mon, 2018-08-13 at 20:02 +0800, Zhang Yi wrote: >

[PATCH AUTOSEL 4.19 61/73] acpi/nfit: Fix user-initiated ARS to be "ARS-long" rather than "ARS-short"

2018-12-12 Thread Sasha Levin
From: Dan Williams [ Upstream commit b5fd2e00a60248902315fb32210550ac3cb9f44c ] A "short" ARS (address range scrub) instructs the platform firmware to return known errors. In contrast, a "long" ARS instructs platform firmware to arrange every data address on the DIMM to be read / checked for

[driver-core PATCH v9 8/9] libnvdimm: Schedule device registration on node local to the device

2018-12-12 Thread Alexander Duyck
Force the device registration for nvdimm devices to be closer to the actual device. This is achieved by using either the NUMA node ID of the region, or of the parent. By doing this we can have everything above the region based on the region, and everything below the region based on the nvdimm bus.

[driver-core PATCH v9 9/9] driver core: Rewrite test_async_driver_probe to cover serialization and NUMA affinity

2018-12-12 Thread Alexander Duyck
The current async_probe test code is only testing one device allocated prior to driver load and only loading one device afterwards. Instead of doing things this way it makes much more sense to load one device per CPU in order to actually stress the async infrastructure. By doing this we should see

[driver-core PATCH v9 7/9] PM core: Use new async_schedule_dev command

2018-12-12 Thread Alexander Duyck
Use the device specific version of the async_schedule commands to defer various tasks related to power management. By doing this we should see a slight improvement in performance as any device that is sensitive to latency/locality in the setup will now be initializing on the node closest to the

[driver-core PATCH v9 5/9] async: Add support for queueing on specific NUMA node

2018-12-12 Thread Alexander Duyck
Introduce four new variants of the async_schedule_ functions that allow scheduling on a specific NUMA node. The first two functions are async_schedule_near and async_schedule_near_domain end up mapping to async_schedule and async_schedule_domain, but provide NUMA node specific functionality. They

[driver-core PATCH v9 6/9] driver core: Attach devices on CPU local to device node

2018-12-12 Thread Alexander Duyck
Call the asynchronous probe routines on a CPU local to the device node. By doing this we should be able to improve our initialization time significantly as we can avoid having to access the device from a remote node which may introduce higher latency. For example, in the case of initializing

[driver-core PATCH v9 0/9] Add NUMA aware async_schedule calls

2018-12-12 Thread Alexander Duyck
This patch set provides functionality that will help to improve the locality of the async_schedule calls used to provide deferred initialization. This patch set originally started out focused on just the one call to async_schedule_domain in the nvdimm tree that was being used to defer the

[driver-core PATCH v9 2/9] device core: Consolidate locking and unlocking of parent and device

2018-12-12 Thread Alexander Duyck
Try to consolidate all of the locking and unlocking of both the parent and device when attaching or removing a driver from a given device. To do that I first consolidated the lock pattern into two functions __device_driver_lock and __device_driver_unlock. After doing that I then created functions

[driver-core PATCH v9 4/9] workqueue: Provide queue_work_node to queue work near a given NUMA node

2018-12-12 Thread Alexander Duyck
Provide a new function, queue_work_node, which is meant to schedule work on a "random" CPU of the requested NUMA node. The main motivation for this is to help assist asynchronous init to better improve boot times for devices that are local to a specific node. For now we just default to the first

[driver-core PATCH v9 1/9] driver core: Establish order of operations for device_add and device_del via bitflag

2018-12-12 Thread Alexander Duyck
Add an additional bit flag to the device struct named "dead". This additional flag provides a guarantee that when a device_del is executed on a given interface an async worker will not attempt to attach the driver following the earlier device_del call. Previously this guarantee was not present

[driver-core PATCH v9 3/9] driver core: Probe devices asynchronously instead of the driver

2018-12-12 Thread Alexander Duyck
Probe devices asynchronously instead of the driver. This results in us seeing the same behavior if the device is registered before the driver or after. This way we can avoid serializing the initialization should the driver not be loaded until after the devices have already been added. The

Re: Snapshot target and DAX-capable devices

2018-12-12 Thread Mike Snitzer
On Wed, Dec 12 2018 at 4:15pm -0500, Theodore Y. Ts'o wrote: > On Wed, Dec 12, 2018 at 12:50:47PM -0500, Mike Snitzer wrote: > > On Wed, Dec 12 2018 at 11:12am -0500, > > Christoph Hellwig wrote: > > > > > Does it really make sense to enhance dm-snapshot? I thought all serious > > > users of

Re: Snapshot target and DAX-capable devices

2018-12-12 Thread Theodore Y. Ts'o
On Wed, Dec 12, 2018 at 12:50:47PM -0500, Mike Snitzer wrote: > On Wed, Dec 12 2018 at 11:12am -0500, > Christoph Hellwig wrote: > > > Does it really make sense to enhance dm-snapshot? I thought all serious > > users of snapshots had moved on to dm-thinp? > > There are cases where dm-snapshot

Re: Snapshot target and DAX-capable devices

2018-12-12 Thread Kani, Toshi
On Wed, 2018-12-12 at 12:50 -0500, Mike Snitzer wrote: > On Wed, Dec 12 2018 at 11:12am -0500, > Christoph Hellwig wrote: > > > Does it really make sense to enhance dm-snapshot? I thought all serious > > users of snapshots had moved on to dm-thinp? > > There are cases where dm-snapshot is

Re: Snapshot target and DAX-capable devices

2018-12-12 Thread Mike Snitzer
On Wed, Dec 12 2018 at 11:12am -0500, Christoph Hellwig wrote: > Does it really make sense to enhance dm-snapshot? I thought all serious > users of snapshots had moved on to dm-thinp? There are cases where dm-snapshot is still useful for people. But those are very niche users. I'm not

Re: Snapshot target and DAX-capable devices

2018-12-12 Thread Christoph Hellwig
Does it really make sense to enhance dm-snapshot? I thought all serious users of snapshots had moved on to dm-thinp? ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: Snapshot target and DAX-capable devices

2018-12-12 Thread Huaisheng Ye
On Fri, 31 Aug 2018 17:42:55 +0800 Jan Kara wrote > On Fri 31-08-18 09:38:09, Dave Chinner wrote: > > On Thu, Aug 30, 2018 at 03:47:32PM -0400, Mikulas Patocka wrote: > > > > > > > > > On Thu, 30 Aug 2018, Jeff Moyer wrote: > > > > > > > Mike Snitzer writes: > > > >

Re: [PATCH v13 04/17] keys-encrypted: add nvdimm key format type to encrypted keys

2018-12-12 Thread Mimi Zohar
On Tue, 2018-12-11 at 13:25 -0700, Dave Jiang wrote: > Adding nvdimm key format type to encrypted keys in order to limit the size > of the key to 32bytes. > > Signed-off-by: Dave Jiang > Signed-off-by: Dan Williams Acked-by: Mimi Zohar > --- >