When creating nd_namespace_blk, its uuid is copied from nd_label->uuid.
In case the memory allocation fails, it goes to the error branch.
This check is better to be done immediately after memory allocation,
while current implementation does this after assigning claim_class.
This patch moves the
On Mon, Jan 14, 2019 at 12:07 PM Dave Jiang wrote:
>
> Add support to secure erase to libndctl and also command line option
> of "sanitize-dimm" for ndctl. This will initiate the request to crypto
> erase a DIMM.
>
> Signed-off-by: Dave Jiang
> ---
> Documentation/ndctl/Makefile.am
On Mon, Jan 14, 2019 at 12:07 PM Dave Jiang wrote:
>
> Add support for freeze security to libndctl and also command line option
> of "freeze-security" for ndctl. This will lock the ability to make changes
> to the NVDIMM security.
>
> Signed-off-by: Dave Jiang
> ---
>
On Mon, Jan 14, 2019 at 12:07 PM Dave Jiang wrote:
>
> Add support for disable security to libndctl and also command line option
> of "disable-passphrase" for ndctl. This provides a way to disable security
> on the nvdimm.
>
> Signed-off-by: Dave Jiang
> ---
> Documentation/ndctl/Makefile.am
Some comments below...
On Mon, Jan 14, 2019 at 12:06 PM Dave Jiang wrote:
>
> Add API call for triggering sysfs knob to update the security for a DIMM
> in libndctl. Also add the ndctl "update-passphrase" to trigger the
> operation.
>
> Signed-off-by: Dave Jiang
> ---
>
In __nfit_mem_init(), one nfit_mem will be created in case we can't find
one nfit_mem with matched device_handle. The variable *found* indicates
this research result.
If we found one, variable *found* is set to non-NULL and variable
*nfit_mem* already points to the data structure we want to set
Some comments below:
On Mon, Jan 14, 2019 at 12:07 PM Dave Jiang wrote:
>
> Adding libndctl API call for retrieving security state for a DIMM and also
> adding support to ndctl list for displaying security state.
>
> Signed-off-by: Dave Jiang
> ---
> Documentation/ndctl/ndctl-list.txt |8
On 01/14, Dave Jiang wrote:
> Add unit test for security enable, disable, update, erase, unlock, and
> freeze.
>
> Signed-off-by: Dave Jiang
> ---
> test/Makefile.am |4 +
> test/security.sh | 197
> ++
> 2 files changed, 201
Dan Williams writes:
> Changes since v2 [1]:
> * Don't allow ND_CMD_CALL to bypass dsm_mask restrictions (Jeff)
>
> [1]: https://lists.01.org/pipermail/linux-nvdimm/2019-January/019498.html
>
> ---
>
> One last resend to make sure all the last bits of thrash have settled.
LGTM.
Thanks!
Jeff
The _DSM function number validation only happens to succeed when the
generic Linux command number translation corresponds with a
DSM-family-specific function number. This breaks NVDIMM-N
implementations that correctly implement _LSR, _LSW, and _LSI, but do
not happen to publish support for DSM
In preparation for using function number 0 as an error value, prevent it
from being considered a valid function value by acpi_nfit_ctl().
Cc:
Cc: stuart hayes
Fixes: e02fb7264d8a ("nfit: add Microsoft NVDIMM DSM command set...")
Reported-by: Jeff Moyer
Reviewed-by: Jeff Moyer
Signed-off-by:
Changes since v2 [1]:
* Don't allow ND_CMD_CALL to bypass dsm_mask restrictions (Jeff)
[1]: https://lists.01.org/pipermail/linux-nvdimm/2019-January/019498.html
---
One last resend to make sure all the last bits of thrash have settled.
Quote patch2 changelog:
The _DSM function number
On 1/15/19 2:56 PM, Elliott, Robert (Persistent Memory) wrote:
>
>
>> -Original Message-
>> From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of
>> Dave Jiang
>> Sent: Thursday, December 13, 2018 5:49 PM
>> To: dan.j.willi...@intel.com
>> Cc:
> -Original Message-
> From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of
> Dave Jiang
> Sent: Thursday, December 13, 2018 5:49 PM
> To: dan.j.willi...@intel.com
> Cc: linux-nvdimm@lists.01.org
> Subject: [PATCH v15 07/16] acpi/nfit, libnvdimm: Add unlock of
On Tue, Jan 15, 2019 at 12:39 PM Jeff Moyer wrote:
>
> Dan Williams writes:
>
> > On Tue, Jan 15, 2019 at 6:16 AM Jeff Moyer wrote:
> >>
> >> Dan Williams writes:
> >>
> >> > Changes since v1 [1]:
> >> > * Include another patch make sure that function-number zero can be
> >> > safely used as
On Tue, Jan 15, 2019 at 12:35:06AM -0500, Pankaj Gupta wrote:
>
> > > > On Mon, Jan 14, 2019 at 02:15:40AM -0500, Pankaj Gupta wrote:
> > > > >
> > > > > > > Until you have images (and hence host page cache) shared between
> > > > > > > multiple guests. People will want to do this, because it
Dan Williams writes:
> On Tue, Jan 15, 2019 at 6:16 AM Jeff Moyer wrote:
>>
>> Dan Williams writes:
>>
>> > Changes since v1 [1]:
>> > * Include another patch make sure that function-number zero can be
>> > safely used as an invalid function number (Jeff)
>> > * Add a comment clarifying why
The UEFI 2.7 specification sets expectations that the 'updating' flag is
eventually cleared. To date, the libnvdimm core has never adhered to
that protocol. The policy of the core matches the policy of other
multi-device info-block formats like MD-Software-RAID that expect
administrator
On Tue, Jan 15, 2019 at 10:26 AM Dave Jiang wrote:
>
> The input parameter should be enum nvdimm_passphrase_type instead of bool
> for selection of master/user for selection of extended master passphrase
> state or the regular user passphrase state.
>
> Fixes: 89fa9d8ea7bdf ("acpi/nfit,
The input parameter should be enum nvdimm_passphrase_type instead of bool
for selection of master/user for selection of extended master passphrase
state or the regular user passphrase state.
Fixes: 89fa9d8ea7bdf ("acpi/nfit, libnvdimm/security: add Intel DSM 1.8 master
passphrase support")
On Tue, Jan 15, 2019 at 6:16 AM Jeff Moyer wrote:
>
> Dan Williams writes:
>
> > Changes since v1 [1]:
> > * Include another patch make sure that function-number zero can be
> > safely used as an invalid function number (Jeff)
> > * Add a comment clarifying why zero is an invalid function
Dan Williams writes:
> Changes since v1 [1]:
> * Include another patch make sure that function-number zero can be
> safely used as an invalid function number (Jeff)
> * Add a comment clarifying why zero is an invalid function number (Jeff)
> * Pass nfit_mem to cmd_to_func() (Jeff)
> * Collect
-
-
-
-
-
23 matches
Mail list logo
