RE: [PATCH] nfit: Fix nfit_intel_shutdown_status() command submission

2019-01-28 Thread Dexuan Cui
> From: Dan Williams > Sent: Monday, January 28, 2019 9:22 PM > To: linux-nvdimm@lists.01.org > Cc: sta...@vger.kernel.org; Dexuan Cui ; > linux-ker...@vger.kernel.org > Subject: [PATCH] nfit: Fix nfit_intel_shutdown_status() command submission > > The implementation is broken in all the ways the

[PATCH] nfit: Fix nfit_intel_shutdown_status() command submission

2019-01-28 Thread Dan Williams
The implementation is broken in all the ways the unit test did not touch: 1/ The local definition of in_buf and in_obj violated C99 initializer expectations for zeroing. By only initializing 2 out of the three struct members the compiler was free to zero-initialize the remaining entry eve

Re: [PATCH 2/5] mm/resource: move HMM pr_debug() deeper into resource code

2019-01-28 Thread Michael Ellerman
Dave Hansen writes: > On 1/25/19 1:18 PM, Bjorn Helgaas wrote: >> On Thu, Jan 24, 2019 at 5:21 PM Dave Hansen >> wrote: >>> diff -puN kernel/resource.c~move-request_region-check kernel/resource.c >>> --- a/kernel/resource.c~move-request_region-check 2019-01-24 >>> 15:13:14.453199539 -0800

Re: [PATCH 1/5] mm/resource: return real error codes from walk failures

2019-01-28 Thread Michael Ellerman
Dave Hansen writes: > On 1/25/19 1:02 PM, Bjorn Helgaas wrote: >>> @@ -453,7 +453,7 @@ int walk_system_ram_range(unsigned long >>> unsigned long flags; >>> struct resource res; >>> unsigned long pfn, end_pfn; >>> - int ret = -1; >>> + int ret = -EINVAL; >> Can y

[PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-01-28 Thread Dexuan Cui
Add the Hyper-V _DSM command set to the white list of NVDIMM command sets. This command set is documented at http://www.uefi.org/RFIC_LIST (see "Virtual NVDIMM 0x1901"). Thanks Dan Williams for writing the comment change. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- Changes in

Re: [PATCH v3 1/6] libndctl: Use the supported_alignment attribute

2019-01-28 Thread Verma, Vishal L
On Tue, 2019-01-29 at 10:20 +1100, Oliver wrote: > On Tue, Jan 29, 2019 at 10:15 AM Verma, Vishal L > wrote: > > > > On Tue, 2019-01-29 at 10:11 +1100, Oliver wrote: > > > On Thu, Jan 24, 2019 at 6:32 AM Verma, Vishal L > > > wrote: > > > > On Wed, 2019-01-16 at 20:49 +1100, Oliver O'Halloran

Re: [PATCH v3 1/6] libndctl: Use the supported_alignment attribute

2019-01-28 Thread Oliver
On Tue, Jan 29, 2019 at 10:15 AM Verma, Vishal L wrote: > > > On Tue, 2019-01-29 at 10:11 +1100, Oliver wrote: > > On Thu, Jan 24, 2019 at 6:32 AM Verma, Vishal L > > wrote: > > > > > > On Wed, 2019-01-16 at 20:49 +1100, Oliver O'Halloran wrote: > > > > Newer kernels provide the "supported_alignm

Re: [PATCH v3 1/6] libndctl: Use the supported_alignment attribute

2019-01-28 Thread Verma, Vishal L
On Tue, 2019-01-29 at 10:11 +1100, Oliver wrote: > On Thu, Jan 24, 2019 at 6:32 AM Verma, Vishal L > wrote: > > > > On Wed, 2019-01-16 at 20:49 +1100, Oliver O'Halloran wrote: > > > Newer kernels provide the "supported_alignments" sysfs attribute that > > > indicates what alignments can be used

Re: [PATCH v3 1/6] libndctl: Use the supported_alignment attribute

2019-01-28 Thread Oliver
On Thu, Jan 24, 2019 at 6:32 AM Verma, Vishal L wrote: > > > On Wed, 2019-01-16 at 20:49 +1100, Oliver O'Halloran wrote: > > Newer kernels provide the "supported_alignments" sysfs attribute that > > indicates what alignments can be used with a PFN or DAX namespace. This > > patch adds the plumbing

RE: [PATCH] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-01-28 Thread Dexuan Cui
> From: Dan Williams > Sent: Monday, January 28, 2019 1:55 PM > > On Mon, Jan 28, 2019 at 1:40 PM Dexuan Cui wrote: > > > I made the below simple change. Is this enough? Please suggest the proper > > wording/sentence, as I'm relatively new to NVDIMM, and I don't really know > the history of the

Re: [PATCH] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-01-28 Thread Dan Williams
On Mon, Jan 28, 2019 at 1:40 PM Dexuan Cui wrote: > > > From: Dan Williams > > Sent: Monday, January 28, 2019 1:01 PM > > > > Hi Dexuan, > > Looks good. Just one update request and a note below... > > > > On Wed, Jan 23, 2019 at 12:51 PM Dexuan Cui wrote: > > > ... > > > --- a/drivers/acpi/nfit/

RE: [PATCH] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-01-28 Thread Dexuan Cui
> From: Dan Williams > Sent: Monday, January 28, 2019 1:01 PM > > Hi Dexuan, > Looks good. Just one update request and a note below... > > On Wed, Jan 23, 2019 at 12:51 PM Dexuan Cui wrote: > > ... > > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1840,7 +1840,7 @@ s

Re: [PATCH] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-01-28 Thread Dan Williams
Hi Dexuan, Looks good. Just one update request and a note below... On Wed, Jan 23, 2019 at 12:51 PM Dexuan Cui wrote: > > > Add the Hyper-V _DSM command set to the white list of NVDIMM command > sets. > > This command set is documented at http://www.uefi.org/RFIC_LIST > (see the link to "Virtual

Re: [PATCH 0/5] [v4] Allow persistent memory to be used like normal RAM

2019-01-28 Thread Dave Hansen
On 1/28/19 3:09 AM, Balbir Singh wrote: >> This is intended for Intel-style NVDIMMs (aka. Intel Optane DC >> persistent memory) NVDIMMs. These DIMMs are physically persistent, >> more akin to flash than traditional RAM. They are also expected to >> be more cost-effective than using RAM, which is

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-01-28 Thread Dan Williams
On Mon, Jan 28, 2019 at 1:26 AM Michal Hocko wrote: > > On Fri 25-01-19 11:15:08, Dan Williams wrote: > [...] > > However, we should consider this along with the userspace enabling to > > control which device-dax instances are set aside for hotplug. It would > > make sense to have a "clear errors

Re: [PATCH] MAINTAINERS: Update filesystem-dax and NVDIMM entries

2019-01-28 Thread Jan Kara
On Thu 24-01-19 11:17:59, Dan Williams wrote: > Ross has moved on to other areas. > > Matthew and Jan are trusted reviewers for DAX. > > Dan is now coordinating filesystem-dax pull requests. > > Ira and Keith are now involved with the NVDIMM and Device-DAX > sub-systems. > > The linux-nvdimm ma

Re: [PATCH 0/5] [v4] Allow persistent memory to be used like normal RAM

2019-01-28 Thread Balbir Singh
On Thu, Jan 24, 2019 at 03:14:41PM -0800, Dave Hansen wrote: > v3 spurred a bunch of really good discussion. Thanks to everybody > that made comments and suggestions! > > I would still love some Acks on this from the folks on cc, even if it > is on just the patch touching your area. > > Note: th

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-01-28 Thread Michal Hocko
On Fri 25-01-19 11:15:08, Dan Williams wrote: [...] > However, we should consider this along with the userspace enabling to > control which device-dax instances are set aside for hotplug. It would > make sense to have a "clear errors before hotplug" configuration > option. I am not sure I understa