Re: [PATCH 7/7] libnvdimm/pfn: Fix 'start_pad' implementation

2019-02-21 Thread Dan Williams
[ add linux-mm ] On Thu, Feb 21, 2019 at 3:47 PM Jeff Moyer wrote: > > Hi, Dan, > > Thanks for the comprehensive write-up. Comments below. > > Dan Williams writes: > > > In the beginning the pmem driver simply passed the persistent memory > > resource range to memremap and was done. With the

Re: question about page tables in DAX/FS/PMEM case

2019-02-21 Thread Jerome Glisse
On Thu, Feb 21, 2019 at 02:58:27PM -0800, Larry Bassel wrote: > [adding linux-mm] > > On 21 Feb 19 15:41, Jerome Glisse wrote: > > On Wed, Feb 20, 2019 at 03:06:22PM -0800, Larry Bassel wrote: > > > I'm working on sharing page tables in the DAX/XFS/PMEM/PMD case. > > > > > > If multiple

Re: question about page tables in DAX/FS/PMEM case

2019-02-21 Thread Dave Hansen
On 2/21/19 2:58 PM, Larry Bassel wrote: > AFAIK there is no hardware benefit from sharing the page table > directory within different page table. So the only benefit is the > amount of memory we save. The hardware benefit from schemes like this is that the CPU caches are better utilized. If two

Re: [PATCH 7/7] libnvdimm/pfn: Fix 'start_pad' implementation

2019-02-21 Thread Jeff Moyer
Hi, Dan, Thanks for the comprehensive write-up. Comments below. Dan Williams writes: > In the beginning the pmem driver simply passed the persistent memory > resource range to memremap and was done. With the introduction of > devm_memremap_pages() and vmem_altmap the implementation needed to

Re: question about page tables in DAX/FS/PMEM case

2019-02-21 Thread Larry Bassel
[adding linux-mm] On 21 Feb 19 15:41, Jerome Glisse wrote: > On Wed, Feb 20, 2019 at 03:06:22PM -0800, Larry Bassel wrote: > > I'm working on sharing page tables in the DAX/XFS/PMEM/PMD case. > > > > If multiple processes would use the identical page of PMDs corresponding > > to a 1 GiB address

Re: question about page tables in DAX/FS/PMEM case

2019-02-21 Thread Jerome Glisse
On Wed, Feb 20, 2019 at 03:06:22PM -0800, Larry Bassel wrote: > I'm working on sharing page tables in the DAX/XFS/PMEM/PMD case. > > If multiple processes would use the identical page of PMDs corresponding > to a 1 GiB address range of DAX/XFS/PMEM/PMDs, presumably one can instead > of populating

RE: [ndctl PATCH v2 4/4] ndctl, monitor: support NVDIMM_FAMILY_HYPERV

2019-02-21 Thread Dexuan Cui
> From: qi.f...@fujitsu.com > Sent: Thursday, February 21, 2019 12:40 AM > > ... > > + /* > > +* Hyper-V Virtual NVDIMM doesn't use ND_CMD_SMART to get the > > health info. Instead, it uses ND_CMD_CALL, so the checking here can't > > +* apply, and it doesn't support threshold alarms --

Re: [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks

2019-02-21 Thread Borislav Petkov
On Thu, Feb 21, 2019 at 11:11:27AM -0500, Jeff Moyer wrote: > Anyway, given that the correctable errors collector can be turned off in > the kernel config, Also, on the cmdline, for whatever reason: ras=cec_disable -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting

Re: [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks

2019-02-21 Thread Jeff Moyer
Dan Williams writes: > On Wed, Feb 20, 2019 at 11:26 AM Jeff Moyer wrote: >> >> Borislav Petkov writes: >> >> > Drop stable@ >> > >> > On Wed, Feb 20, 2019 at 01:59:15PM -0500, Jeff Moyer wrote: >> >> Sorry for necroposting. I thought the point of the CEC was to make sure >> >> that the other

[PATCH] libnvdimm, region: use struct_size() in kzalloc()

2019-02-21 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; instance =

Re: [PATCH] acpi/nfit: Fix bus command validation

2019-02-21 Thread Johannes Thumshirn
[+CC dvyukov ] On 20/02/2019 18:21, Johannes Thumshirn wrote: > On 20/02/2019 17:15, Dan Williams wrote:> I wouldn't be opposed to > syzkaller fuzzing the nvdimm-ioctl path. > As a heads up, I've started adding the ioctl() definitions to syzcaller. > Just so we don't duplicate any efforts. So

RE: [ndctl PATCH v2 4/4] ndctl, monitor: support NVDIMM_FAMILY_HYPERV

2019-02-21 Thread qi.f...@fujitsu.com
> -Original Message- > From: Dexuan Cui [mailto:de...@microsoft.com] > Sent: Wednesday, February 20, 2019 2:12 PM > To: Dave Jiang ; Vishal Verma > ; Dan Williams ; > linux-nvdimm@lists.01.org; Michael Kelley ; Qi, > Fuli/斉 福利 ; Johannes Thumshirn > Subject: [ndctl PATCH v2 4/4] ndctl,