Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread David Hildenbrand
On 27.03.19 17:13, Michal Hocko wrote: > On Tue 26-03-19 17:20:41, Dan Williams wrote: >> On Tue, Mar 26, 2019 at 1:04 AM Michal Hocko wrote: >>> >>> On Mon 25-03-19 13:03:47, Dan Williams wrote: On Mon, Mar 25, 2019 at 3:20 AM Michal Hocko wrote: >>> [...] >> User-defined memory namespa

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread Michal Hocko
On Thu 28-03-19 14:38:15, David Hildenbrand wrote: > On 27.03.19 17:13, Michal Hocko wrote: [...] > > People are asking for a smaller memory hotplug granularity for other > > usecases (e.g. memory ballooning into VMs) which are quite dubious to > > be honest and not really worth all the code rework

Re: [PATCH RT] nvdimm: make lane acquirement RT aware

2019-03-28 Thread Sebastian Andrzej Siewior
On 2019-03-18 11:48:28 [+], Liu, Yongxin wrote: > > > > > Bummer. That would dead lock indeed. > > Is it easily possible to recognize the recursive case? > > Not easily. I don't have test case for recursive call. > For now, just code analysis. So I've been playing with qemu's nvdimm device

[PATCH 3/3] ndctl: add unit test for load-keys

2019-03-28 Thread Dave Jiang
Add to security.sh to test load-keys for user keys. Signed-off-by: Dave Jiang --- test/security.sh | 56 ++ 1 file changed, 52 insertions(+), 4 deletions(-) diff --git a/test/security.sh b/test/security.sh index 1b7a9a1a..7bd60293 100755 ---

[PATCH 2/3] ndctl: fix key blob loading for user keys

2019-03-28 Thread Dave Jiang
The syntax for loading user master key is different than loading a trusted key. Fix so we can load user key properly. Signed-off-by: Dave Jiang --- ndctl/load-keys.c | 13 + ndctl/util/keys.c | 20 +++- ndctl/util/keys.h | 10 -- 3 files changed, 28 inse

[PATCH 1/3] ndctl: fix load-keys for user master-key

2019-03-28 Thread Dave Jiang
load-keys incorrectly assumes that all keys have TPM handles. TPM handle is only for trusted-keys. Fix in order to allow user master-key work. Signed-off-by: Dave Jiang --- ndctl/load-keys.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ndctl/load-keys.c b/ndctl/lo

Re: [PATCH 1/3] ndctl: fix load-keys for user master-key

2019-03-28 Thread Dan Williams
On Thu, Mar 28, 2019 at 12:07 PM Dave Jiang wrote: > > load-keys incorrectly assumes that all keys have TPM handles. TPM handle is > only for trusted-keys. Fix in order to allow user master-key work. s/work/to operate/ ? > > Signed-off-by: Dave Jiang > --- > ndctl/load-keys.c |6 ++ >

Re: [PATCH 1/3] ndctl: fix load-keys for user master-key

2019-03-28 Thread Dave Jiang
On 3/28/19 12:11 PM, Dan Williams wrote: > On Thu, Mar 28, 2019 at 12:07 PM Dave Jiang wrote: >> >> load-keys incorrectly assumes that all keys have TPM handles. TPM handle is >> only for trusted-keys. Fix in order to allow user master-key work. > > s/work/to operate/ ? > >> >> Signed-off-by:

Re: [PATCH 2/3] ndctl: fix key blob loading for user keys

2019-03-28 Thread Dan Williams
On Thu, Mar 28, 2019 at 12:07 PM Dave Jiang wrote: > > The syntax for loading user master key is different than loading a trusted > key. Fix so we can load user key properly. > > Signed-off-by: Dave Jiang > --- > ndctl/load-keys.c | 13 + > ndctl/util/keys.c | 20 +++-

Re: [PATCH 1/3] ndctl: fix load-keys for user master-key

2019-03-28 Thread Dan Williams
On Thu, Mar 28, 2019 at 12:17 PM Dave Jiang wrote: > > > > On 3/28/19 12:11 PM, Dan Williams wrote: > > On Thu, Mar 28, 2019 at 12:07 PM Dave Jiang wrote: > >> > >> load-keys incorrectly assumes that all keys have TPM handles. TPM handle is > >> only for trusted-keys. Fix in order to allow user m

Re: [PATCH 2/3] ndctl: fix key blob loading for user keys

2019-03-28 Thread Dave Jiang
On 3/28/19 12:18 PM, Dan Williams wrote: > On Thu, Mar 28, 2019 at 12:07 PM Dave Jiang wrote: >> >> The syntax for loading user master key is different than loading a trusted >> key. Fix so we can load user key properly. >> >> Signed-off-by: Dave Jiang >> --- >> ndctl/load-keys.c | 13 +

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread David Hildenbrand
On 22.03.19 17:57, Dan Williams wrote: > Changes since v4 [1]: > - Given v4 was from March of 2017 the bulk of the changes result from > rebasing the patch set from a v4.11-rc2 baseline to v5.1-rc1. > > - A unit test is added to ndctl to exercise the creation and dax > mounting of multiple ind

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread Dan Williams
On Thu, Mar 28, 2019 at 1:10 PM David Hildenbrand wrote: > > On 22.03.19 17:57, Dan Williams wrote: > > Changes since v4 [1]: > > - Given v4 was from March of 2017 the bulk of the changes result from > > rebasing the patch set from a v4.11-rc2 baseline to v5.1-rc1. > > > > - A unit test is added

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread David Hildenbrand
>> You are using the term "Sub-section memory hotplug support", but is it >> actually what you mean? To rephrase, aren't we talking here about >> "Sub-section device memory hotplug support" or similar? > > Specifically it is support for passing @start and @size arguments to > arch_add_memory() tha

Re: [PATCH 3/3] ndctl: add unit test for load-keys

2019-03-28 Thread Verma, Vishal L
On Thu, 2019-03-28 at 12:07 -0700, Dave Jiang wrote: > Add to security.sh to test load-keys for user keys. > > Signed-off-by: Dave Jiang > --- > test/security.sh | 56 > ++ > 1 file changed, 52 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread Dan Williams
On Thu, Mar 28, 2019 at 2:17 PM David Hildenbrand wrote: > > >> You are using the term "Sub-section memory hotplug support", but is it > >> actually what you mean? To rephrase, aren't we talking here about > >> "Sub-section device memory hotplug support" or similar? > > > > Specifically it is supp

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread David Hildenbrand
Reason I am asking is because I wonder how that would interact with the memory block device infrastructure and hotplugging of system ram - add_memory()/add_memory_resource(). I *assume* you are not changing the add_memory() interface, so that one still only works with whole sect

[PATCH v2 1/3] ndctl: fix load-keys for user master-key

2019-03-28 Thread Dave Jiang
load-keys incorrectly assumes that all keys have TPM handles. TPM handle is only for trusted-keys. Fix in order to allow user master-key to operate. Signed-off-by: Dave Jiang --- v2: - Make output go to stderr. (Dan) ndctl/load-keys.c |6 ++ 1 file changed, 2 insertions(+), 4 deletion

[PATCH v2 2/3] ndctl: fix key blob loading for user keys

2019-03-28 Thread Dave Jiang
The syntax for loading user master key is different than loading a trusted key. Fix so we can load user key properly. Signed-off-by: Dave Jiang --- v2: No change ndctl/load-keys.c | 13 + ndctl/util/keys.c | 20 +++- ndctl/util/keys.h | 10 -- 3 files

[PATCH v2 3/3] ndctl: add unit test for load-keys

2019-03-28 Thread Dave Jiang
Add to security.sh to test load-keys for user keys. Signed-off-by: Dave Jiang --- V2: - Add quotes around $masterkey. (Vishal) - Change fail to failed in output. (Vishal) test/security.sh | 68 -- 1 file changed, 61 insertions(+), 7 deletio

[no subject]

2019-03-28 Thread 邀请函
转发邮件信息 发件人:mivczr...@exu.net 发送日期:2019-3-29 8:36:49 收件人:linux-nvdimm@lists.01.org ~附~件~内~容~请~您~查~阅~ 8:36:49 ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm