Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-23 Thread Daniel Vetter
On Wed, May 22, 2019 at 02:38:48PM -0700, Brendan Higgins wrote: > +Bjorn Helgaas > > On Wed, May 15, 2019 at 12:41 AM Daniel Vetter wrote: > > > > On Tue, May 14, 2019 at 11:36:18AM -0700, Brendan Higgins wrote: > > > On Tue, May 14, 2019 at 02:05:05PM +0200, Daniel Vetter wrote: > > > > On Tue,

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-23 Thread Shiyang Ruan
On 5/22/19 12:51 AM, Darrick J. Wong wrote: On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: From: Goldwyn Rodrigues The IOMAP_DAX_COW is a iomap type which performs copy of edges of data while performing a write if start/end are not page aligned. The source address is exp

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-23 Thread Goldwyn Rodrigues
On 17:05 23/05, Shiyang Ruan wrote: > > > On 5/22/19 12:51 AM, Darrick J. Wong wrote: > > On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: > > > From: Goldwyn Rodrigues > > > > > > The IOMAP_DAX_COW is a iomap type which performs copy of > > > edges of data while performing a

Re: [PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-05-23 Thread Jan Kara
On Tue 21-05-19 10:46:25, Darrick J. Wong wrote: > On Mon, Apr 29, 2019 at 12:26:39PM -0500, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > Change dax_iomap_pfn to return the address as well in order to > > use it for performing a memcpy in case the type is IOMAP_DAX_COW. > > We don

Re: [PATCH 10/18] dax: replace mmap entry in case of CoW

2019-05-23 Thread Jan Kara
On Mon 29-04-19 12:26:41, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > We replace the existing entry to the newly allocated one > in case of CoW. Also, we mark the entry as PAGECACHE_TAG_TOWRITE > so writeback marks this entry as writeprotected. This > helps us snapshots so new write pa

Re: [PATCH 12/18] btrfs: allow MAP_SYNC mmap

2019-05-23 Thread Jan Kara
On Mon 29-04-19 12:26:43, Goldwyn Rodrigues wrote: > From: Adam Borowski > > Used by userspace to detect DAX. > [rgold...@suse.com: Added CONFIG_FS_DAX around mmap_supported_flags] Why the CONFIG_FS_DAX bit? Your mmap(2) implementation understands implications of MAP_SYNC flag and that's all tha

Re: [PATCH 16/18] btrfs: Writeprotect mmap pages on snapshot

2019-05-23 Thread Jan Kara
On Mon 29-04-19 12:26:47, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Inorder to make sure mmap'd files don't change after snapshot, > writeprotect the mmap pages on snapshot. This is done by performing > a data writeback on the pages (which simply mark the pages are > wrprotected). Th

Re: [PATCH 16/18] btrfs: Writeprotect mmap pages on snapshot

2019-05-23 Thread Goldwyn Rodrigues
On 16:04 23/05, Jan Kara wrote: > On Mon 29-04-19 12:26:47, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > Inorder to make sure mmap'd files don't change after snapshot, > > writeprotect the mmap pages on snapshot. This is done by performing > > a data writeback on the pages (which

Re: [PATCH 12/18] btrfs: allow MAP_SYNC mmap

2019-05-23 Thread Adam Borowski
On Thu, May 23, 2019 at 03:44:49PM +0200, Jan Kara wrote: > On Mon 29-04-19 12:26:43, Goldwyn Rodrigues wrote: > > From: Adam Borowski > > > > Used by userspace to detect DAX. > > [rgold...@suse.com: Added CONFIG_FS_DAX around mmap_supported_flags] > > Why the CONFIG_FS_DAX bit? Your mmap(2) imp

Re: [PATCH 16/18] btrfs: Writeprotect mmap pages on snapshot

2019-05-23 Thread Jan Kara
On Thu 23-05-19 10:27:22, Goldwyn Rodrigues wrote: > On 16:04 23/05, Jan Kara wrote: > > On Mon 29-04-19 12:26:47, Goldwyn Rodrigues wrote: > > > From: Goldwyn Rodrigues > > > > > > Inorder to make sure mmap'd files don't change after snapshot, > > > writeprotect the mmap pages on snapshot. This

Re: [PATCH 16/18] btrfs: Writeprotect mmap pages on snapshot

2019-05-23 Thread Goldwyn Rodrigues
On 21:07 23/05, Jan Kara wrote: > On Thu 23-05-19 10:27:22, Goldwyn Rodrigues wrote: > > On 16:04 23/05, Jan Kara wrote: > > > On Mon 29-04-19 12:26:47, Goldwyn Rodrigues wrote: > > > > From: Goldwyn Rodrigues > > > > > > > > Inorder to make sure mmap'd files don't change after snapshot, > > > >